Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info

2012-04-23 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103028/#review12814 --- Bump. Should I port this to to-be kdelibs 4.9, or is it too

Re: Fwd: import kde-thumbnail-po into kdesdk

2012-04-23 Thread nihui水竹院落
hi all what about through kde reviewboard, like kio-recentdocuments plugin[1]I don't think it is necessary for a plugin to follow application lifecycle policy to get into kde main modules or extragear ones.but I couldn't find the reviewboard group for kdesdk, so I may have to put this

Re: Moving libsolid-hal to unmaintained?

2012-04-23 Thread Rolf Eike Beer
Is there a way to have it so HAL is enabled by default on BSD systems, but on Linux systems you need to manually use a cmake flag to enable it? if (CMAKE_SYSTEM_NAME MATCHES BSD) set(HAL_OPTION_DEFAULT TRUE) else () set(HAL_OPTION DEFAULT FALSE) endif () option(KDE4_USE_HAL Enable Solid

Re: Fwd: import kde-thumbnail-po into kdesdk

2012-04-23 Thread Laszlo Papp
what about through kde reviewboard, like kio-recentdocuments plugin[1] I don't think it is necessary for a plugin to follow application lifecycle policy to get into kde main modules or extragear ones. but I couldn't find the reviewboard group for kdesdk, so I may have to put this plugin in

Re: Re: Moving libsolid-hal to unmaintained?

2012-04-23 Thread Alex Fiestas
On Monday, April 23, 2012 11:18:14 AM todd rme wrote: Is there a way to have it so HAL is enabled by default on BSD systems, but on Linux systems you need to manually use a cmake flag to enable it? Well I don't see why we need HAL on Linux, so unless you can give me some reason too keep it I

Re: Moving libsolid-hal to unmaintained?

2012-04-23 Thread Raphael Kubo da Costa
Alex Fiestas afies...@kde.org writes: On Monday, April 23, 2012 11:18:14 AM todd rme wrote: Is there a way to have it so HAL is enabled by default on BSD systems, but on Linux systems you need to manually use a cmake flag to enable it? Well I don't see why we need HAL on Linux, so unless you

Re: Moving libsolid-hal to unmaintained?

2012-04-23 Thread Kevin Ottens
On Monday 23 April 2012 11:22:15 Raphael Kubo da Costa wrote: Alex Fiestas afies...@kde.org writes: On Monday, April 23, 2012 11:18:14 AM todd rme wrote: Is there a way to have it so HAL is enabled by default on BSD systems, but on Linux systems you need to manually use a cmake flag to

Re: Moving libsolid-hal to unmaintained?

2012-04-23 Thread Kevin Ottens
On Monday 23 April 2012 11:18:14 todd rme wrote: Is there a way to have it so HAL is enabled by default on BSD systems, but on Linux systems you need to manually use a cmake flag to enable it? It's kind of already the case, except that instead of a CMake flag, right now it's controlled by an

Re: Review Request: Make nepomuk runner remove undesired matches

2012-04-23 Thread Lamarque Vieira Souza
On April 15, 2012, 5:21 p.m., Sebastian Trueg wrote: This is actually a bug that needs to be addressed differently. Your solution is simply a hack. Normally Nepomuk should not return those results at all. The question is though: why does it? Only if we figure that out we can fix it

Re: Fwd: import kde-thumbnail-po into kdesdk

2012-04-23 Thread Albert Astals Cid
El Dilluns, 23 d'abril de 2012, a les 01:49:04, nihui水竹院落 va escriure: hi all what about through kde reviewboard, like kio-recentdocuments plugin[1]I don't think it is necessary for a plugin to follow application lifecycle policy to get into kde main modules or extragear ones. Why not? What's

KIO / KWebView and PrivateBrowsing (Cookies)

2012-04-23 Thread Alex Fiestas
KWebView can't do Private Browsing because of KIO integration, need advice on how to fix it but first let me explain the issue. What I consider PrivateBrowsing: Private Browsing should have an empty CookieJar that will keep cookies only as long as the private browsing is activated, after that

Integration QWebView with KDE

2012-04-23 Thread Alex Fiestas
I'm having some issues with KWebView + Cookies + PrivateBrowsing http://lists.kde.org/?l=kde-core-develm=133520146629307w=2 and I need to workaround that issues at least until we fix them. I thought on using QWebView but then we will be lacking KDE integration, my question is: what integration

Re: [kde-solaris] Moving libsolid-hal to unmaintained?

2012-04-23 Thread Pavel Heimlich, a.k.a. hajma
2012/4/22 Raphael Kubo da Costa rak...@freebsd.org: Alex Fiestas afies...@kde.org writes: So real question is, who is using libsolid-hal nowdays? At least the BSD people are; nobody came up with a BSD implementation of the *kit/u* stuff from Linux, so we're still using Hal. The same applies

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info

2012-04-23 Thread Alex Fiestas
On April 22, 2012, 9:36 p.m., Matěj Laitl wrote: Bump. Should I port this to to-be kdelibs 4.9, or is it too late? Is the patch any different? it should be just the same. In that case please, apply this patch to 4.8, 4.9 and Frameworks. - Alex

RE: import kde-thumbnail-po into kdesdk

2012-04-23 Thread nihui水竹院落
hi the code has already been in kdereview now.[1] regards, nihui [1] http://websvn.kde.org/?view=revisionrevision=1291261

Review Request: Install additional headers from libkonq

2012-04-23 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104700/ --- Review request for KDE Base Apps. Description --- Dolphin requires a

kde-thumbnail-po in kdereview WAS Re: import kde-thumbnail-po into kdesdk

2012-04-23 Thread Albert Astals Cid
El Dilluns, 23 d'abril de 2012, a les 14:41:40, nihui水竹院落 va escriure: hi the code has already been in kdereview now.[1] I'd like that you changed the find_library(GETTEXTPO_LIBRARY NAMES gettextpo REQUIRED) to macro_optional_find_package macro_log_feature macro_display_feature_log so once

Re: Integration QWebView with KDE

2012-04-23 Thread Dawit A
On Mon, Apr 23, 2012 at 1:20 PM, Alex Fiestas afies...@kde.org wrote: I'm having some issues with KWebView + Cookies + PrivateBrowsing http://lists.kde.org/?l=kde-core-develm=133520146629307w=2 and I need to workaround that issues at least until we fix them. Ahh... why have another post

Re: Re: Integration QWebView with KDE

2012-04-23 Thread Alex Fiestas
On Monday, April 23, 2012 03:04:25 PM Dawit A wrote: On Mon, Apr 23, 2012 at 1:20 PM, Alex Fiestas afies...@kde.org wrote: I'm having some issues with KWebView + Cookies + PrivateBrowsing http://lists.kde.org/?l=kde-core-develm=133520146629307w=2 and I need to workaround that issues at