Re: Review Request: New KDE Macro for to wrap the noreturn attribute

2012-04-28 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103832/#review13016 --- it's not necessary to add that _feature_ to 4.8, and for

Re: Extra KDE Telepathy modules moving to Extragear

2012-04-28 Thread George Kiagiadakis
On Thu, Apr 26, 2012 at 11:07 PM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 25 d'abril de 2012, a les 18:15:00, David Edmundson va escriure: We would like to move 2 more KDE Telepathy modules to Extragear, to join our existing code. KTp Call UI [1] Provides a GUI for making video

Re: Extra KDE Telepathy modules moving to Extragear

2012-04-28 Thread Albert Astals Cid
El Dissabte, 28 d'abril de 2012, a les 16:08:41, George Kiagiadakis va escriure: On Thu, Apr 26, 2012 at 11:07 PM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 25 d'abril de 2012, a les 18:15:00, David Edmundson va escriure: We would like to move 2 more KDE Telepathy modules to

Re: Review request: AppMenu support for KDE

2012-04-28 Thread Albert Astals Cid
El Divendres, 27 d'abril de 2012, a les 09:35:14, Lionel Chauvin va escriure: The code that bring support of AppMenu to KDE needs to be reviewed before it entered in KDE main module: https://projects.kde.org/projects/kdereview/kded-appmenu/repository It contains a KDED module and a library.

Re: Extra KDE Telepathy modules moving to Extragear

2012-04-28 Thread Kevin Krammer
On Saturday, 2012-04-28, George Kiagiadakis wrote: No, the classes that wrap GObjects do not need a d-pointer. All the calls are forwarded to the underlying GObject and if for any reason we ever need to save extra data on the wrapper class (which is highly unlikely), we should use the GObject

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info

2012-04-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103028/#review13040 --- This review has been submitted with commit

Re: Extra KDE Telepathy modules moving to Extragear

2012-04-28 Thread Martin Klapetek
On Sat, Apr 28, 2012 at 22:44, Kevin Krammer kram...@kde.org wrote: On Saturday, 2012-04-28, George Kiagiadakis wrote: No, the classes that wrap GObjects do not need a d-pointer. All the calls are forwarded to the underlying GObject and if for any reason we ever need to save extra data on