Re: Review Request: show video previews according to file content instead of mimetype string
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104988/ --- (Updated May 19, 2012, 6:54 a.m.) Review request for Dolphin, KDE Base Apps and Peter Penz. Description --- This patch makes dolphin information panel to show a video widget depending on the video content instead of mimetype string. There are container formats which can be either audios or videos. Besides, the rmvb video files have mimetype of application/vnd.rn-realmedia, and these files can be recognized as videos correctly now. Diffs - dolphin/src/panels/information/informationpanelcontent.h 1d964f5 dolphin/src/panels/information/informationpanelcontent.cpp 4a96bd1 dolphin/src/panels/information/phononwidget.h 1e1ea37 dolphin/src/panels/information/phononwidget.cpp 5f0c111 Diff: http://git.reviewboard.kde.org/r/104988/diff/ Testing --- with no more regressions. Thanks, Hui Ni
Re: Deleting kdepalettes from kdesdk
On 05/18/2012 03:23 PM, Friedrich W. H. Kossebau wrote: So in preparation for the migration of kdesdk to git I will be simply removing kdesdk/kdepalettes, next Sunday, May 20th, in the European evening, unless anyone objects. I'm curious about the connection between these two. Where will the history of the palettes be available in the converted git reposito- ries? Cheers Friedrich -- Best regards, Eike Hein
Re: kio and frameworks 5
I'm wondering if there is a timeframe for KIO refresh in KDE5? Getting improved metadata handling in there would be a great benefit IMHO. To the point where I might start attaching patches to that effect ;)
Re: Deleting kdepalettes from kdesdk
Am Samstag, 19. Mai 2012, 10:14:26 schrieb Eike Hein: On 05/18/2012 03:23 PM, Friedrich W. H. Kossebau wrote: So in preparation for the migration of kdesdk to git I will be simply removing kdesdk/kdepalettes, next Sunday, May 20th, in the European evening, unless anyone objects. I'm curious about the connection between these two. Where will the history of the palettes be available in the converted git reposito- ries? Good question. So far nowhere. kdesdk/kdepalettes is a one-time-commit/dump of the palettes without any further changes, so there is no real history besides the commit log Initial import of the palettes and the date (actually Sun Jan 3 1999, so even the palette of KDE1 times), the only other commit, a move, was due to the introduction of /trunk/KDE. The kdesdk module will be split over multiple repos, and none so far has kdepalettes included (but then plans for splitting are not completed yet). Just, none of the candidates is related to palettes, so who would search the history/files of kdepalettes there? Would moving to tags/unmaintained/1 (or 2?) in svn be a way to secure the history to a degree? Initially I thought they are not unmaintained, but simply outdated (and kind-of continued in another place, at least the GIMP-style version, without any connection), so that is why I proposed to simply delete them. So? Instead of remove do a move to tags/unmaintained/2 ? Cheers Friedrich
Re: Deleting kdepalettes from kdesdk
On 05/19/2012 12:49 PM, Friedrich W. H. Kossebau wrote: So? Instead of remove do a move to tags/unmaintained/2 ? Aye, sounds like a good solution to me. Thanks! Cheers Friedrich -- Best regards, Eike Hein
Re: kio and frameworks 5
On Fri, May 18, 2012 at 11:31 PM, Ben Martin monke...@users.sourceforge.net wrote: I'm wondering if there is a timeframe for KIO refresh in KDE5? Getting improved metadata handling in there would be a great benefit IMHO. To the point where I might start attaching patches to that effect ;) What does improved meta-data handling mean ? Sending additional ioslave specific information to/from the ioslave and vise-versa ? If that is the case, then it is already possible to do that right now to some degree using KIO's meta data system.
Re: Review Request: Fix for SSL handeshake failure in TcpSlaveBase due to server not supporting SSL compression
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103610/ --- (Updated May 19, 2012, 4:36 p.m.) Review request for kdelibs and Thiago Macieira. Changes --- Modified the patch to address the following additional issues: Fixed very very long connection times when vising certain sites, e.g. Apply Now button at http://www.suse.com/company/careers/, by using KTcpSocket::SecureProtocols instead of KTcpSocket:TlsV1 as the default SSL protocol. Improved the speed of SSL negotiation by caching and sharing the previous settings amongst ioslaves when those settings are not the default ones. That way any ioslave that connects to the same host afterwards does not have to perform the same expensive SSL negotiation process all over again. Description --- The attached patch addresses the issue of SSL handshake failure in TcpSlaveBase due to lack of support for disabling SSL compression in Qt. As of 4.8, Qt supports this functionality so this patch implements support for activing that support in KTcpSocket and using it from KIO::TcpSlaveBase so that users will be able to browse SSL protected sites that do not support SSL compression. This addresses bug 275524. http://bugs.kde.org/show_bug.cgi?id=275524 Diffs (updated) - kio/kio/tcpslavebase.h fea2c08 kio/kio/tcpslavebase.cpp d0f92b4 Diff: http://git.reviewboard.kde.org/r/103610/diff/ Testing --- Visit the site listed in the bug report: https://tim.rz.rwth-aachen.de/mail-lifecycle/ Thanks, Dawit Alemayehu
Re: KDELibsNightly.cmake
Am Donnerstag, 17. Mai 2012, 13:30:24 schrieb Andreas Pakulat: Hi, I think this techbase article is pretty much up-to-date. I guess the KDElibsNighly.cmake file should simply be deleted. http://techbase.kde.org/Development/CMake/DashboardBuilds This points to quality/nightly-support/KDE/KDELibsNightly.cmake: # The VCS of KDE is svn, also specify the repository set(KDE_CTEST_VCS svn) set(KDE_CTEST_VCS_REPOSITORY svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs) Eike signature.asc Description: This is a digitally signed message part.
Re: Review Request: show video previews according to file content instead of mimetype string
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104988/#review13987 --- This review has been submitted with commit 3faed364339edef012b04db23fea055e7ff26121 by Peter Penz to branch master. - Commit Hook On May 19, 2012, 6:54 a.m., Hui Ni wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104988/ --- (Updated May 19, 2012, 6:54 a.m.) Review request for Dolphin, KDE Base Apps and Peter Penz. Description --- This patch makes dolphin information panel to show a video widget depending on the video content instead of mimetype string. There are container formats which can be either audios or videos. Besides, the rmvb video files have mimetype of application/vnd.rn-realmedia, and these files can be recognized as videos correctly now. Diffs - dolphin/src/panels/information/informationpanelcontent.h 1d964f5 dolphin/src/panels/information/informationpanelcontent.cpp 4a96bd1 dolphin/src/panels/information/phononwidget.h 1e1ea37 dolphin/src/panels/information/phononwidget.cpp 5f0c111 Diff: http://git.reviewboard.kde.org/r/104988/diff/ Testing --- with no more regressions. Thanks, Hui Ni
Re: Review Request: show video previews according to file content instead of mimetype string
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104988/#review13988 --- Thanks a lot for the patch, looks good! I've just tested it: It works fine and I've pushed it to master. I initially was a little bit confused about the semantics of the hasVideoChanged()-signal and wanted to adjust the name of the signal. But I've seen you've taken the same name as Phonon uses in the MediaObject and probably we should stay consistent here. So I've only added a small comment to the signal... - Peter Penz On May 19, 2012, 6:54 a.m., Hui Ni wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104988/ --- (Updated May 19, 2012, 6:54 a.m.) Review request for Dolphin, KDE Base Apps and Peter Penz. Description --- This patch makes dolphin information panel to show a video widget depending on the video content instead of mimetype string. There are container formats which can be either audios or videos. Besides, the rmvb video files have mimetype of application/vnd.rn-realmedia, and these files can be recognized as videos correctly now. Diffs - dolphin/src/panels/information/informationpanelcontent.h 1d964f5 dolphin/src/panels/information/informationpanelcontent.cpp 4a96bd1 dolphin/src/panels/information/phononwidget.h 1e1ea37 dolphin/src/panels/information/phononwidget.cpp 5f0c111 Diff: http://git.reviewboard.kde.org/r/104988/diff/ Testing --- with no more regressions. Thanks, Hui Ni
