Re: Review request: moving libkgoogle to extragear
On Saturday 26 of May 2012 11:42:41 Raphael Kubo da Costa wrote:
Dan Vratil d...@progdan.cz writes:
Hi,
LibKGoogle is a new optional dependency of kdepim-runtime. It's used by
the
new Akonadi Google resources.
It's now in kdereview [0] and I'd like to move it to extragear, so I'm
asking for a review on the library.
One thing I have noticed is that libkgoogle seems to be GPLv3+, while
KDE's licensing policy [1] says code under the GPL should be GPLv2+.
As far as I understand the policies, libkgoogle is a subject to point 5, which
says
Any other source files must be licensed under one of the terms listed under 4)
or one of the following terms
* GPL version 2 as listed in kdelibs/COPYING or later
* GPL version 2 or version 3 or later versions approved by the membership of
KDE e.V.
* ...
I understand the second item as either GPLv2 or GPLv3 or any later approved
version, so GPLv3+ should be OK too, right?
But if GPLv3+ should really be a problem, I'm OK with downgrading the license
(I guess I'll have to ask others who contributed).
The ${qjson_LIBRARIES} hack should not be needed anymore anyway, as the
naming scheme was restored months ago in git master (no version was
released with the names messed up).
Thanks, I'll remove it.
[1] http://techbase.kde.org/Policies/Licensing_Policy
--
Dan Vratil
www.progdan.cz | d...@progdan.cz | Jabber: prog...@jabber.cz
Fingerprint: 76C9 2F08 5D0D 6F9E 5AD4 2BFD 3A85 0307 F506 5B61
signature.asc
Description: This is a digitally signed message part.
Re: Review request: moving libkgoogle to extragear
El Dissabte, 26 de maig de 2012, a les 17:23:13, Dan Vratil va escriure:
On Saturday 26 of May 2012 11:42:41 Raphael Kubo da Costa wrote:
Dan Vratil d...@progdan.cz writes:
Hi,
LibKGoogle is a new optional dependency of kdepim-runtime. It's used by
the
new Akonadi Google resources.
It's now in kdereview [0] and I'd like to move it to extragear, so I'm
asking for a review on the library.
One thing I have noticed is that libkgoogle seems to be GPLv3+, while
KDE's licensing policy [1] says code under the GPL should be GPLv2+.
As far as I understand the policies, libkgoogle is a subject to point 5,
which says
Any other source files must be licensed under one of the terms listed under
4) or one of the following terms
* GPL version 2 as listed in kdelibs/COPYING or later
* GPL version 2 or version 3 or later versions approved by the membership
of KDE e.V.
* ...
I understand the second item as either GPLv2 or GPLv3 or any later approved
version, so GPLv3+ should be OK too, right?
No, you missed the part that says Note each bulletpoint above is a single
option, it can not be licenced under just part of one bulletpoint option
Albert
But if GPLv3+ should really be a problem, I'm OK with downgrading the
license (I guess I'll have to ask others who contributed).
The ${qjson_LIBRARIES} hack should not be needed anymore anyway, as the
naming scheme was restored months ago in git master (no version was
released with the names messed up).
Thanks, I'll remove it.
[1] http://techbase.kde.org/Policies/Licensing_Policy
Re: Review Request: kjs: Implement JSON.stringify
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105057/ --- (Updated May 27, 2012, 3:25 p.m.) Review request for kdelibs. Changes --- - fixed double newline - fixed functions could not be replaced, through replace function now it passes all ecma JSON.stringify tests this means removing all 15.12.3* test from broken file (not yet included in diff) Description --- kjs: Implement JSON.stringify patch needs https://git.reviewboard.kde.org/r/105056/ (JSON.parse) Diffs (updated) - kjs/CMakeLists.txt 1188064 kjs/CommonIdentifiers.h 8ee40e8 kjs/json_object.h PRE-CREATION kjs/json_object.cpp PRE-CREATION kjs/jsonstringify.h PRE-CREATION kjs/jsonstringify.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105057/diff/ Testing --- Thanks, Bernd Buschinski
Re: Review Request: kjs: Implement JSON.parse
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/ --- (Updated May 27, 2012, 3:30 p.m.) Review request for kdelibs. Changes --- - fixed stupid typo, that caused 123.456 to cause an syntax error - use putDirect instead of put to store properties, we need to by-pass __proto__ now passes all ecma JSON-parse tests this means removing all 15.12.0 - 15.12.2 tests from broken file (not yet included in diff) Description --- kjs: Implement JSON.parse Diffs (updated) - kjs/CMakeLists.txt 1188064 kjs/interpreter.cpp cf1acf1 kjs/json_object.h PRE-CREATION kjs/json_object.cpp PRE-CREATION kjs/jsonlexer.h PRE-CREATION kjs/jsonlexer.cpp PRE-CREATION kjs/libkjs.map e9f679f Diff: http://git.reviewboard.kde.org/r/105056/diff/ Testing --- Thanks, Bernd Buschinski
Re: Review Request: Remove additional directories from shortcuts scheme export path
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104981/#review14214 --- apaku's commit log says: Patch by Alexander Dymo, comitting on his behalf as he doesn't have time to do so right now. But both never touched this file since the initial commit - Burkhard Lück On May 24, 2012, 10:01 p.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104981/ --- (Updated May 24, 2012, 10:01 p.m.) Review request for kdelibs and Andreas Pakulat. Description --- The Configure Shortcuts dialog has an Action to export a scheme (Details-More Actions-Export Scheme) Using this action the user is asked for a export location and has to select a directory. Then the current scheme 'schemename' in application 'appname' is exported to a file named appnameschemenameshortcuts.rc. But this file is not saved in the selected directory as Joe User would expect, but in shortcuts/share/apps/appname/ below the selected folder. This patch removes the additional directories shortcuts/share/apps/appname/ from the export path to make it easier for the user to find the scheme file and move/copy it via command line (there is no GUI to import a scheme). Diffs - kdeui/dialogs/kshortcutschemeseditor.cpp 34a485a Diff: http://git.reviewboard.kde.org/r/104981/diff/ Testing --- Thanks, Burkhard Lück
Re: Review Request: Remove additional directories from shortcuts scheme export path
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104981/ --- (Updated May 27, 2012, 7:17 p.m.) Review request for kdelibs, Andreas Pakulat and Alexander Dymo. Changes --- added Alexander Dymo Description --- The Configure Shortcuts dialog has an Action to export a scheme (Details-More Actions-Export Scheme) Using this action the user is asked for a export location and has to select a directory. Then the current scheme 'schemename' in application 'appname' is exported to a file named appnameschemenameshortcuts.rc. But this file is not saved in the selected directory as Joe User would expect, but in shortcuts/share/apps/appname/ below the selected folder. This patch removes the additional directories shortcuts/share/apps/appname/ from the export path to make it easier for the user to find the scheme file and move/copy it via command line (there is no GUI to import a scheme). Diffs - kdeui/dialogs/kshortcutschemeseditor.cpp 34a485a Diff: http://git.reviewboard.kde.org/r/104981/diff/ Testing --- Thanks, Burkhard Lück
Re: Review Request: Remove additional directories from shortcuts scheme export path
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104981/ --- (Updated May 27, 2012, 7:17 p.m.) Review request for kdelibs, Andreas Pakulat and Alexander Dymo. Description --- The Configure Shortcuts dialog has an Action to export a scheme (Details-More Actions-Export Scheme) Using this action the user is asked for a export location and has to select a directory. Then the current scheme 'schemename' in application 'appname' is exported to a file named appnameschemenameshortcuts.rc. But this file is not saved in the selected directory as Joe User would expect, but in shortcuts/share/apps/appname/ below the selected folder. This patch removes the additional directories shortcuts/share/apps/appname/ from the export path to make it easier for the user to find the scheme file and move/copy it via command line (there is no GUI to import a scheme). Diffs - kdeui/dialogs/kshortcutschemeseditor.cpp 34a485a Diff: http://git.reviewboard.kde.org/r/104981/diff/ Testing --- Thanks, Burkhard Lück
