Re: Review Request: Apper on kdereview

2012-06-05 Thread Daniel Nicoletti
Hi, it's been 15 days since I've asked for the review, and we have fixed all the issues so far, should I ask kdesysadmin for the move now? Thanks, Daniel.

kdelibs and Qt version dependency

2012-06-05 Thread Albert Astals Cid
On May 19, Dawit Alemayehu commited a change that uses QSslConfiguration::testSslOption that is only available in Qt 4.8 This means that both kdelibs 4.8.4 and kdelibs 4.9 now depend in Qt 4.8 instead Qt 4.7 I want to ask the kdelibs maintainers: a) Do you think it makes sense to change our

Re: kdelibs and Qt version dependency

2012-06-05 Thread Dawit A
It is a simple matter to put a #ifdef around the code that does not compile with Qt 4.7. I wish this issue was raised when the code was up for review for more than a month or the Qt documentation mentioned something about those functions only being available in Qt 4.8. Anyhow, I have attached a