Re: kdelibs and Qt version dependency

2012-06-06 Thread Anne-Marie Mahfouf
On 06/06/2012 03:19 AM, Dawit A wrote: It is a simple matter to put a #ifdef around the code that does not compile with Qt 4.7. I wish this issue was raised when the code was up for review for more than a month or the Qt documentation mentioned something about those functions only being

Re: kdelibs and Qt version dependency

2012-06-06 Thread John Layt
On 6 June 2012 02:19, Dawit A ada...@kde.org wrote: It is a simple matter to put a #ifdef around the code that does not compile with Qt 4.7. I wish this issue was raised when the code was up for review for more than a month or the Qt documentation mentioned something about those functions only

Re: kdelibs splitting: May results, plans for June

2012-06-06 Thread Alexander Neundorf
On Monday, June 04, 2012 10:07:45 PM Kevin Ottens wrote: Hello, So May was beautiful, so much that I almost forgot to send now my traditional what happens in the kdelibs splitting email. That's what you get for spacing out in the garden I guess... :-) # May results So you're probably

Re: kdelibs splitting: May results, plans for June

2012-06-06 Thread Kevin Ottens
On Tuesday 05 June 2012 00:15:19 Alexander Neundorf wrote: On Monday, June 04, 2012 10:07:45 PM Kevin Ottens wrote: Hello, So May was beautiful, so much that I almost forgot to send now my traditional what happens in the kdelibs splitting email. That's what you get for spacing out in

Re: kdelibs and Qt version dependency

2012-06-06 Thread Laszlo Papp
To re-iterate, it is policy that any dependency changes are discussed and approved on k-c-d first. It was discussed and disapproved as far as I understood. Best Regards, Laszlo Papp

Re: kdelibs and Qt version dependency

2012-06-06 Thread Dirk Mueller
On Tuesday 05 June 2012, Albert Astals Cid wrote: On May 19, Dawit Alemayehu commited a change that uses QSslConfiguration::testSslOption that is only available in Qt 4.8 This means that both kdelibs 4.8.4 and kdelibs 4.9 now depend in Qt 4.8 instead Qt 4.7 Hi Albert, thanks for

Re: kdelibs and Qt version dependency

2012-06-06 Thread Stephen Kelly
Dirk Mueller wrote: On Tuesday 05 June 2012, Albert Astals Cid wrote: On May 19, Dawit Alemayehu commited a change that uses QSslConfiguration::testSslOption that is only available in Qt 4.8 This means that both kdelibs 4.8.4 and kdelibs 4.9 now depend in Qt 4.8 instead Qt 4.7 Hi

Re: kdelibs splitting: May results, plans for June

2012-06-06 Thread Alexander Neundorf
On Wednesday, June 06, 2012 10:07:41 AM Kevin Ottens wrote: ... We completed the following three new frameworks: * karchive I wouldn't call karchive complete. It is not splitted. E.g. it uses include dirs from the surrounding kdelibs: include_directories(

Re: kdelibs and Qt version dependency

2012-06-06 Thread Albert Astals Cid
El Dimecres, 6 de juny de 2012, a les 11:26:32, Laszlo Papp va escriure: To re-iterate, it is policy that any dependency changes are discussed and approved on k-c-d first. It was discussed and disapproved as far as I understood. Do you have a link for that discussion? Albert Best

Re: kdelibs splitting: May results, plans for June

2012-06-06 Thread Stephen Kelly
Alexander Neundorf wrote: Ah, right. Can you put a copy of FindLibLZMA.cmake into tier1/karchive/cmake/ ? (it will be in cmake 2.8.9) Then we don't need the CMAKE_MODULE_PATH from kdelibs anymore, and karchive is more standalone. Or we can bump the dependency to 2.8.9 when the RC 1 comes

Re: kdelibs splitting: May results, plans for June

2012-06-06 Thread Kevin Ottens
On Wednesday 06 June 2012 15:59:16 Alexander Neundorf wrote: Can you put a copy of FindLibLZMA.cmake into tier1/karchive/cmake/ ? Done. (it will be in cmake 2.8.9) That's why I didn't put it initially. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud patron of KDE,

Re: kdelibs and Qt version dependency

2012-06-06 Thread Dawit A
On Wed, Jun 6, 2012 at 2:32 PM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 6 de juny de 2012, a les 20:23:48, Laszlo Papp va escriure: Do you have a link for that discussion? http://lists.kde.org/?l=kde-core-develm=132630064116231w=2 That was in January though, people change

Re: kdelibs and Qt version dependency

2012-06-06 Thread Albert Astals Cid
El Dimecres, 6 de juny de 2012, a les 15:53:36, Dawit A va escriure: On Wed, Jun 6, 2012 at 2:32 PM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 6 de juny de 2012, a les 20:23:48, Laszlo Papp va escriure: Do you have a link for that discussion?

Re: Re: kdelibs and Qt version dependency

2012-06-06 Thread Martin Gräßlin
On Wednesday 06 June 2012 20:32:49 Albert Astals Cid wrote: But I'm expecting more people to have an opinion on this. David? Sebas? Someone from plasma? in the initial thread I was in favor of going for Qt 4.8, but I accepted the opinion of the majority. I would consider it as a bad incident if