Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-23 Thread Amandeep Singh
> On Aug. 23, 2012, 1:38 p.m., Frank Reininghaus wrote: > > Sorry for my late response, I was away for a couple of days. > > > > How can I test your patch? I think that only applying the Dolphin patch is > > not sufficient, so I'd like to know what else I need to download+build. I'd > > like t

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-23 Thread Amandeep Singh
> On Aug. 21, 2012, 9:44 a.m., Frederik Gladhorn wrote: > > dolphin/src/kitemviews/kitemlistviewaccessible.cpp, line 71 > > > > > > I think increasing by one is wrong here. > > eg 9 items in 3 rows and 3 columns

Re: Review Request: print-manager on kdereview

2012-08-23 Thread Burkhard Lück
Am Donnerstag, 23. August 2012 16:49:08 schrieb Daniel Nicoletti: > Sorry I always have problems with these things, > I've just copied the messages.sh from my other > project Apper, then Kai Uwe b did some changes > on it but maybe he missed something.. > Now print-manager has 4 translation catalo

Re: Review LibKdeAccessibilityClient

2012-08-23 Thread Kevin Ottens
Hello, On Thursday 16 August 2012 09:29:27 Frederik Gladhorn wrote: > Feedback is much appreciated. If you aim at releasing with KDE Frameworks, I would like to see the following happening: * Stick to the "new CMake ways" we use in KDE Frameworks (means depending on CMake 2.8.9 and ECM 0.0.5 for

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-23 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/#review17923 --- dolphin/src/kitemviews/kitemlistviewaccessible.cpp

Re: Review Request: Add urlChanged signal to ReadOnlyPart

2012-08-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106116/#review17910 --- This review has been submitted with commit a4eab98d0e56c99dce7

Re: Review Request: print-manager on kdereview

2012-08-23 Thread Daniel Nicoletti
Sorry I always have problems with these things, I've just copied the messages.sh from my other project Apper, then Kai Uwe b did some changes on it but maybe he missed something.. I'll take a look, but patches are really welcome :D 2012/8/23 Burkhard Lück : > Am Mittwoch, 22. August 2012 21:39:11

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-23 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/#review17902 --- Sorry for my late response, I was away for a couple of days. H

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-23 Thread Frank Reininghaus
> On Aug. 14, 2012, 3:44 p.m., Frank Reininghaus wrote: > > dolphin/src/kitemviews/kitemlistviewaccessible.h, line 143 > > > > > > This class isn't needed any more, is it? > > Amandeep Singh wrote: > This class

Re: [RFC] Merging LightDM into KDE Workspaces (forwarded from plasma-devel)

2012-08-23 Thread David Edmundson
On Thu, Aug 23, 2012 at 2:04 PM, Thomas Lübking wrote: > Am 22.08.2012, 14:58 Uhr, schrieb David Edmundson > : > > Sorry, this is certainly too much in details, but what is that > > >> Features LightDM-KDE has that KDM does not: >> - Guest support login > > > supposed to be? > > I mean, either th

Re: [RFC] Merging LightDM into KDE Workspaces (forwarded from plasma-devel)

2012-08-23 Thread Thomas Lübking
Am 22.08.2012, 14:58 Uhr, schrieb David Edmundson : Sorry, this is certainly too much in details, but what is that Features LightDM-KDE has that KDM does not: - Guest support login supposed to be? I mean, either there's a guest account on the machine or there's not. If you intend to sell

Re: Review Request: print-manager on kdereview

2012-08-23 Thread Ben Cooksley
On Thu, Aug 23, 2012 at 11:57 PM, Christoph Feck wrote: > On Wednesday 22 August 2012 21:39:11 Daniel Nicoletti wrote: >> Hi list, >> >> two years ago I started print-manager, at that time >> I was using Debian which is affected by this bug: >> https://bugs.kde.org/show_bug.cgi?id=271957 >> becaus

Re: Review Request: print-manager on kdereview

2012-08-23 Thread Christoph Feck
On Wednesday 22 August 2012 21:39:11 Daniel Nicoletti wrote: > Hi list, > > two years ago I started print-manager, at that time > I was using Debian which is affected by this bug: > https://bugs.kde.org/show_bug.cgi?id=271957 > because of this (and the fact I'm not a python fan > to fix the issue)

Re: Review Request: print-manager on kdereview

2012-08-23 Thread Burkhard Lück
Am Mittwoch, 22. August 2012 21:39:11 schrieb Daniel Nicoletti: > Right now translations are mostly undone which is > why I feel important to do the move as soon as possible > so KDE 4.10 has it well translated. Seems there is something wrong with the message extraction in print-manager, because

Re: [RFC] Merging LightDM into KDE Workspaces (forwarded from plasma-devel)

2012-08-23 Thread Harald Sitter
On Thu, Aug 23, 2012 at 12:27 PM, David Edmundson wrote: > On Wed, Aug 22, 2012 at 11:53 PM, Matthias Klumpp > wrote: >> 2012/8/22 Albert Astals Cid : >>> El Dimecres, 22 d'agost de 2012, a les 13:58:57, David Edmundson va >>> escriure: As you're all probably aware I've been working on a n

Re: [RFC] Merging LightDM into KDE Workspaces (forwarded from plasma-devel)

2012-08-23 Thread David Edmundson
On Wed, Aug 22, 2012 at 11:53 PM, Matthias Klumpp wrote: > 2012/8/22 Albert Astals Cid : >> El Dimecres, 22 d'agost de 2012, a les 13:58:57, David Edmundson va escriure: >>> As you're all probably aware I've been working on a new login manager >>> for KDE [1]. Currently known as LightDM-KDE, named

Re: [RFC] Merging LightDM into KDE Workspaces (forwarded from plasma-devel)

2012-08-23 Thread David Edmundson
On Thu, Aug 23, 2012 at 8:41 AM, Andras Mantia wrote: > On Wednesday, August 22, 2012 01:58:57 PM David Edmundson wrote: >> - a big refactor (see branch "big_refactor") > > Without going into other details: what would be the reason to merge LightDM > *now*, if you have a big refactoring undergoin

Re: Review Request: Add urlChanged signal to ReadOnlyPart

2012-08-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106116/#review17892 --- Ship it! Ah, yes, you're right. Reviewboard fooled me a little

Re: [RFC] Merging LightDM into KDE Workspaces (forwarded from plasma-devel)

2012-08-23 Thread Andras Mantia
On Wednesday, August 22, 2012 01:58:57 PM David Edmundson wrote: > - a big refactor (see branch "big_refactor") Without going into other details: what would be the reason to merge LightDM *now*, if you have a big refactoring undergoing? Andras