Re: Review Request: Implementation of KParts listing filter extension for Dolphin

2012-09-05 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106289/#review18542 --- Ship it! Thanks for your understanding and for the new patch,

Re: Review Request: Implementation of KParts listing filter extension for Dolphin

2012-09-05 Thread Dawit Alemayehu
On Sept. 5, 2012, 9:27 a.m., Frank Reininghaus wrote: Thanks for your understanding and for the new patch, looks good from my point of view! Maybe I'll check at some point if this can be optimised in master by sharing more code between setMimeTypeFilters() and setNameFilter(), but in

Re: Review Request: Implementation of KParts listing filter extension for Dolphin

2012-09-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106289/ --- (Updated Sept. 5, 2012, 1:28 p.m.) Review request for Dolphin and KDE

How Can I change wallpaper from CLI?

2012-09-05 Thread kevinzhow
hello~ Sorry to brother,I don not know which channel should i send this mail exactly , so i send this mail to kde, kde-devel and ode-core-devel, but i really need this help, please i am a developer of an application which can do browse online gallery and change the desktop wallpaper。You can

Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

2012-09-05 Thread Vadim Zhukov
04.09.2012 1:08 пользователь Michael Pyne mp...@kde.org написал: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106174/ I think I've figured out the issue with the missing files. The review request is indeed based against master, which isn't a big

Re: How Can I change wallpaper from CLI?

2012-09-05 Thread Shaun Reich
On Wed, Sep 5, 2012 at 10:53 AM, Tomaz Canabrava tcanabr...@kde.org wrote: 2012/9/5 Weng Xuetian wen...@gmail.com: On Wed, Sep 5, 2012 at 9:48 AM, kevinzhow kevincho...@gmail.com wrote: hello~ Sorry to brother,I don not know which channel should i send this mail exactly , so i send this

Re: Review Request: Implementation of KParts listing filter extension for Dolphin

2012-09-05 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106289/#review18552 --- Ship it! Thanks, looks good and is OK to commit (unless David

Re: Review Request: Implementation of KParts listing filter extension for Dolphin

2012-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106289/#review18555 --- This review has been submitted with commit

Re: Review Request: Implementation of KParts listing filter extension for Dolphin

2012-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106289/#review18556 --- This review has been submitted with commit

Review Request: Implementation of KPart listing notification extension for Dolphin

2012-09-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106333/ --- Review request for Dolphin and KDE Base Apps. Description --- The

Re: How Can I change wallpaper from CLI?

2012-09-05 Thread Alexander Neundorf
On Wednesday 05 September 2012, Shaun Reich wrote: On Wed, Sep 5, 2012 at 10:53 AM, Tomaz Canabrava tcanabr...@kde.org wrote: 2012/9/5 Weng Xuetian wen...@gmail.com: On Wed, Sep 5, 2012 at 9:48 AM, kevinzhow kevincho...@gmail.com wrote: hello~ Sorry to brother,I don not know which

Re: How Can I change wallpaper from CLI?

2012-09-05 Thread Jeremy Whiting
On Wed, Sep 5, 2012 at 11:30 AM, Alexander Neundorf neund...@kde.org wrote: On Wednesday 05 September 2012, Shaun Reich wrote: On Wed, Sep 5, 2012 at 10:53 AM, Tomaz Canabrava tcanabr...@kde.org wrote: 2012/9/5 Weng Xuetian wen...@gmail.com: On Wed, Sep 5, 2012 at 9:48 AM, kevinzhow

Re: How Can I change wallpaper from CLI?

2012-09-05 Thread Alexander Neundorf
On Wednesday 05 September 2012, Jeremy Whiting wrote: On Wed, Sep 5, 2012 at 11:30 AM, Alexander Neundorf neund...@kde.org wrote: On Wednesday 05 September 2012, Shaun Reich wrote: On Wed, Sep 5, 2012 at 10:53 AM, Tomaz Canabrava tcanabr...@kde.org wrote: 2012/9/5 Weng Xuetian

Re: How Can I change wallpaper from CLI?

2012-09-05 Thread Thomas Lübking
Am 05.09.2012, 20:10 Uhr, schrieb Alexander Neundorf neund...@kde.org: In KDE3 it was possible to set the wallpaper via dcop in kdesktop. So we can't do this anymore ? Good morning (scnr :-) Cheers, Thomas

Re: How Can I change wallpaper from CLI?

2012-09-05 Thread Christoph Feck
On Wednesday 05 September 2012 20:10:53 Alexander Neundorf wrote: In KDE3 it was possible to set the wallpaper via dcop in kdesktop. So we can't do this anymore ? It's still being worked on, see bug 217950 and linked review request.

Re: How Can I change wallpaper from CLI?

2012-09-05 Thread Nicolás Alvarez
2012/9/5, Alexander Neundorf neund...@kde.org: On Wednesday 05 September 2012, Jeremy Whiting wrote: On Wed, Sep 5, 2012 at 11:30 AM, Alexander Neundorf neund...@kde.org wrote: On Wednesday 05 September 2012, Shaun Reich wrote: On Wed, Sep 5, 2012 at 10:53 AM, Tomaz Canabrava

Re: Review Request: kjs: Implement JSON.stringify

2012-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105057/#review18562 --- This review has been submitted with commit

Re: Review Request: kjs: Mark Date Infinity as invalid

2012-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105387/#review18558 --- This review has been submitted with commit

Re: Review Request: kjs: Implement JSON.parse

2012-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review18561 --- This review has been submitted with commit

Re: Review Request: khtml: Fix memleak in DOMStringImpl::lower usage

2012-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105099/#review18559 --- This review has been submitted with commit

Re: How Can I change wallpaper from CLI?

2012-09-05 Thread Alexander Neundorf
On Wednesday 05 September 2012, Thomas Lübking wrote: Am 05.09.2012, 20:10 Uhr, schrieb Alexander Neundorf neund...@kde.org: In KDE3 it was possible to set the wallpaper via dcop in kdesktop. So we can't do this anymore ? Good morning (scnr :-) I actually didn't even switch away from the

Re: How Can I change wallpaper from CLI?

2012-09-05 Thread Nicolás Alvarez
2012/9/5, Nicolás Alvarez nicolas.alva...@gmail.com: 2012/9/5, Alexander Neundorf neund...@kde.org: On Wednesday 05 September 2012, Jeremy Whiting wrote: On Wed, Sep 5, 2012 at 11:30 AM, Alexander Neundorf neund...@kde.org wrote: On Wednesday 05 September 2012, Shaun Reich wrote: On Wed,

Re: Review Request: kjs: Use toPrimitive in Array.join to get the correct String

2012-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105391/#review18579 --- This review has been submitted with commit

Re: Review Request: kjs: FunctionObject prototype attribute should be [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: false

2012-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105122/#review18580 --- This review has been submitted with commit

Re: How Can I change wallpaper from CLI?

2012-09-05 Thread Aaron J. Seigo
On Wednesday, September 5, 2012 20:42:55 Gilles Caulier wrote: There a task assigned to a student this summer to open Plasma API for wallpaper purpose. I mentored him to patch Plasma and write relevant Kipi plugin for digiKam. honestly, it would make a lot more sense for applications that show

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/#review18602 --- This review has been submitted with commit

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/#review18603 --- This review has been submitted with commit