Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-09-26 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106527/#review19442 --- I pushed the plasmoidviewer changed in and filed a Qt review

Re: Use of bin versus libexec

2012-09-26 Thread Jonathan Marten
After a lot of discussion, is seems that there are some executables (as per Thiago's list) that can be moved out. For others (e.g. Akonadi) it is problematic because there is no standardization on the location for a system-wide libexec as per David's comments below, so they will have to stay

Re: Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

2012-09-26 Thread Dawit Alemayehu
On Sept. 25, 2012, 9:03 p.m., Frank Reininghaus wrote: Thanks for analysing this issue and for the patch! We should of course let those events propagate. However, I'm a bit confused. The docs of QObject::eventFilter() don't mention anything about setting the 'accepted' state of the

Re: Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

2012-09-26 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106569/ --- (Updated Sept. 26, 2012, 12:53 p.m.) Review request for Dolphin and KDE

Re: Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

2012-09-26 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106569/#review19457 --- Ship it! Thanks Dawit for the explanation! I had a quick look

Review request reminder: kded-appmenu

2012-09-26 Thread Cedric Bellegarde
Hello, i'm waiting for some code review on kded-appmenu module: https://projects.kde.org/projects/kdereview/kded-appmenu Martin Gräßlin tells me to send a reminder here before commiting. I need to put this in kde-workspace before patching with: https://git.reviewboard.kde.org/r/104344/ As i'm

Re: Review request reminder: kded-appmenu

2012-09-26 Thread Albert Astals Cid
El Dimecres, 26 de setembre de 2012, a les 14:58:55, Cedric Bellegarde va escriure: Hello, i'm waiting for some code review on kded-appmenu module: https://projects.kde.org/projects/kdereview/kded-appmenu You still have GPLv2 vs GPLv3 issues in the code. Oh wait the first guy that

Re: Review request reminder: kded-appmenu

2012-09-26 Thread Albert Astals Cid
El Dimecres, 26 de setembre de 2012, a les 15:53:47, Cedric Bellegarde va escriure: Le mercredi 26 septembre 2012 15:37:53 Albert Astals Cid a écrit : You still have GPLv2 vs GPLv3 issues in the code. Hello, from your last mail, GPLv3 is disallowed by:

Re: Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

2012-09-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106569/#review19462 --- This review has been submitted with commit

Re: Review request reminder: kded-appmenu

2012-09-26 Thread Albert Astals Cid
El Dimecres, 26 de setembre de 2012, a les 16:07:19, Cedric Bellegarde va escriure: Le mercredi 26 septembre 2012 16:04:30 vous avez écrit : Really, where does it say that? « Any other source files must be licensed under one of the terms listed under 4) or one of the following terms: GPL

Review Request: Make KFileDialog remember settings

2012-09-26 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106581/ --- Review request for kdelibs. Description --- This patch makes

Re: Use of bin versus libexec

2012-09-26 Thread Ralf Habacker
Am 20.09.2012 17:53, schrieb Thiago Macieira: On quinta-feira, 20 de setembro de 2012 16.50.57, Ralf Habacker wrote: kdeinit4 used on windows, need to stay Used by people? Or used by programs and scripts? used by people. On windows there are a few more options intended for command line

Re: Review request reminder: kded-appmenu

2012-09-26 Thread Cedric Bellegarde
Le mercredi 26 septembre 2012 15:37:53 Albert Astals Cid a écrit : You still have GPLv2 vs GPLv3 issues in the code. Hello, from your last mail, GPLv3 is disallowed by: http://techbase.kde.org/Policies/Licensing_Policy but i can read that for Source files that aren't part of a library with a

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106124/#review19466 --- ksmserver/screenlocker/lockwindow.cpp

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-26 Thread Marco Martin
On Sept. 26, 2012, 3:43 p.m., Kai Uwe Broulik wrote: ksmserver/screenlocker/lockwindow.cpp, line 152 http://git.reviewboard.kde.org/r/106124/diff/5/?file=86354#file86354line152 When the lock screen comes up I get a brief blickering. In LightDM and KSplashQML we use