Re: Review Request: Let kio_smb store passwords in KWallet again.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106909/#review20531 --- This review has been submitted with commit 177ce2a7b5b69c1f9ef

Re: Review Request: Let kio_smb store passwords in KWallet again.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106909/#review20530 --- This review has been submitted with commit 9c0021e98c0c6a808ff

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106636/ --- (Updated Oct. 17, 2012, 8:48 p.m.) Review request for kdelibs and David Fa

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

> On Oct. 16, 2012, 11:50 a.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 1491 > > > > > > This is slow iteration, since it has to modify the container every > > time. There's no reentrancy here, why use t

Re: Review Request: Activities support for Konqueror

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/ --- (Updated Oct. 17, 2012, 4:06 p.m.) Review request for KDE Base Apps and Da

Re: Review Request: Activities support for Konqueror

> On Oct. 17, 2012, 3:43 p.m., David Faure wrote: > > konqueror/src/konqview.h, line 48 > > > > > > You should switch to #cmakedefine01 in the config-apps.h file, and use > > #if here. > > > > This has the

Re: Review Request: Activities support for Konqueror

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/#review20502 --- konqueror/src/konqview.h

Re: Review Request: Activities support for Konqueror

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/ --- (Updated Oct. 17, 2012, 3:27 p.m.) Review request for KDE Base Apps and Da