Re: Review Request 108504: [High-dpi issues] Fix KIconDialog

2013-01-21 Thread Thomas Pfeiffer
On Jan. 20, 2013, 11:53 a.m., Thomas Pfeiffer wrote: File Attachment: Icon Dialog with 200dpi http://git.reviewboard.kde.org/r/108504/#fcomment5 Why is that icon smaller than the others? Is it because the bigger version of it does not exist? Kai Uwe Broulik wrote: Also

Re: Review Request 108504: [High-dpi issues] Fix KIconDialog

2013-01-21 Thread Kai Uwe Broulik
On Jan. 20, 2013, 2:40 p.m., Thomas Lübking wrote: kio/kfile/kicondialog.cpp, line 141 http://git.reviewboard.kde.org/r/108504/diff/2/?file=108215#file108215line141 Would it for such static sizes (why 60px in the first place?) not be more correct to use sh. like

Re: Review Request 108504: [High-dpi issues] Fix KIconDialog

2013-01-21 Thread Kai Uwe Broulik
On Jan. 20, 2013, 2:40 p.m., Thomas Lübking wrote: kio/kfile/kicondialog.cpp, line 141 http://git.reviewboard.kde.org/r/108504/diff/2/?file=108215#file108215line141 Would it for such static sizes (why 60px in the first place?) not be more correct to use sh. like

Color Management in KDE

2013-01-21 Thread John Layt
Hi, A couple of months ago I attended the Linux Color Management Hackfest mainly to find out how to color manage printing, but also to get a wider overview, and to figure out the colord versus Oyranos situation. I've been sitting on this email for a bit as it's probably going to be

Review Request 108539: kjs: Implement getOwnPropertyDescriptor for String and Function for a correct length descriptor

2013-01-21 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108539/ --- Review request for kdelibs. Description --- kjs: Implement

Review Request 108538: kjs: Remove leftover toString calls in exception messages

2013-01-21 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108538/ --- Review request for kdelibs. Description --- kjs: Remove leftover

Re: Review Request 106671: kjs/khtml: Reuse existing html5 Audio Element instead of duplicating it

2013-01-21 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106671/ --- (Updated Jan. 22, 2013, 3:11 a.m.) Review request for kdelibs. Changes

Re: Review Request 104243: KJS/Grammar: Introduce new non-terminal IdentifierName, to handle keywords as PropertyName, in Memberexps and CallExpr

2013-01-21 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104243/ --- (Updated Jan. 22, 2013, 3:11 a.m.) Review request for kdelibs. Changes

Re: Review Request 105631: kjs: Implement Date.toJSON

2013-01-21 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105631/ --- (Updated Jan. 22, 2013, 3:11 a.m.) Review request for kdelibs. Changes

Re: Review Request 105430: kjs: Implement html5 HTMLSelectCollectionProtoFunc::remove

2013-01-21 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105430/ --- (Updated Jan. 22, 2013, 3:11 a.m.) Review request for kdelibs. Changes

Re: Review Request 105386: kjs: Implement Date.toISOString

2013-01-21 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105386/ --- (Updated Jan. 22, 2013, 3:11 a.m.) Review request for kdelibs. Changes

Re: Review Request 104630: kjs: Implement Object.create

2013-01-21 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104630/ --- (Updated Jan. 22, 2013, 3:11 a.m.) Review request for kdelibs. Changes

Re: Review Request 104798: kjs: Fix shift/reduce issues in grammar.y + cleanup

2013-01-21 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104798/ --- (Updated Jan. 22, 2013, 3:11 a.m.) Review request for kdelibs. Changes

Re: Review Request 104515: KJS: Implement Object.GetOwnPropertyDescriptor Object.DefineProperty

2013-01-21 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/ --- (Updated Jan. 22, 2013, 3:11 a.m.) Review request for kdelibs. Changes

Re: Review Request 104747: kjs: Implement Object.seal Object.isSealed

2013-01-21 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104747/ --- (Updated Jan. 22, 2013, 3:11 a.m.) Review request for kdelibs. Changes

Re: Review Request 104748: kjs: Implement Object.freeze Object.isFrozen

2013-01-21 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104748/ --- (Updated Jan. 22, 2013, 3:11 a.m.) Review request for kdelibs. Changes

Re: Review Request 104629: kjs: Implement Object.defineProperties

2013-01-21 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104629/ --- (Updated Jan. 22, 2013, 3:11 a.m.) Review request for kdelibs. Changes

Re: Review Request 104749: kjs: Implement Extensible check 8.12.9 Step 3 in DefineOwnProperty

2013-01-21 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104749/ --- (Updated Jan. 22, 2013, 3:12 a.m.) Review request for kdelibs. Changes

Re: Review Request 104746: kjs: Implement Object.isExtensible and Object.preventExtensible

2013-01-21 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104746/ --- (Updated Jan. 22, 2013, 3:12 a.m.) Review request for kdelibs. Changes

Re: Review Request 104629: kjs: Implement Object.defineProperties

2013-01-21 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104629/ --- (Updated Jan. 22, 2013, 3:47 a.m.) Review request for kdelibs. Changes

Re: Color Management in KDE

2013-01-21 Thread Martin Gräßlin
On Monday 21 January 2013 21:22:42 John Layt wrote: Thoughts? thanks John for the long and well elaborated mail. It helped me understanding the porblem better. From what you describe the supposed plugin based approach looks sane to me. Having a D-Bus interface and a runtime dependency is the