Re: Color Management in KDE
On Monday 21 January 2013 21:22:42 John Layt wrote: My big concern is that KDE is sleep-walking into a hodge-podge solution with little co-ordination on implementations and dependencies, and little knowledge of the implications of the decisions being made. I've tried to come up with a logical pragmatic solution within the usual KDE standards and architecture, but I am not a CM expert so if you feel that I've got anything wrong or misunderstood the situation please don't hesitate to call me on it. Hello John Thank you very much for a very clear exposition of the concepts and of the situation. A few questions, just to complete my understanding: - is it possible that, from an integrated KDE p.o.v., having the support provided in kwin and in the (to be fully revived) printing infrastructure, would free apps from the need to directly address this issue? I guess I understand that a very color-conscient application (like, say, krita), will need to correctly support CM internally, particularly if the app is used outside an integrated KDE session. But then, is there conflict when both the application and the wm try to manage color? - you mention a few hypothetical developments (especially in relation with Qt5). Do you have direct information on the plans? Or, in other words, what is the perceived probability that your future-projections could be defeated by predictible developer-opinion/development-direction changes? Thanks a lot. -- Cristian Tibirna KDE developer .. tibi...@kde.org .. http://www.kde.org
Re: Review Request 108504: [High-dpi issues] Fix KIconDialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108504/#review25914 --- kio/kfile/kicondialog.cpp http://git.reviewboard.kde.org/r/108504/#comment19799 I should've googl'd a bit more thorougly. Using q-setInitialSize works here :) - Kai Uwe Broulik On Jan. 20, 2013, 11:15 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108504/ --- (Updated Jan. 20, 2013, 11:15 a.m.) Review request for kdelibs and KDE Usability. Description --- This makes the KIconDialog (the dialog where you can choose icons for eg. folders) respect the global icon size. Almost all sizes were hardcoded but the patch does away with all of this and works fine with all icon sizes and big font sizes. Also made it aware of FontMetrics (atm with bigger fonts, they also get clipped) and adjusts the grid height accordingly. Was fun diving into that ancient code :) Diffs - kio/kfile/kicondialog.cpp b7d646f Diff: http://git.reviewboard.kde.org/r/108504/diff/ Testing --- Yup, see screenshot. The only issue that remains is the initial size of the dialog to make it show 4 rows of icons. In the current implementation it just adds another 100px to the dialog height (cf. line 490), which is easy, if all the sizes are known and fixed, but with variing sizes this becomes an issue and I could not think of a proper solution. I probably need to add a sizeHint (tried in the private class, didn't help there)? The easiest but not neccessarily best solution would be to just set the minimumHeight to 4 rows and done. File Attachments Icon Dialog with 200dpi http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/icondialog.png Icon Dialog with 200dpi (without patch) http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/icondialog2.png Thanks, Kai Uwe Broulik
Re: Review Request 108237: [Bug 286768] Duplicate entries in KWallet default wallet comboBox
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108237/ --- (Updated Jan. 21, 2013, 10:35 p.m.) Review request for kdelibs. Changes --- Looks like only one group can be assigned. Changed groups from kdeutils to kdelibs. Description --- Fix for Bug 286768 This patch fixes duplicate entries in Default wallet combobox. Local Wallet combobox could be also wrong as it used currentIndex of Default Wallet combobox Diffs - konfigurator/konfigurator.cpp 3cc1b3f08feb0feb1aa70028508ce5041fefd9f3 Diff: http://git.reviewboard.kde.org/r/108237/diff/ Testing --- Tested on Archlinux and KDE 4.9.5 Thanks, Maciej Sitarz
Re: KDEREVIEW: Mangonel
Distinguished Sirs and Madams, On Tue, Jan 08, 2013 at 09:08:11PM +0100, Martin Sandsmark wrote: Mangonel has just been moved to KDE Review. The KDE Review process is set to be two weeks, and if Mangonel calculator isn't completely wrong, that period is now up. Since all the issues raised are fixed, I assume I can now move forward with moving it to extragear/base? Thanks to everyone who have reviewed, and contributed comments and fixes. -- Martin Sandsmark
Push access to kdepim and kdepimlibs suspended
Hi all, Just a quick notice that due to a accidental merge from KDE/4.10 into master in both the kdepim and kdepimlibs repositories, both have been locked. A force push has already been performed to reverse the changes, however it has been left locked to ensure that the changes are not reintroduced accidentally (changes are also needed on various infrastructure systems, which in themselves are not capable of handling a force push). Unfortunately, due to the manner in which the change occurred, it is difficult to block it reoccurring at this time. Regards, Ben Cooksley KDE Sysadmin
Re: Push access to kdepim and kdepimlibs suspended
On Wed, Jan 23, 2013 at 7:33 PM, Ben Cooksley bcooks...@kde.org wrote: Hi all, Just a quick notice that due to a accidental merge from KDE/4.10 into master in both the kdepim and kdepimlibs repositories, both have been locked. A force push has already been performed to reverse the changes, however it has been left locked to ensure that the changes are not reintroduced accidentally (changes are also needed on various infrastructure systems, which in themselves are not capable of handling a force push). Unfortunately, due to the manner in which the change occurred, it is difficult to block it reoccurring at this time. Just a quick follow up, the following four commands should help those who need to fix their checkouts. You will need to fix your checkout if you pulled at any time from 17:00 UTC yesterday until now. Steps 1 and 4 may be skipped if you are not currently on KDE/4.10. - If you have the KDE/4.10 branch checked out now, change to another: git checkout master - Remove the tainted KDE/4.10 branch you have locally: git branch -D KDE/4.10 - Fetch all changes from the server: git remote update - Return to KDE/4.10: git checkout KDE/4.10 Regards, Ben
Re: [Kde-pim] Push access to kdepim and kdepimlibs suspended
On Wednesday 23 January 2013 19:33:30 Ben Cooksley wrote: Just a quick notice that due to a accidental merge from KDE/4.10 into master in both the kdepim and kdepimlibs repositories, both have been locked. A force push has already been performed to reverse the changes, however it has been left locked to ensure that the changes are not reintroduced accidentally (changes are also needed on various infrastructure systems, which in themselves are not capable of handling a force push). Unfortunately, due to the manner in which the change occurred, it is difficult to block it reoccurring at this time. That was me, it seems, please accept my apologies. I was under the imression that commit to 4.10, merge 4.10 into master is the recommended work flow. If I understand correctly the problem was that I committed to a 4.10 that had just been merged so the parent was a merge commit? Several people endorsed my git skill on LinkedIn, so I feel I need to understand what went wrong here ;). Thanks to those who fixed the repos late at night, and sorry again. Till
