Re: Review Request 108570: This patch add support for bulk operations in systemtray applet settings.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108570/ --- (Updated Jan. 30, 2013, 10:48 a.m.) Review request for kde-workspace. Changes --- Alternative layout for bulk operations with no use of a QTableWidget for bulk operations and removal of bulk shortcut clean button. Description --- In page 'entries', user can select/deselect a specific or all entries and then change visibility and/or reset shortcut for all of them with a single combo selection/clear button click. Individually selecting all entries causes header's checkbox to automatically be checked. After selecting all entries (individually or by clicking in header's checkbox), a single entry deselection causes header's checkbox to automatically be unchecked. General suggestions and, in particular about UI usability, are appreciated. Diffs (updated) - plasma/generic/applets/systemtray/ui/applet.h 0b4a869 plasma/generic/applets/systemtray/ui/applet.cpp 09482d7 plasma/generic/applets/systemtray/ui/autohide.ui 3b6efff Diff: http://git.reviewboard.kde.org/r/108570/diff/ Testing --- File Attachments Initial setup http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions1.png Setting all visibilities to 'Auto' http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions2.png All visibilities adjusted to 'Auto' http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions3.png Setting two specific item visibilities to 'Always Visible' http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions4.png Thanks, Sandro Andrade
Re: Review Request 108570: This patch add support for bulk operations in systemtray applet settings.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108570/ --- (Updated Jan. 30, 2013, 10:50 a.m.) Review request for kde-workspace. Changes --- Adding screenshots for alternative bulk layout Description --- In page 'entries', user can select/deselect a specific or all entries and then change visibility and/or reset shortcut for all of them with a single combo selection/clear button click. Individually selecting all entries causes header's checkbox to automatically be checked. After selecting all entries (individually or by clicking in header's checkbox), a single entry deselection causes header's checkbox to automatically be unchecked. General suggestions and, in particular about UI usability, are appreciated. Diffs - plasma/generic/applets/systemtray/ui/applet.h 0b4a869 plasma/generic/applets/systemtray/ui/applet.cpp 09482d7 plasma/generic/applets/systemtray/ui/autohide.ui 3b6efff Diff: http://git.reviewboard.kde.org/r/108570/diff/ Testing --- File Attachments (updated) Initial setup http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions1.png Setting all visibilities to 'Auto' http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions2.png All visibilities adjusted to 'Auto' http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions3.png Setting two specific item visibilities to 'Always Visible' http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions4.png Bulk operations (2nd layout) - 1 http://git.reviewboard.kde.org/media/uploaded/files/2013/01/30/systray-bulk-tableless1.png Bulk operations (2nd layout) - 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/01/30/systray-bulk-tableless2.png Thanks, Sandro Andrade
Review Request 108675: kjs: Implement Function.prototype.bind
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108675/ --- Review request for kdelibs. Description --- kjs: Implement Function.prototype.bind following ECMAScript Edition 5.1r6 15.3.4.5 The only tiny difference is that the thisArg can not be null or undefined. As we call use null or undefined as thisObject in call. So, like in Function.prototype.call, I use the global object instead. NOTE: this patch also depends on Object.defineOwnProperty Diffs - kjs/function.h 5dbbfb2 kjs/function.cpp 6263b36 kjs/function_object.h ebcb937 kjs/function_object.cpp 76f55cb Diff: http://git.reviewboard.kde.org/r/108675/diff/ Testing --- passes all Function.prototype.bind ecmascript testcases and does not introduce regressions. Thanks, Bernd Buschinski
Re: KDEREVIEW: share like connect and plasmate
On Wed, Jan 30, 2013 at 11:23 PM, Giorgos Tsiapaliokas terie...@gmail.com wrote: Hello, Hi Giorgos, as it has been mentioned plasmate is ready to go into the extragear. Can you move it to the extragear? Where precisely in Extragear is Plasmate and Share-Like-Connect headed? They are both overdue to be moved from KDE Review. Note: Moves into and out of KDE Review must *always* be CC'ed to kde-core-devel. On that note: any last objections? Regards, Giorgos Regards, Ben Cooksley KDE Sysadmin -- Giorgos Tsiapaliokas (terietor) KDE Developer terietor.gr ___ Plasma-devel mailing list plasma-de...@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KDEREVIEW: share like connect and plasmate
On Thursday, January 31, 2013 10:43:29 Ben Cooksley wrote: as it has been mentioned plasmate is ready to go into the extragear. Can you move it to the extragear? Where precisely in Extragear is Plasmate SDK and Share-Like-Connect headed? Base thanks :) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part.
