Re: Review Request 109531: Port the Sonnet ASpell plugin to the new style APIs

2013-03-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109531/#review29362 --- Looks ok to me. Just two questions.

Re: Review Request 109531: Port the Sonnet ASpell plugin to the new style APIs

2013-03-17 Thread Martin Tobias Holmedahl Sandsmark
On March 17, 2013, 11:51 a.m., David Faure wrote: staging/sonnet/src/plugins/aspell/kspell_aspellclient.cpp, line 82 http://git.reviewboard.kde.org/r/109531/diff/1/?file=120141#file120141line82 Doesn't the .json file need to exist? Alternatively I think the FILE argument can

Re: Review Request 109531: Port the Sonnet ASpell plugin to the new style APIs

2013-03-17 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109531/ --- (Updated March 17, 2013, noon) Status -- This change has been marked

Re: Review Request 109531: Port the Sonnet ASpell plugin to the new style APIs

2013-03-17 Thread David Faure
On March 17, 2013, 11:51 a.m., David Faure wrote: staging/sonnet/src/core/client_p.h, line 78 http://git.reviewboard.kde.org/r/109531/diff/1/?file=120139#file120139line78 Is this used anywhere? Funnily enough, the qobject_castClient * in loadPlugin already compiles. Ah I

Review Request 109538: port KFileMetaDataReader to QProcess

2013-03-17 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109538/ --- Review request for KDE Frameworks, kdelibs, David Faure, and Vishesh Handa.

Re: Review Request 109538: port KFileMetaDataReader to QProcess

2013-03-17 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109538/#review29377 --- But why? KFileMetadataReader and the other KFileMetadataStuff

Re: Review Request 109538: port KFileMetaDataReader to QProcess

2013-03-17 Thread Martin Tobias Holmedahl Sandsmark
On March 17, 2013, 2:05 p.m., Vishesh Handa wrote: But why? KFileMetadataReader and the other KFileMetadataStuff should just be marked as deprecated. Why are we porting them? We already have better alternatives in the nepomuk-widgets repository. Because it was a simple user of

Re: Review Request 109538: port KFileMetaDataReader to QProcess

2013-03-17 Thread Vishesh Handa
On March 17, 2013, 2:05 p.m., Vishesh Handa wrote: But why? KFileMetadataReader and the other KFileMetadataStuff should just be marked as deprecated. Why are we porting them? We already have better alternatives in the nepomuk-widgets repository. Martin Tobias Holmedahl Sandsmark

Review Request 109549: port KRun away from KProcess

2013-03-17 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/ --- Review request for KDE Frameworks, kdelibs and David Faure. Description

Re: Review Request 109549: port KRun away from KProcess

2013-03-17 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109549/#review29391 --- kio/kio/krun.cpp

Review Request 109551: port KPtyProcess to QProcess

2013-03-17 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/ --- Review request for KDE Frameworks, kdelibs and David Faure. Description

Re: Review Request 109549: port KRun away from KProcess

2013-03-17 Thread Martin Tobias Holmedahl Sandsmark
On March 17, 2013, 4:41 p.m., Rolf Eike Beer wrote: kio/kio/krun.cpp, line 1780 http://git.reviewboard.kde.org/r/109549/diff/1/?file=120223#file120223line1780 Whitespacing around braces is inconsistent. it's consistent with the rest of the code around it? On March 17, 2013, 4:41

Re: Review Request 109492: Allow Rich Text in QML notifications plasmoid

2013-03-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109492/ --- (Updated March 17, 2013, 10:22 p.m.) Review request for kde-workspace,

Review Request 109555: kjs: Avoid overflow computing availableStackSize in KJS::RegExp::match

2013-03-17 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109555/ --- Review request for kdelibs. Description --- the Patch differs from

Review Request 109561: Disable SSL compression support in TCPSlaveBase

2013-03-17 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109561/ --- Review request for kdelibs. Description --- This patch disables SSL