Re: Review Request 109675: Make sure that the KDE prefix comes first in XDG_DATA_DIRS
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109675/#review29831 --- Ship it! Ship It! - David Faure On March 24, 2013, 4:31 p.m., Andreas Hartmetz wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109675/ --- (Updated March 24, 2013, 4:31 p.m.) Review request for kdelibs and Vishesh Handa. Description --- Planned commit message: Make sure that the KDE prefix comes first in XDG_DATA_DIRS. I tracked down a Nepomuk problem to this. Nepomuk file indexing didn't work because the ontologies were too old. Nepomuk loaded ontologies from /usr/share instead of my KDE prefix /opt/kde4/share, because /opt/kde4 was the very last entry in the respective search list in KStandardDirs. The first entries in that search list all came from XDG_DATA_DIRS, which in my case (Kubuntu) is set by the X session initialization scripts. That is before startkde runs, so startkde never touched XDG_DATA_DIRS. But it should, and now it does. Diffs - startkde.cmake 8361fe0 Diff: http://git.reviewboard.kde.org/r/109675/diff/ Testing --- Thanks, Andreas Hartmetz
Re: Review Request 109675: Make sure that the KDE prefix comes first in XDG_DATA_DIRS
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109675/#review29850 --- Seems like a good idea to me. I cannot have a Ship it as I'm not familiar with the code. Btw, I just checked and I have a `prepend XDG_DATA_DIRS $KDEDIR/share` in my KDE environment variables, that is probably why I never encountered this. - Vishesh Handa On March 24, 2013, 4:31 p.m., Andreas Hartmetz wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109675/ --- (Updated March 24, 2013, 4:31 p.m.) Review request for kdelibs and Vishesh Handa. Description --- Planned commit message: Make sure that the KDE prefix comes first in XDG_DATA_DIRS. I tracked down a Nepomuk problem to this. Nepomuk file indexing didn't work because the ontologies were too old. Nepomuk loaded ontologies from /usr/share instead of my KDE prefix /opt/kde4/share, because /opt/kde4 was the very last entry in the respective search list in KStandardDirs. The first entries in that search list all came from XDG_DATA_DIRS, which in my case (Kubuntu) is set by the X session initialization scripts. That is before startkde runs, so startkde never touched XDG_DATA_DIRS. But it should, and now it does. Diffs - startkde.cmake 8361fe0 Diff: http://git.reviewboard.kde.org/r/109675/diff/ Testing --- Thanks, Andreas Hartmetz
Re: KDEReview: Nepomuk-Controller QML
On Sat, Mar 23, 2013 at 8:12 PM, Jörg Ehrichs joerg.ehri...@gmx.de wrote: So after a first introduction in plasma, I like to get this thing into SC. The Nepomuk-Controller aims to replace the current system tray Nepomuk applet. This one allows to suspend/resume and show information for all the indexers, thus this gives any user a small hint what happens in the background and allow them to suspend it, if they need to. For the review I have pushed the branch nepomukcontroller-qml into kde-workspace. You can find the important parts at plasma/generic/dataengines/nepomuk plasma/generic/applet/nepomuk-controller The dataengine as well as the applet is only installed if Nepomuk-Core/Soprano is found as build dependency. This would deprecate: kde-runtime/nepomuk/controller/ Deprecate or remove? Cause I would like to remove it. and need current nepomuk-core master For an easy to install version there is also: http://quickgit.kde.org/?p=scratch/jehrichs/nepomukcontroller-qml.git Some Pictures: http://wstaw.org/m/2013/03/20/nepomukcontroller-qml1.jpg http://wstaw.org/m/2013/03/20/nepomukcontroller-qml2.jpg http://wstaw.org/m/2013/03/20/nepomukcontroller-qml3.jpg http://wstaw.org/m/2013/03/20/nepomukcontroller-qml4.jpg Any help/comments are welcome. Since my first mail on the plasma devel list, the dbus calls are asynchrone now, the FileWatch service is not shown on default, but can be enabled if the user wants, and the licence should be fine now. Kind Regards Joerg -- Vishesh Handa
Re: Review Request 106426: KDNSSD: compile without implicit cast from char* to QString
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106426/ --- (Updated March 25, 2013, 3:25 p.m.) Status -- This change has been discarded. Review request for kdelibs. Description --- Patch that allows to compile with -DQT_NO_CAST_TO_ASCII -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY. Diffs - dnssd/avahi-domainbrowser.cpp 8343594 dnssd/avahi-publicservice.cpp 1e01242 dnssd/avahi-remoteservice.cpp be2962c dnssd/avahi-servicebrowser.cpp 38d1a07 dnssd/avahi-servicetypebrowser.cpp ada2561 dnssd/avahi_server_interface.cpp 094fde4 dnssd/mdnsd-domainbrowser.cpp 384014a dnssd/mdnsd-publicservice.cpp 14fdc47 dnssd/mdnsd-remoteservice.cpp 3ffd91c dnssd/mdnsd-responder.cpp 6adbf46 dnssd/mdnsd-servicebrowser.cpp 00caabc dnssd/mdnsd-servicetypebrowser.cpp a5bf621 dnssd/servicebase.cpp 9ddfdf5 Diff: http://git.reviewboard.kde.org/r/106426/diff/ Testing --- No one. Thanks, Matthieu Gallien
Re: Review Request 109675: Make sure that the KDE prefix comes first in XDG_DATA_DIRS
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109675/#review29879 --- This review has been submitted with commit db6423ec69cef1ebb8b7f46cb2732e2cb7cf259f by Andreas Hartmetz to branch KDE/4.10. - Commit Hook On March 24, 2013, 4:31 p.m., Andreas Hartmetz wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109675/ --- (Updated March 24, 2013, 4:31 p.m.) Review request for kdelibs and Vishesh Handa. Description --- Planned commit message: Make sure that the KDE prefix comes first in XDG_DATA_DIRS. I tracked down a Nepomuk problem to this. Nepomuk file indexing didn't work because the ontologies were too old. Nepomuk loaded ontologies from /usr/share instead of my KDE prefix /opt/kde4/share, because /opt/kde4 was the very last entry in the respective search list in KStandardDirs. The first entries in that search list all came from XDG_DATA_DIRS, which in my case (Kubuntu) is set by the X session initialization scripts. That is before startkde runs, so startkde never touched XDG_DATA_DIRS. But it should, and now it does. Diffs - startkde.cmake 8361fe0 Diff: http://git.reviewboard.kde.org/r/109675/diff/ Testing --- Thanks, Andreas Hartmetz
Re: Review Request 109675: Make sure that the KDE prefix comes first in XDG_DATA_DIRS
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109675/ --- (Updated March 25, 2013, 7:14 p.m.) Status -- This change has been marked as submitted. Review request for kdelibs and Vishesh Handa. Description --- Planned commit message: Make sure that the KDE prefix comes first in XDG_DATA_DIRS. I tracked down a Nepomuk problem to this. Nepomuk file indexing didn't work because the ontologies were too old. Nepomuk loaded ontologies from /usr/share instead of my KDE prefix /opt/kde4/share, because /opt/kde4 was the very last entry in the respective search list in KStandardDirs. The first entries in that search list all came from XDG_DATA_DIRS, which in my case (Kubuntu) is set by the X session initialization scripts. That is before startkde runs, so startkde never touched XDG_DATA_DIRS. But it should, and now it does. Diffs - startkde.cmake 8361fe0 Diff: http://git.reviewboard.kde.org/r/109675/diff/ Testing --- Thanks, Andreas Hartmetz
Re: kwalletmanager ui refactor
On Tuesday 05 February 2013 00:28:37 Till Schäfer wrote: 2. While typing a search phrase the tree elements are collapsed and need to be opened by hand. This leads to three more clicks: - - open the folder - - the category (passwords, pairs, binary data, ...) - - select the entry I suggest to directly select the first item that matches the search phrase and open all folders which contain matching entries. 3. The search field does not have the focus when opening a wallet. You need to click in the field to start typing. It may be a good thing to have the focus directly in the search field, so that you can start typing immediately. These two items are now implemented. The code is still in the ui-refactor branch of kdeutils/kwallet. I plan to request ui-refactor branch review soon. Hopefully we'll get this refactoring out in time for 4.11. Best regards, -- Valentin Rusu (vrusu) IRC: valir KSecretsService (aka KSecretService, KWallet replacement)
Re: KDEReview: Nepomuk-Controller QML
On Monday, March 25, 2013 16:46:10 Vishesh Handa wrote: On Sat, Mar 23, 2013 at 8:12 PM, Jörg Ehrichs joerg.ehri...@gmx.de wrote: The dataengine as well as the applet is only installed if Nepomuk-Core/Soprano is found as build dependency. This would deprecate: kde-runtime/nepomuk/controller/ Deprecate or remove? Cause I would like to remove it. What will the provision be to automatically replace the old systray program with the applet (or at least let the user know where to add the new applet from)? The minor version upgrade process all throughout the KDE/Plasma 4 releases started off as a fairly steady source of minor nits and irritants for users. The Nepomuk controls themselves are already fairly well-known so it's even more important IMO that if they are deprecated that they don't simply disappear completely the first time a new KDE 4.11 user logs in. Likewise it would be a good idea to ensure our Release Notes for 4.11 (if any are started) reflect the migration so that our packagers can ensure they change package dependencies if deemed appropriate. Not trying to discourage, but just some things to think about. Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.
