Re: Review Request 111272: Correctly handle executable names typed into KOpenWithDialog

2013-07-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111272/#review35416 --- kdecore/services/kservice.h

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-07-02 Thread Kevin Ottens
On July 1, 2013, 2:39 p.m., Kevin Ottens wrote: kdeui/util/kglobalsettings.h, line 265 http://git.reviewboard.kde.org/r/71/diff/2/?file=166657#file166657line265 I think it's fine. lxr.kde.org seem to indicate that those colors got abused at some places anyway, and what's

Re: Review Request 111345: KParts::StatusBarExtension: Remember activated state

2013-07-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111345/#review35426 --- Ship it! Makes sense. - David Faure On July 1, 2013, 4:01

Fwd: Re: KIO progress towards tier 1 framework?

2013-07-02 Thread Alex Merry
I suspect a lot of people read both, but it's probably better to keep frameworks discussions on the frameworks list as much as possible. Forwarding there now. Alex Original Message Subject: Re: KIO progress towards tier 1 framework? Date: Tue, 2 Jul 2013 13:05:25 +0200 From:

Re: Review Request 111272: Correctly handle executable names typed into KOpenWithDialog

2013-07-02 Thread Dawit Alemayehu
On July 2, 2013, 7:48 a.m., David Faure wrote: kdecore/services/kservice.h, line 82 http://git.reviewboard.kde.org/r/111272/diff/2/?file=167013#file167013line82 How about a setExec() method rather than a special constructor? This seems a lot clearer to me (and e.g. easier to grep

Re: Review Request 111345: KParts::StatusBarExtension: Remember activated state

2013-07-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111345/#review35444 --- This review has been submitted with commit

Re: Review Request 111345: KParts::StatusBarExtension: Remember activated state

2013-07-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111345/ --- (Updated July 2, 2013, 2:05 p.m.) Status -- This change has been

KF5 Update Meeting Minutes 2013-w27

2013-07-02 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 27 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: apol, ben2367, dfaure, R_Rios, sandsmark, scarpino, sebas, wojtask9 and myself. Topics discussed: * QFontsDatabase patch is getting ready; * Support for

Re: Review Request 111370: system_tray: initialize uninitialized members

2013-07-02 Thread Jiri Slaby
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111370/ --- (Updated July 2, 2013, 6:15 p.m.) Review request for kde-workspace and

Review Request 111371: Fix duplicate targets in PythonMacros.cmake, unbreaking Ninja builds for Python-based KDE apps

2013-07-02 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111371/ --- Review request for kdelibs. Description --- Currently,

Re: KF5 Update Meeting Minutes 2013-w27

2013-07-02 Thread Alexander Neundorf
On Tuesday 02 July 2013, Kevin Ottens wrote: Hello everyone, This is the minutes of the Week 27 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: apol, ben2367, dfaure, R_Rios, sandsmark, scarpino, sebas, wojtask9 and myself. ... * [steveire]

Re: KF5 Update Meeting Minutes 2013-w27

2013-07-02 Thread Alexander Neundorf
On Tuesday 02 July 2013, Kevin Ottens wrote: Hello everyone, This is the minutes of the Week 27 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: apol, ben2367, dfaure, R_Rios, sandsmark, scarpino, sebas, wojtask9 and myself. Topics discussed: *

Re: Review Request 110285: Fixed warning message when user trying to set more than 8 keyboard layouts

2013-07-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110285/#review35479 --- This review has been submitted with commit

Re: Review Request 110285: Fixed warning message when user trying to set more than 8 keyboard layouts

2013-07-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110285/ --- (Updated July 2, 2013, 8:42 p.m.) Status -- This change has been

Re: Review Request 111272: Correctly handle executable names typed into KOpenWithDialog

2013-07-02 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111272/ --- (Updated July 3, 2013, 2:22 a.m.) Review request for kdelibs and David