Re: Review Request 111371: Fix duplicate targets in PythonMacros.cmake, unbreaking Ninja builds for Python-based KDE apps

2013-07-04 Thread Vadim Zhukov
On July 4, 2013, 9:35 a.m., Luca Beltrame wrote: Ship It! Luca Beltrame wrote: Please put this modification also in kdelibs master branch (in fact, put it in master so it'll get merged in next time dfaure merges master into frameworks). Could you (or somebody else) commit it

Re: Disable by default KRandR in 4.11

2013-07-04 Thread Sebastian Kügler
On Thursday, July 04, 2013 01:06:27 Àlex Fiestas wrote: I want to propose to disable by default KRandR from kde-workspace release for 4.11. While I'm considered the maintainer of KRandR truth is I have never been it, I just made it work around 4.7 times but it is still full of bugs and

Review Request 111390: kshorturifilter: inverted condition in home directory handling

2013-07-04 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111390/ --- Review request for KDE Runtime. Description --- While investigating

Re: Disable by default KRandR in 4.11

2013-07-04 Thread Sebastian Kügler
On Thursday, July 04, 2013 17:05:59 Martin Graesslin wrote: On Thursday 04 July 2013 16:34:18 Àlex Fiestas wrote: I think this should go into SC, not just extragear. Very much so since it would replace krandr there. The functionality of plugging in an extra screen or unplugging it

Re: Review Request 111390: kshorturifilter: inverted condition in home directory handling

2013-07-04 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111390/#review35587 --- Ship it! Change looks good to me, please commit. - Michael

Re: Review Request 111390: kshorturifilter: inverted condition in home directory handling

2013-07-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111390/ --- (Updated July 4, 2013, 6:32 p.m.) Status -- This change has been

Re: Review Request 111390: kshorturifilter: inverted condition in home directory handling

2013-07-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111390/#review35596 --- This review has been submitted with commit

Re: Disable by default KRandR in 4.11

2013-07-04 Thread Albert Astals Cid
El Dijous, 4 de juliol de 2013, a les 01:06:27, Àlex Fiestas va escriure: Hi there Hi I want to propose to disable by default KRandR from kde-workspace release for 4.11. While I'm considered the maintainer of KRandR truth is I have never been it, I just made it work around 4.7 times but

Re: Moving KScreen and libkscreen to extragear

2013-07-04 Thread Albert Astals Cid
El Dijous, 4 de juliol de 2013, a les 01:13:36, Àlex Fiestas va escriure: I would like to request a review so we can move KScreen and libkscreen to extragear/base. Has it been virtually moved to kdereview? Cheers, Albert KScreen is a new manager for outputs such: monitors, projectors,

Re: Moving KScreen and libkscreen to extragear

2013-07-04 Thread Ben Cooksley
On Fri, Jul 5, 2013 at 7:41 AM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 4 de juliol de 2013, a les 01:13:36, Àlex Fiestas va escriure: I would like to request a review so we can move KScreen and libkscreen to extragear/base. Has it been virtually moved to kdereview? They have been

Re: Moving KScreen and libkscreen to extragear

2013-07-04 Thread Burkhard Lück
Am Donnerstag, 4. Juli 2013, 01:13:36 schrieb Àlex Fiestas: I would like to request a review so we can move KScreen and libkscreen to extragear/base. KScreen is a new manager for outputs such: monitors, projectors, embedded screens... It contains: -KDED Module which does some magic by

Re: Review Request 111371: Fix duplicate targets in PythonMacros.cmake, unbreaking Ninja builds for Python-based KDE apps

2013-07-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111371/ --- (Updated July 4, 2013, 9:33 p.m.) Status -- This change has been

Re: Review Request 111371: Fix duplicate targets in PythonMacros.cmake, unbreaking Ninja builds for Python-based KDE apps

2013-07-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111371/#review35603 --- This review has been submitted with commit