Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-12-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114219/#review44926 --- Ship it! Yes, clearly correct. For your question about

Re: Review Request 114201: define property X-KDE-PluginKeyword in kdelibs/kio/kcmodule.desktop

2013-12-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114201/#review44927 --- Ship it! kio/kcmodule.desktop

Re: Best practice for libraries supporting both Qt4 and Qt5

2013-12-01 Thread Allan Sandfeld Jensen
On Thursday 28 November 2013, Michael Palimaka wrote: Any thoughts? In an ideal world we would convince the distros to enable Qt namespace on Qt5, so that Qt4 and Qt5 symbols does not clash, and does not cause crashes when loaded as plugins etc. `Allan

Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-12-01 Thread Yichao Yu
On Dec. 1, 2013, 3:47 a.m., David Faure wrote: Yes, clearly correct. For your question about branches: commit in the stable branch and merge upwards (or ask the module maintainers to merge upwards). Thank you for the review. I don't have a git account yet (will apply soon) so could

Re: Best practice for libraries supporting both Qt4 and Qt5

2013-12-01 Thread Rex Dieter
Allan Sandfeld Jensen wrote: On Thursday 28 November 2013, Michael Palimaka wrote: Any thoughts? In an ideal world we would convince the distros to enable Qt namespace on Qt5, so that Qt4 and Qt5 symbols does not clash, and does not cause crashes when loaded as plugins etc. Sounds

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-01 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- (Updated Dec. 1, 2013, 9:32 p.m.) Review request for KDE Runtime and KDE

Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-12-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114219/#review44972 --- This review has been submitted with commit

Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-12-01 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114219/ --- (Updated Dec. 2, 2013, 7:27 a.m.) Status -- This change has been