Review Request 120154: Equal entries implies existing directory
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120154/ --- Review request for kdelibs and David Faure. Repository: kdelibs Description --- Equal entries implies existing directory Diffs - kioslave/file/file_unix.cpp 4734399c3cde8e4a025539d8350ff1b3fabe83ae Diff: https://git.reviewboard.kde.org/r/120154/diff/ Testing --- Equal entries implies existing directory The equal file error should take precedence over the existing directory error, as this implies exist. This actually prevents a data loss on case-insensitive file systems like CIFS, where renaming a directory from 'Test' to 'test' actually removes the single directory (both have the same inode). Thanks, Jan-Marek Glogowski
Re: Review Request 120127: Don't show overwrite dialog if file name is empty
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120127/ --- (Updated Sept. 12, 2014, 8:09 vorm.) Review request for kdelibs. Repository: kdelibs Description (updated) --- Programs using KFileDialog's setConfirmOverwrite(true) (e.g. LibreOffice with KDE4 integration, Mozilla products with KDE4 integration, several components of the PIM suite) will trigger the following strange behaviour: If the file name in the save file dialog is empty and the user selects Save, the dialog will ask if you want to overwrite the current directory (instead of just ignoring the empty input). By moving the query below the directory checks the order is correct again, showing the overwrite confirmation dialog only if the field contains a unique filename. Looking at the code this also affects Frameworks 5 / kio, though I haven't tested it yet. Diffs - kfile/kfilewidget.cpp fc9b169 Diff: https://git.reviewboard.kde.org/r/120127/diff/ Testing --- Thanks, Ignaz Forster
KDE Frameworks 5.2.0 release
KDE Frameworks 5.2.0 was released today. http://www.kde.org/announcements/kde-frameworks-5.2.0.php Here is the list of important changes since the previous release: ### KActivities * reimplementation of the file item plugin for linking files to activities ### KArchive * fix handling of uncompressed files ### KConfigWidgets * fix missing default shortcuts for standard actions, leading to many runtime warnings * better support for QGroupBox in KConfigDialogManager ### KCoreAddons * Mark KAboutData::setProgramIconName() as deprecated, it did not do anything. Use QApplication::setWindowIcon(QIcon::fromTheme(...)) instead. * new classes Kdelibs4ConfigMigrator and KPluginMetaData ### KDeclarative * added org.kde.kio component. ### KImageFormats * disable the DDS and JPEG-2000 plugins when Qt version is 5.3 or later ### KIO * now follows the mime-apps spec, for better interoperability with gio when it comes to the user's preferred and default apps. * new classes EmptyTrashJob and RestoreJob. * new functions isClipboardDataCut and setClipboardDataCut. ### KNewStuff * installing stuff works again (porting bug) ### KWidgetsAddons * new class KColumnResizer (makes it easy to vertically align widgets across groups) ### KWindowSystem * New method KWindowSystem::setOnActivities ### KXmlGui * KActionCollection::setDefaultShortcuts now makes the shortcut active too, to simplify application code. ### Threadweaver * The maximum worker count will now decrease if a lower value is set after workers have been created. Previously, workers would remain active once they have been created. * Examples from the previous ThreadWeaverDemos Github repository are being merged into the KF5 ThreadWeaver repo. * The maximum worker count can now be set to zero (the previous minimum was 1). Doing so will effectively halt processing in the queue. * Documentation of various aspects of ThreadWeaver use is becoming part of the KDE Frameworks Cookbook. Parts of it is located in the examples/ directory. ### Buildsystem changes * Support for relative libexec dir. ### Frameworkintegration * the file dialog now remembers its size correctly, and works better with remote URLs. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
Gerrit available for trial
Hi all, service annoucement for the people who were not so lucky as to being able to participant at this year's Akademy: Jan Kundrát, of Trojita fame, has set up a Gerrit instance [1] connected to the KDE git repository, i.e. it is now possible for KDE projects to opt in to a test of Gerrit for their review/submission workflow. It is currently used for Trojita itself and at the Frameworks BoF at Akademy we decided to also test drive this with two of our actively developed frameworks. Jan said in his Akademy talk [2] that other projects are welcome to participate in the trial so that developers can see if they like the tool and the workflows it encourages and also provide some testing for the setup as well. Participating will not make Gerrit the exclusive path for patches, it is still possible to push to KDE's git directly and/or use a reviewboard based workflow. Cheers, Kevin [1] https://gerrit.vesnicky.cesnet.cz/ [2] https://conf.kde.org/en/Akademy2014/public/events/140 -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part.
Re: Gerrit available for trial
Hi folks, we're trying to document how to work with Gerrit within KDE at [1]. If you can make that page better, please go ahead. With kind regards, Jan [1] https://techbase.kde.org/Development/Gerrit -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
Re: Review Request 119572: Part: use correct slots for QStatusbar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119572/ --- (Updated Sept. 12, 2014, 8:26 p.m.) Status -- This change has been marked as submitted. Review request for kdelibs and Martin Tobias Holmedahl Sandsmark. Repository: filelight Description --- Part: use correct slots for QStatusbar The correct names are showMessage(..) and clearMessage(). Diffs - src/part/part.cpp e63c852151c54018dc5dee448b0bc1367d6ee149 Diff: https://git.reviewboard.kde.org/r/119572/diff/ Testing --- Warning message is gone when running and file names start appearing in the status bar. Thanks, Heiko Becker
Re: Using Gerrit for code review in KDE
On Tuesday, September 9, 2014, Jan Kundrát j...@flaska.net wrote: If you would like all plasma to go, just give me a list of repos and I can make it happen. No, definitely not yet In my opinion, the purpose of this test is not to verify that Gerrit works or that the ACLs are set up properly -- both were done already. As part of the experiment i would also like to try to have stricter acls for +2 and submit, like starting from mantainers then slowly adding people (that's also how i understood it would have worked during the bof) -- Marco Martin
