Review Request 120403: [OS X] adapting KMenu::addTitle to OS X menubar specifics

2014-09-28 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120403/ --- Review request for KDE Software on Mac OS X, kdelibs and Qt KDE.

Re: Review Request 120403: [OS X] adapting KMenu::addTitle to OS X menubar specifics

2014-09-28 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120403/ --- (Updated Sept. 28, 2014, 2:46 p.m.) Review request for KDE Software on

Review Request 120406: ksysguardd: Avoid including IO-wait in CPU load.

2014-09-28 Thread Søren Holm
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120406/ --- Review request for kde-workspace. Repository: kde-workspace

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-28 Thread Boris Egorov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120120/ --- (Updated Sept. 28, 2014, 4:03 p.m.) Status -- This change has been

Re: Updating our tools

2014-09-28 Thread Allen Winter
On Wednesday, September 24, 2014 10:38:37 AM Jeremy Whiting wrote: Allen, Thanks for fixing this, I think it will be a useful tool to check our existing frameworks and code based on frameworks with. I'll update the techbase pages myself. The Krazy check for frameworks should be good to go

Re: Automatic Info Reporting BoF summary

2014-09-28 Thread Ingo Klöcker
On Saturday 27 September 2014 23:21:52 Mario Fux wrote: Am Samstag, 27. September 2014, 22.05:03 schrieb Thomas Lübking: That's just my humble opinion but honestly I think contact information to our users is much more valueable than any other data. I guess they'll have a similar

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-28 Thread Boris Egorov
On Sept. 23, 2014, 9:04 p.m., Christoph Feck wrote: No problem if we want to discuss it longer, and eventually change icon sizes to match text sizes (as is done in Skulpture style) or optionally allow configuring icon sizes. But right now, limiting to a hardcoded 20px value is a

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-28 Thread Christoph Feck
On Sept. 23, 2014, 9:04 p.m., Christoph Feck wrote: No problem if we want to discuss it longer, and eventually change icon sizes to match text sizes (as is done in Skulpture style) or optionally allow configuring icon sizes. But right now, limiting to a hardcoded 20px value is a

Re: Review Request 120403: [OS X] adapting KMenu::addTitle to OS X menubar specifics

2014-09-28 Thread René J . V . Bertin
On Sept. 28, 2014, 5:13 p.m., Thomas Lübking wrote: kdeui/widgets/kmenu.cpp, line 182 https://git.reviewboard.kde.org/r/120403/diff/1/?file=315609#file315609line182 try to avoid negated bools unless for performance or readability reasons (ie. you'd need !flag a lot otherwise)

Re: Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzilla

2014-09-28 Thread Frédéric Sheedy
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120376/ --- (Updated sep. 29, 2014, 1:57 matin) Review request for KDE Runtime.

Review Request 120418: kio_webdav: Added 'copyFromFile' support

2014-09-28 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120418/ --- Review request for kdelibs. Bugs: 334192