Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-27 Thread Gregor Mi
On Jan. 26, 2015, 7:05 a.m., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-27 Thread Nick Shaforostoff
On Січ. 27, 2015, 6:59 до полудня, Martin Gräßlin wrote: startkde/kcminit/main.cpp, lines 250-254 https://git.reviewboard.kde.org/r/122270/diff/1/?file=345342#file345342line250 I do not like this. If the only need is to check whether it's X11 multi-head, it should open an

Re: Sysadmin report on the modernization of our infrastructure

2015-01-27 Thread Jan Kundrát
On Tuesday, 27 January 2015 09:51:46 CEST, Ben Cooksley wrote: Jenkins provides rich tracking of tests, code coverage and code quality (eg: cppcheck) in addition to checking if it builds. Zuul is designed to determine if it builds and if tests fail - providing a binary pass/fail response. This

Re: Sysadmin report on the modernization of our infrastructure

2015-01-27 Thread Ben Cooksley
Hi all, Based on the feedback we'll now begin putting together a test instance so Phabricator can be seriously evaluated by the community. I've noted that the following projects have expressed interest in using it: - Calligra/Krita. - Zanshin. - KActivities. - Konversation. If any other

Re: Sysadmin report on the modernization of our infrastructure

2015-01-27 Thread Inge Wallin
On Tuesday, January 27, 2015 03:30:48 Thomas Lübking wrote: On Samstag, 24. Januar 2015 15:24:28 CET, Thomas Friedrichsmeier wrote: But beyond review functionality, I think moving towards a more integrated solution is clearly a step in the right direction, and this is what makes the choice

Re: Sysadmin report on the modernization of our infrastructure

2015-01-27 Thread Ben Cooksley
On Tue, Jan 27, 2015 at 3:30 PM, Thomas Lübking thomas.luebk...@gmail.com wrote: On Samstag, 24. Januar 2015 15:24:28 CET, Thomas Friedrichsmeier wrote: But beyond review functionality, I think moving towards a more integrated solution is clearly a step in the right direction, and this is

[kcalc][kcharselect][kcron] Merged frameworks branch to master, now KF5 based

2015-01-27 Thread Christoph Feck
Hi, I just merged the frameworks KF5 porting branches of the following applications to master branch: - kcalc - kcharselect - kcron These applications will be released as KF5 applications for the KDE Applications 15.03 release. Please check if everything went smooth, and report

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-27 Thread Thomas Lübking
On Jan. 27, 2015, 6:59 vorm., Martin Gräßlin wrote: startkde/kcminit/main.cpp, lines 250-254 https://git.reviewboard.kde.org/r/122270/diff/1/?file=345342#file345342line250 I do not like this. If the only need is to check whether it's X11 multi-head, it should open an

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-27 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/ --- (Updated Jan. 28, 2015, 12:47 a.m.) Review request for kde-workspace,

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-27 Thread Thomas Lübking
On Jan. 26, 2015, 7:05 vorm., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122267: ki18n: Make it build with msvc compilers again

2015-01-27 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122267/ --- (Updated Jan. 27, 2015, 2:15 p.m.) Status -- This change has been

Re: [kcalc][kcharselect][kcron] Merged frameworks branch to master, now KF5 based

2015-01-27 Thread Albert Astals Cid
El Dimecres, 28 de gener de 2015, a les 00:12:26, Christoph Feck va escriure: Hi, I just merged the frameworks KF5 porting branches of the following applications to master branch: - kcalc - kcharselect - kcron These applications will be released as KF5 applications for the KDE

Re: [kcalc][kcharselect][kcron] Merged frameworks branch to master, now KF5 based

2015-01-27 Thread Luigi Toscano
Christoph Feck ha scritto: Hi, I just merged the frameworks KF5 porting branches of the following applications to master branch: - kcalc - kcharselect - kcron These applications will be released as KF5 applications for the KDE Applications 15.03 release. Please check if

Re: Sysadmin report on the modernization of our infrastructure

2015-01-27 Thread Thomas Friedrichsmeier
Hi, On Tue, 27 Jan 2015 03:30:48 +0100 Thomas Lübking thomas.luebk...@gmail.com wrote: On Samstag, 24. Januar 2015 15:24:28 CET, Thomas Friedrichsmeier wrote: But beyond review functionality, I think moving towards a more integrated solution is clearly a step in the right direction, and

Re: Placement of config files for Plasma 5 and KF5-based applications

2015-01-27 Thread Martin Gräßlin
On Tuesday 27 January 2015 01:01:27 Thomas Pfeiffer wrote: Hi everyone, first of all, I think it's a great step in the right direction that we're now putting our config files in ~/.config instead of ~/.kde(4), we're now finally standard-compliant. However, where we still could - and imho

Placement of config files for Plasma 5 and KF5-based applications

2015-01-27 Thread Thomas Pfeiffer
Hi everyone, first of all, I think it's a great step in the right direction that we're now putting our config files in ~/.config instead of ~/.kde(4), we're now finally standard-compliant. However, where we still could - and imho should - do better is with where exactly we put them. If I look

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-27 Thread Nick Shaforostoff
On Jan. 27, 2015, 6:59 a.m., Martin Gräßlin wrote: startkde/kcminit/main.cpp, lines 250-254 https://git.reviewboard.kde.org/r/122270/diff/1/?file=345342#file345342line250 I do not like this. If the only need is to check whether it's X11 multi-head, it should open an