Hi,
Jan Kundrát wrote:
> Feedback is very welcome.
First of all, I would like to apologize for my overly negative tone in your
prior feedback threads.
I would also like to point out that I have absolutely no experience with
Phabricator (the solution proposed by the competing proposal), and as
Pino Toscano wrote:
> Why does libkgeomap need to move "somewhere" just to be used by some
> other extragear application? Just do independent releases of it, and
> stop bundling it in digikam, so
> a) it's easier to package it in distros
> b) can be really seen as something more than "digikam's ow
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122320/
---
Review request for kde-workspace, Martin Gräßlin and Thomas Lübking.
Repo
> On Jan. 26, 2015, 9:41 a.m., Christian Mollekopf wrote:
> > Looks reasonable to me. I'll apply the patch locally and test it for a
> > while.
>
> Christian Mollekopf wrote:
> This patch brings the original problem back, that shared folders do not
> appear until something causes a dataCha
On 01/29/2015 10:34 PM, Thomas Lübking wrote:
Given the multiple concerns on the gerrit webfrontend (not only in this
kcd thread) I however also assume that it should be not too hard to get
a serious improvement upstream.
That includes "If we endup w/ a -hypothetical- decision between
'powerful
On Fri, Jan 30, 2015 at 10:34 AM, Thomas Lübking
wrote:
> On Donnerstag, 29. Januar 2015 21:03:32 CET, Eike Hein wrote:
>
>> I think it's a real concern, and I'm wary of "we can patch
>> it away" because carrying a huge custom patch delta for UI
>> mods is what kept us from upgrading Bugzilla for
On Donnerstag, 29. Januar 2015 21:03:32 CET, Eike Hein wrote:
I think it's a real concern, and I'm wary of "we can patch
it away" because carrying a huge custom patch delta for UI
mods is what kept us from upgrading Bugzilla for multiple
years.
Afaiu Jan's proposal, the default gerrit webui is
On Donnerstag, 29. Januar 2015 12:54:25 CET, Jan Kundrát wrote:
On Thursday, 29 January 2015 12:49:17 CEST, Christoph Feck wrote:
If it even allows to edit a change request from a different
person online, then I *want that*. I find it much more time
consuming and demotivating to nitpick small s
On 01/29/2015 08:54 PM, Luca Beltrame wrote:
This is only the perspective of an occasional contributor, so perhaps it
doesn't weigh as much.
I think it's a real concern, and I'm wary of "we can patch
it away" because carrying a huge custom patch delta for UI
mods is what kept us from upgradin
Milian Wolff wrote:
> I agree. But is that such a serious blocker that outweights all other
> benefits? As I just wrote in the other mail, I think its a problem we, as
Perhaps not for frequent contributors, but for occasional ones (speaking for
for myself, I send a patch every 3-5 months, at bes
> On Січ. 29, 2015, 2:36 після полудня, Martin Gräßlin wrote:
> > I'm surprised that you pushed the change although the review was not
> > finished and you hadn't a shipit on any of the versions.
>
> Thomas Lübking wrote:
> Nick, though it does not seem as if you had introduced it, the
> "
> On Січ. 29, 2015, 2:36 після полудня, Martin Gräßlin wrote:
> > I'm surprised that you pushed the change although the review was not
> > finished and you hadn't a shipit on any of the versions.
>
> Thomas Lübking wrote:
> Nick, though it does not seem as if you had introduced it, the
> "
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi,
On 29.01.2015 12:25, Jan Kundrát wrote:
> Git has a config diff.orderfile option which might solve this
> reasonably well. Do you think that the following sorting order is
> reasonable for a KDE's default?
>
> CMake* cmake* src/*.h src/*.cpp *t
> On Jan. 26, 2015, 7:05 a.m., Martin Gräßlin wrote:
> > My opinion is that this is a feature which should not be exposed in
> > libksysguard. It actually ties libksysguard to KWin, while libksysguard was
> > in the past also used in e.g. kdevelop.
> >
> > If libksysguard wants to offer the fu
On 01/29/2015 06:51 PM, Jan Kundrát wrote:
The VM runs at my workplace. The KDE sysadmins have root access,
PostgreSQL backups are automatically pushed to a KDE server twice a day,
and Git is replicated to git.kde.org within seconds after each push.
Just for the record: I consider you a KDE s
> On Jan. 26, 2015, 9:41 a.m., Christian Mollekopf wrote:
> > Looks reasonable to me. I'll apply the patch locally and test it for a
> > while.
>
> Christian Mollekopf wrote:
> This patch brings the original problem back, that shared folders do not
> appear until something causes a dataCha
On Thursday, 29 January 2015 18:22:35 CEST, Eike Hein wrote:
One thing I'm unclear on: Does the gerrit test instance run
on machines administrated by kde.org these days?
The VM runs at my workplace. The KDE sysadmins have root access, PostgreSQL
backups are automatically pushed to a KDE server
On 01/29/2015 06:24 PM, Milian Wolff wrote:
Much nicer, I think!
I disagree - having the comment in a floating popup instead
of breaking up source code makes it easier to read the code
for me.
Personally, I agree that the gerrit UI is terrible to use.
It's not just the diff viewer, either. T
On Thursday 29 January 2015 16:27:52 Luca Beltrame wrote:
> Jan Kundrát wrote:
> > as promised, here is a proposal on how our infrastructure can be improved,
> > with emphasis on service integration. There are screenshots inside.
>
> I'm not sure if this is the right thread for it, but as someone
On 01/29/2015 06:16 PM, Milian Wolff wrote:
FWIW, this document reads like a fairy tale to me. The fact that so much is
already tested and deployed
One thing I'm unclear on: Does the gerrit test instance run
on machines administrated by kde.org these days?
Cheers,
Eike
On Tuesday 27 January 2015 11:08:49 Jan Kundrát wrote:
> Hi,
> as promised, here is a proposal on how our infrastructure can be improved,
> with emphasis on service integration. There are screenshots inside.
>
> Feedback is very welcome.
Hello Jan,
thank you very much for this exhaustive overvie
> On Jan. 26, 2015, 9:41 a.m., Christian Mollekopf wrote:
> > Looks reasonable to me. I'll apply the patch locally and test it for a
> > while.
>
> Christian Mollekopf wrote:
> This patch brings the original problem back, that shared folders do not
> appear until something causes a dataCha
On Mittwoch, 28. Januar 2015 13:14:14 CET, Martin Gräßlin wrote:
Ah. Web UI concerns.
Yes. Share most of them.
Navigation through the code is difficult, you cannot see the
complete change in one, but have to go through each file.
+1
Ideally one could have show the patch at once (for small on
Jan Kundrát wrote:
> as promised, here is a proposal on how our infrastructure can be improved,
> with emphasis on service integration. There are screenshots inside.
I'm not sure if this is the right thread for it, but as someone who commits
patches very occasionally either through CLI or the we
> On Jan. 29, 2015, 2:36 nachm., Martin Gräßlin wrote:
> > I'm surprised that you pushed the change although the review was not
> > finished and you hadn't a shipit on any of the versions.
Nick, though it does not seem as if you had introduced it, the
"QGuiApplication::screens().count() > 1" c
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122270/#review74982
---
I'm surprised that you pushed the change although the review w
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122270/
---
(Updated Jan. 29, 2015, 11:58 a.m.)
Status
--
This change has been m
On Thursday, 29 January 2015 12:49:17 CEST, Christoph Feck wrote:
If it even allows to edit a change request from a different person
online, then I *want that*. I find it much more time consuming and
demotivating to nitpick small style/whitespace changes, than to simply
edit them out.
Yes, it
On Thursday 29 January 2015 00:10:02 Jan Kundrát wrote:
> It will be even easier -- the upcoming Gerrit 2.11 contains an
> online editor, so the workflow will be "open file, edit it, push a
> button for making a change request".
If it even allows to edit a change request from a different person
o
On Wednesday, 28 January 2015 13:14:14 CEST, Martin Gräßlin wrote:
Navigation through the code is difficult, you cannot see the
complete change in one, but have to go through each file. This
is something I consider as unfortunate as normally I prefer reading the
changes to the header before the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122270/#review74973
---
I still think this is wrong as QGuiApplication::screens().coun
> On Jan. 26, 2015, 8:05 a.m., Martin Gräßlin wrote:
> > My opinion is that this is a feature which should not be exposed in
> > libksysguard. It actually ties libksysguard to KWin, while libksysguard was
> > in the past also used in e.g. kdevelop.
> >
> > If libksysguard wants to offer the fu
32 matches
Mail list logo
