Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

2015-02-11 Thread Frank Reininghaus
On Feb. 9, 2015, 10:01 nachm., Kevin Kofler wrote: IMHO, QUrl::fromUserInput(str, QString() QUrl::AssumeLocalFile) would be safer. Or do you really think dolphin nonexistentfile should look up nonexistentfile over DNS? Thomas Lübking wrote: +1, notably since

dolphin Qt requirement

2015-02-11 Thread Jeremy Whiting
Arjun, http://mail.kde.org/pipermail/kde-frameworks-devel/2015-February/022157.html -- it seems your recent commit changed Dolphin to require Qt 5.4 since AssumeLocalFile is new in Qt 5.4. If you want to depend on Qt 5.4 please bump the requirement in the kde-baseapps/CMakeLists.txt. If we/you

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

2015-02-11 Thread Kevin Kofler
On Feb. 9, 2015, 10:01 nachm., Kevin Kofler wrote: IMHO, QUrl::fromUserInput(str, QString() QUrl::AssumeLocalFile) would be safer. Or do you really think dolphin nonexistentfile should look up nonexistentfile over DNS? Thomas Lübking wrote: +1, notably since

Re: KDiagram libs (KChart, KGantt) in KDE Review

2015-02-11 Thread Adriaan de Groot
On Monday 09 February 2015 01:50:03 Friedrich W. H. Kossebau wrote: Yes, nearly copypaste: the copies of KDChart in Calligra KMyMoney are older (2.4.1, based on Qt4) versions, while the copy of KDChart in Massif-Visualizer matches the version of the KChart lib in KDiagram. I've tried

Re: KDiagram libs (KChart, KGantt) in KDE Review

2015-02-11 Thread Andreas Hartmetz
On Wednesday 11 February 2015 14:59:50 Adriaan de Groot wrote: On Monday 09 February 2015 01:50:03 Friedrich W. H. Kossebau wrote: Yes, nearly copypaste: the copies of KDChart in Calligra KMyMoney are older (2.4.1, based on Qt4) versions, while the copy of KDChart in Massif-Visualizer

Review Request 122534: [konq-plugins] fsview: Add missing include(ECMMarkAsTest)

2015-02-11 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122534/ --- Review request for KDE Base Apps. Repository: kde-baseapps Description

Re: Review Request 122534: [konq-plugins] fsview: Add missing include(ECMMarkAsTest)

2015-02-11 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122534/#review75894 --- I'd move that line to the top CMakeLists.txt. And remove

Re: Review Request 122534: [konq-plugins] fsview: Add missing include(ECMMarkAsTest)

2015-02-11 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122534/ --- (Updated Feb. 11, 2015, 11:52 p.m.) Review request for KDE Base Apps.