Re: Review Request 125236: FindQt4: Use CHECK_CXX_SYMBOL_EXISTS instead of CHECK_C_SYMBOL_EXISTS.

2015-09-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125236/#review85550 --- This change is a correct one to make, but I've slightly lost

Moving Kapture to KDEGraphics

2015-09-17 Thread Boudhayan Gupta
Hi, Kapture (formerly KScreenGenie) has been in review for a couple of months now. I've just finished the rename, which I believe was the last pending task before moving to KDE Graphics. Can file a sysadmin ticket to move to KDE Graphics now - and then add it to the list of apps released with

breeze repo to be split into breeze and breeze-icons come plasma 5.5

2015-09-17 Thread Harald Sitter
Some time between now and plasma 5.5 branching we will split the breeze icon theme from the breeze repo to its own breeze-icons repo. HS

Re: Moving Kapture to KDEGraphics

2015-09-17 Thread Luigi Toscano
On Thursday 17 of September 2015 17:43:08 Boudhayan Gupta wrote: > Hi, > > Kapture (formerly KScreenGenie) has been in review for a couple of > months now. I've just finished the rename, which I believe was the > last pending task before moving to KDE Graphics. Please also rename the template

Re: Moving Kapture to KDEGraphics

2015-09-17 Thread Boudhayan Gupta
On 17 September 2015 at 17:58, Luigi Toscano wrote: > Please also rename the template file generated by Messages.sh (I can't do it > right now). Done :-)

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

2015-09-17 Thread Jeremy Whiting
> On Sept. 17, 2015, 3:28 p.m., Thomas Lübking wrote: > > a) fix the test? > > b) the patch first limits to a Url subset and then guesses what it was ... > > if that is the "fix" it smell like okular or the test scenario cannot deal > > with remote files? As I said in the description this

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

2015-09-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125297/ --- (Updated Sept. 17, 2015, 3:46 p.m.) Review request for kdelibs and

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

2015-09-17 Thread Jeremy Whiting
> On Sept. 17, 2015, 4:17 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 99 > > > > > > I'd actually prefer if you fixed DnD as the fixme says instead of > > removing the feature. Dragging and

Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

2015-09-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125297/ --- Review request for kdelibs and Albert Astals Cid. Repository: okular

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

2015-09-17 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125297/#review85590 --- a) fix the test? b) the patch first limits to a Url subset

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

2015-09-17 Thread Thomas Lübking
> On Sept. 17, 2015, 9:28 nachm., Thomas Lübking wrote: > > a) fix the test? > > b) the patch first limits to a Url subset and then guesses what it was ... > > if that is the "fix" it smell like okular or the test scenario cannot deal > > with remote files? > > Jeremy Whiting wrote: > As

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

2015-09-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125297/ --- (Updated Sept. 17, 2015, 3:06 p.m.) Review request for kdelibs and

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

2015-09-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125297/#review85593 --- shell/shell.cpp

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

2015-09-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125297/ --- (Updated Sept. 17, 2015, 4:58 p.m.) Status -- This change has been