Re: Policy regarding QtWebKit and QtScript

2015-12-24 Thread Adriaan de Groot
On Tuesday 22 December 2015 16:07:06 Lisandro Damián Nicanor Pérez Meyer wrote: > > The idea that users may have remainders of QtWebKit 5.5 on their disk (or > > not and thus unresolvable linkage) and install Qt 5.6 and still have (not > > recompiled) client code that is now gonna crash scares me

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-24 Thread Thomas Lübking
> On Dec. 19, 2015, 10:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the