Re: Review Request 126627: Replace screensaver inhibition by direct dbus calls

2016-01-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126627/#review90590 --- Makes me sad :( +1 nonetheless app/mainwindow.cpp (line

Re: Review Request 126627: Replace screensaver inhibition by direct dbus calls

2016-01-04 Thread Martin Klapetek
> On Jan. 4, 2016, 9:18 p.m., Kai Uwe Broulik wrote: > > app/mainwindow.cpp, line 738 > > > > > > Is this check neccessary? Probably not, but then if you think about Gwenview actually being used outside of

Re: Review Request 126627: Replace screensaver inhibition by direct dbus calls

2016-01-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126627/ --- (Updated Jan. 4, 2016, 9:07 p.m.) Review request for Gwenview, KDE Base

Jenkins-kde-ci: kdelibs KDE-4.14 latest-qt4 » Linux,gcc - Build # 51 - Still Unstable!

2016-01-04 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs%20KDE-4.14%20latest-qt4/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 04 Jan 2016 09:51:50 + Build duration: 12 min CHANGE SET Revision

Jenkins-kde-ci: kdelibs KDE-4.14 stable-qt4 » Linux,gcc - Build # 48 - Still Unstable!

2016-01-04 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs%20KDE-4.14%20stable-qt4/PLATFORM=Linux,compiler=gcc/48/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 04 Jan 2016 09:51:50 + Build duration: 11 min CHANGE SET Revision

Re: Review Request 126304: (re)enable building with -DQTC_QT5_ENABLE_KDE

2016-01-04 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126304/#review90548 --- qt5/style/CMakeLists.txt (line 70)

Re: Review Request 126304: (re)enable building with -DQTC_QT5_ENABLE_KDE

2016-01-04 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126304/#review90551 --- Ship it! LGTM other than the white space issue. Sorry for

Re: Review Request 126304: (re)enable building with -DQTC_QT5_ENABLE_KDE

2016-01-04 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126304/#review90549 --- qt5/style/qtcurve_api.cpp (line 80)

Re: Review Request 126304: (re)enable building with -DQTC_QT5_ENABLE_KDE

2016-01-04 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126304/ --- (Updated Jan. 4, 2016, 4:04 p.m.) Status -- This change has been