Re: Review Request 129114: [kdialog] Ability to read from stdin in textbox

2016-10-06 Thread Anthony Fieroni 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129114/
---

(Updated Oct. 7, 2016, 4:02 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Base Apps and David Faure.


Changes
---

Submitted with commit 37023280884cacd331cddfc6b12bc644bfddc36f by Anthony 
Fieroni to branch frameworks.


Repository: kde-baseapps


Description
---

^^


Diffs
-

  kdialog/widgets.cpp 70f4258 

Diff: https://git.reviewboard.kde.org/r/129114/diff/


Testing
---


Thanks,

Anthony Fieroni

Re: Review Request 128750: Fix compilation of kdecore

2016-10-06 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128750/
---

(Updated Oct. 6, 2016, 9:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for kdelibs and Andrea Iacovitti.


Changes
---

Submitted with commit 155bdfb470dd9e00814597b48c9560bfd4fcd69e by Albert Astals 
Cid to branch KDE/4.14.


Repository: kdelibs


Description
---

Without this I get

CMakeFiles/KF5Codecs.dir/kcharsets.cpp.o: In function 
`KCharsets::fromEntity(QString const&)':
kcharsets.cpp:(.text+0x5cf): undefined reference to `kde_findEntity'

Use gperf C++ generated code instead of C

See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=41194 for more info


Diffs
-

  kdecore/localization/kcharsets.cpp 5b72432 
  kdecore/localization/kentities.cc 8c18351 
  kdecore/localization/kentities.gperf 19522fe 

Diff: https://git.reviewboard.kde.org/r/128750/diff/


Testing
---

Compiles


Thanks,

Albert Astals Cid

Re: Review Request 129114: [kdialog] Ability to read from stdin in textbox

2016-10-06 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129114/#review99831
---


Fix it, then Ship it!




Looks good.


kdialog/widgets.cpp (line 115)


QLatin1String is better for a comparison


- David Faure


On Oct. 6, 2016, 5:57 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129114/
> ---
> 
> (Updated Oct. 6, 2016, 5:57 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   kdialog/widgets.cpp 70f4258 
> 
> Diff: https://git.reviewboard.kde.org/r/129114/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 128750: Fix compilation of kdecore

2016-10-06 Thread Lamarque Souza 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128750/#review99830
---


Ship it!




Ship It!

- Lamarque Souza


On Aug. 24, 2016, 10:49 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128750/
> ---
> 
> (Updated Aug. 24, 2016, 10:49 p.m.)
> 
> 
> Review request for kdelibs and Andrea Iacovitti.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Without this I get
> 
> CMakeFiles/KF5Codecs.dir/kcharsets.cpp.o: In function 
> `KCharsets::fromEntity(QString const&)':
> kcharsets.cpp:(.text+0x5cf): undefined reference to `kde_findEntity'
> 
> Use gperf C++ generated code instead of C
> 
> See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=41194 for more info
> 
> 
> Diffs
> -
> 
>   kdecore/localization/kcharsets.cpp 5b72432 
>   kdecore/localization/kentities.cc 8c18351 
>   kdecore/localization/kentities.gperf 19522fe 
> 
> Diff: https://git.reviewboard.kde.org/r/128750/diff/
> 
> 
> Testing
> ---
> 
> Compiles
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 128750: Fix compilation of kdecore

2016-10-06 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128750/#review99829
---



ping, if noone answers i'll just commit in two weeks.

- Albert Astals Cid


On Aug. 24, 2016, 10:49 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128750/
> ---
> 
> (Updated Aug. 24, 2016, 10:49 p.m.)
> 
> 
> Review request for kdelibs and Andrea Iacovitti.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Without this I get
> 
> CMakeFiles/KF5Codecs.dir/kcharsets.cpp.o: In function 
> `KCharsets::fromEntity(QString const&)':
> kcharsets.cpp:(.text+0x5cf): undefined reference to `kde_findEntity'
> 
> Use gperf C++ generated code instead of C
> 
> See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=41194 for more info
> 
> 
> Diffs
> -
> 
>   kdecore/localization/kcharsets.cpp 5b72432 
>   kdecore/localization/kentities.cc 8c18351 
>   kdecore/localization/kentities.gperf 19522fe 
> 
> Diff: https://git.reviewboard.kde.org/r/128750/diff/
> 
> 
> Testing
> ---
> 
> Compiles
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Review Request 129114: [kdialog] Ability to read from stdin in textbox

2016-10-06 Thread Anthony Fieroni 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129114/
---

Review request for KDE Base Apps and David Faure.


Repository: kde-baseapps


Description
---

^^


Diffs
-

  kdialog/widgets.cpp 70f4258 

Diff: https://git.reviewboard.kde.org/r/129114/diff/


Testing
---


Thanks,

Anthony Fieroni