Re: announcement: Kwave is in kdereview

2016-10-13 Thread David Faure
On jeudi 13 octobre 2016 06:37:18 PDT Thomas Eschenbacher wrote: > > kf5.kcoreaddons.kaboutdata: Could not initialize the equivalent properties > > of Q*Application: no instance (yet) existing. > > I am not aware of doing anything wrong in that place. I told you already what you are doing wrong

Re: announcement: Kwave is in kdereview

2016-10-13 Thread David Faure
On mardi 11 octobre 2016 21:41:09 PDT Thomas Eschenbacher wrote: > David Faure wrote: > > [...] > > As a user, I definitely vote for kwave going to kdemultimedia. > > As a developer that means I have to review it ;-) > > yes, I vote for kdemultimedia too. Forget about extragear... I meant, as a

Re: Review Request 129134: Fix the hanging sftp ioslave

2016-10-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129134/#review0 --- Good strategy overall, but it seems to me that some of the

Re: TRANSLATION_DOMAIN not to be used for app code

2016-10-13 Thread Thomas Eschenbacher
Albert Astals Cid wrote: > [...] What breaks exactly? >>> >>> Anything using KLocalizedString::applicationDomain() >>> >>> https://lxr.kde.org/search?_filestring=&_string=KL.*%3AapplicationDoma >> >> The XMLGUI ones though only fallback to that if the rc file has no domain >> tag set, so

Re: Moved to KDE Review: KReport

2016-10-13 Thread Adam Pigg
Yes, I'll take a look, is there a list of problem classes? On Mon, 10 Oct 2016, 23:18 Jaroslaw Staniek, wrote: > > > On 11 October 2016 at 00:09, Albert Astals Cid wrote: > > El dissabte, 8 d’octubre de 2016, a les 7:49:21 CEST, Ben Cooksley va > escriure: > >

Re: announcement: Kwave is in kdereview

2016-10-13 Thread Thomas Eschenbacher
Albert Astals Cid wrote: > [...] > These warnings look like nice to fix > kf5.kcoreaddons.kaboutdata: Could not initialize the equivalent properties of > Q*Application: no instance (yet) existing. > kf5.kcoreaddons.kaboutdata: QCoreApplication::organizationDomain "kde.org" is > out-of-sync with

Re: announcement: Kwave is in kdereview

2016-10-13 Thread Thomas Eschenbacher
On 09.10.2016 15:21, Burkhard Lück wrote: > [...] > I have three untranslated strings in the GUI of the main window in the fully > translated locale x-test + de: > > the menu item "Record" > > "Record" + "Enter Command" in the Settings menu thanks for the hint, you are right. These strings

Re: announcement: Kwave is in kdereview

2016-10-13 Thread Thomas Eschenbacher
David Faure wrote: > [...] > As a user, I definitely vote for kwave going to kdemultimedia. > As a developer that means I have to review it ;-) yes, I vote for kdemultimedia too. Forget about extragear... > CMakeLists.txt: > * I think you can remove the RPATH settings section, ECM takes care of

Re: Test your applications on Wayland

2016-10-13 Thread Adriaan de Groot
On Thursday, October 13, 2016 01:12:27 PM Martin Graesslin wrote: > Just an example of an issue I run into today: > https://git.reviewboard.kde.org/ r/129171/ > > Application just crashed on startup due to a missing nullptr check exposed > by a different windowing systems. This intrigued me,

Re: Test your applications on Wayland

2016-10-13 Thread Martin Graesslin
On Tuesday, October 11, 2016 2:14:45 PM CEST Martin Graesslin wrote: > Hello KDE application developers, > > with Plasma 5.8 we have reached a quite solid state in the Wayland porting > efforts. A state where you can start to test whether your application works > correctly on Wayland. Normally