Re: kdereview - xdg-desktop-portal-kde

[Jan Grulich]

On úterý 2. května 2017 23:58:20 CEST you wrote:
> On martedì 2 maggio 2017 17:26:41 CEST Jan Grulich wrote:
> > On úterý 2. května 2017 15:22:23 CEST Elvis Angelaccio wrote:
> > > On Tue, May 2, 2017 at 3:09 PM, Jan Grulich  wrote:
> > > > On úterý 2. května 2017 14:19:04 CEST Elvis Angelaccio wrote:
> > > >> On Tue, May 2, 2017 at 12:36 PM, Jan Grulich 
> 
> wrote:
> > > >> > On úterý 2. května 2017 12:21:31 CEST Aleix Pol wrote:
> > > >> >> On Tue, May 2, 2017 at 12:15 PM, Albert Astals Cid 
> > 
> > wrote:
> > > >> >> > El dimarts, 2 de maig de 2017, a les 7:22:04 CEST, Jan Grulich
> > > >> >> > va
> > > >> > 
> > > >> > escriure:
> > > >> >> >> On pondělí 1. května 2017 22:59:44 CEST Albert Astals Cid wrote:
> > > >> >> >> > El divendres, 21 d’abril de 2017, a les 8:10:36 CEST, Jan
> > > >> >> >> > Grulich
> > > >> >> >> > va
> > > >> >> >> 
> > > >> >> >> escriure:
> > > >> >> >> > > Hi,
> > > >> >> >> > > 
> > > >> >> >> > > I would like to request review of xdg-desktop-portal-kde
> > > >> >> >> > > [1].
> > > >> >> >> > > We
> > > >> >> >> > > would
> > > >> >> >> > > like
> > > >> >> >> > > to make it part of Plasma releases, see [2].
> > > >> >> >> > > 
> > > >> >> >> > > What is xdg-desktop-portal-kde:
> > > >> >> >> > > It's a KDE implementation of Flatpak portals backend [3],
> > > >> >> >> > > currently
> > > >> >> >> > > with
> > > >> >> >> > > support of AppChooser, FileChooser, Notification and Print
> > > >> >> >> > > portals.
> > > >> >> >> > > 
> > > >> >> >> > > One mentioned issue on plasma-devel mailing list was usage
> > > >> >> >> > > of
> > > >> >> >> > > Qt's
> > > >> >> >> > > private
> > > >> >> >> > > print API. This will most likely go away if I find out it's
> > > >> >> >> > > useless,
> > > >> >> >> > > otherwise I'll have to keep it as it's used to set CUPS
> > > >> >> >> > > properties
> > > >> >> >> > > which
> > > >> >> >> > > are not available to the outside world.
> > > >> 
> > > >> Hi, doesn't seem to work here. If I click Open in your test app I
> > > >> get:
> > > >> 
> > > >> qt.qpa.qflatpakplatform.FileDialog: File dialog: selectedNameFilter()
> > > >> qt.qpa.qflatpakplatform.FileDialog: File dialog: selectedFiles()
> > > >> qt.qpa.qflatpakplatform.FileDialog: File dialog: show()
> > > >> qt.qpa.qflatpakplatform.FileDialog: File dialog: initializeDialog()
> > > >> qt.qpa.qflatpakplatform.FileDialog: Initial values:
> > > >> qt.qpa.qflatpakplatform.FileDialog:Multiple files:  true
> > > >> qt.qpa.qflatpakplatform.FileDialog:  Accept label:  "Open
> > > >> (portal)"
> > > >> qt.qpa.qflatpakplatform.FileDialog:   Window title:  "Flatpak
> > > >> test - open dialog"
> > > >> qt.qpa.qflatpakplatform.FileDialog: Save/Open:  Open
> > > >> qt.qpa.qflatpakplatform.FileDialog:  Name filters:  ("plain
> > > >> text document (*.txt *.asc *,v *.doc)", "PNG image (*.png)")
> > > >> qt.qpa.qflatpakplatform.FileDialog: MimeTypes filters:
> > > >> ("text/plain", "image/png")
> > > >> qt.qpa.qflatpakplatform.FileDialog: Initial directory:
> > > >> "file:///home/elvis" qt.qpa.qflatpakplatform.FileDialog: File dialog:
> > > >> exec()
> > > >> qt.qpa.qflatpakplatform.FileDialog: Couldn't get reply
> > > >> qt.qpa.qflatpakplatform.FileDialog: Error:  "Did not receive a reply.
> > > >> Possible causes include: the remote application did not send a reply,
> > > >> the message bus security policy blocked the reply, the reply timeout
> > > >> expired, or the network connection was broken."
> > > >> 
> > > >> but I don't see any file dialog (the app just freezes). Not sure if
> > > >> related, but I also have xdg-desktop-portal-gtk installed.
> > > > 
> > > > Do you have xdg-desktop-portal installed?
> > > 
> > > Yes.
> > 
> > Make sure that xdg-desktop-portal is running, it should be started
> > automatically by flatpak, but you never know.
> 
> How do I check it? Is it a process that I should see?
> 
> > Also try to run xdg-desktop-
> > portal-kde with debug enabled using:
> > QT_LOGGING_RULES=xdg-desktop-portal-kde*.debug=true /path/to/xdg-desktop-
> > portal-kde.
> 
> This just prints "Desktop portal registered successfuly", which I guess is
> ok.
> 
> As soon as the test app freezes (instead of opening the file dialog), I get
> this in my journalctl: https://paste.kde.org/phcnn4uxn
> 

I guess you have to make sure that xdg-desktop-portal-kde is installed to 
correct location. I have 
it in:
- /usr/share/dbus-1/services/org.freedesktop.impl.portal.desktop.kde.service - 
/usr/share/xdg-
desktop-portal/portals/kde.portal - /usr/libexec/xdg-desktop-portal-kde


I guess based on the log that the dbus service is important to have in correct 
place.

> > > >> Another thing, shouldn't we renamed it to xdg-desktop-portal-plasma?
> > > >> (at least the repository/package, which is what the end user is going
> > > >> to install).
> > > > 
> > > > Not sure, gnome folks use 

Re: Application usage statistics and targeted user surveys

[Volker Krause]

Thanks for the review!

On Tuesday, 2 May 2017 00:07:43 CEST Albert Astals Cid wrote:
> El diumenge, 23 d’abril de 2017, a les 12:52:57 CEST, Volker Krause va
> > Wanting this for GammaRay I attempted to implement a generic framework for
> > this, with the goal to make this fully transparent, and give the user full
> > control over what data is shared, and how often they want to participate
> > in
> > surveys, ie. make this solid enough on the privacy side that even I would
> > enable it myself. You'll find the code in Git (kde:kuserfeedback).
> 
> Why the weird values in StatisticsCollectionMode ?

Extensibility, so we can add more modes later if needed, while still keeping 
the order based on how much data is submitted.

> Should submissionInterval and encouragementInterval also be a property in
> Provider?

I only added properties needed for a QML configuration user interface so far, 
but if someone wants to do the entire setup in QML it probably makes sense to 
expose the entire API indeed.

(What data you want to share (statisticsCollectionMode) and how often you want 
to be bothered by surveys (surveyInterval) are the only two values meant for 
user configuration, the rest is supposed to be configured by the application 
developer.)

> Also would be nice to specify the default values for submissionInterval,
> encouragementInterval, surveyInterval

done

> Do I gather correctly thta as an app developer the only things I'm actually
> interested in are Provider and FeedbackConfigWidget/Dialog? Would be nice to
> have some docu saying so

Those are the main integration points, yes. You'll also need to add data 
sources for Provider to actually report telemetry though, either a built-in 
one, or implementing a custom one based on AbstractDataSource.

Added a high-level integration overview to Mainpage.dox.

> > Feature-wise it so far contains:
> > - a set of built-in data sources (app version, Qt version, platform,
> > application usage time, screen setup, etc) that applications can choose to
> > enable
> > - generic data sources for tracking the time ratio a Q_PROPERTY has a
> > specific value, allowing to track e.g. which application view is used how
> > much - the ability to add custom/application-specific data sources
> > - reference widgets for customizing what data you want to share, and
> > showing exactly what that means, in human readable translated text and if
> > you insists also all the way down to the raw JSON sent to the server.
> > - survey targeting using simple C++/JS-like expressions that can access
> > all
> > the data sources (ie. you can target e.g. only users with high DPI multi-
> > screen setups)
> > - configurable encouragement of users to contribute (ie. after X starts
> > and/or Y hours of usage, repeated after Z months, suggest the user to
> > participate if they aren't already doing so).
> > - a management and analytic tool that allows you to manage products and
> > survey campaigns, and view recorded data using configurable aggregations
> > - the entire thing works without unique user ids. Fingerprinting can still
> > be an issue on too small user sets and/or when using too much detail in
> > the
> > data. - by default all of this is opt-in of course, although technically
> > the API doesn't prevent applications to change this
> > - it can deal with multiple products, each product can have different data
> > sources and survey campaigns
> 
> Haven't read much of the code yet, so I'll ask some stuff.
> 
> Is there a way for the user to see (locally) the data he has sent to the
> servers?

The default configuration dialog shows you a list of what would be sent at the 
time of looking at it, but there is no local logging of the submitted data at 
this point.

> Is there a way for the user to remove the data he has sent to the servers?
> Guess not since otherwise we would be able to do a 1:1 mapping

No. But it's not impossible to achieve I think, without giving up the "no 
unique user identification" requirement. The server could generate a unique 
random key for each submitted record and send that back to the client. The 
client would store these and if desired can request deletion for the 
corresponding records.

Both good points, how important do you think they are for acceptance of this?

> Do we have some way in the server to protect us from people trying to inject
> "fake/wrong" data?

No. And that could indeed be a problem. We can do some sanity checking, but if 
someone insists on vandalizing this you can easily make this entirely useless 
by submitting tons of plausible/"valid" data. You can block IP addresses/
ranges on the web server level, but that is rather crude and manual, but 
that's as far as my ideas on dealing with this go unfortunately.

> I see you protected the data on the server with a user/password.

It's protecting both read access on the data and write access on product 
configuration and survey campaigns, yes. It would probably make sense to 
separate 

Re: kdereview - xdg-desktop-portal-kde

[Elvis Angelaccio]

On Tue, May 2, 2017 at 3:09 PM, Jan Grulich  wrote:
> On úterý 2. května 2017 14:19:04 CEST Elvis Angelaccio wrote:
>> On Tue, May 2, 2017 at 12:36 PM, Jan Grulich  wrote:
>> > On úterý 2. května 2017 12:21:31 CEST Aleix Pol wrote:
>> >> On Tue, May 2, 2017 at 12:15 PM, Albert Astals Cid  wrote:
>> >> > El dimarts, 2 de maig de 2017, a les 7:22:04 CEST, Jan Grulich va
>> >
>> > escriure:
>> >> >> On pondělí 1. května 2017 22:59:44 CEST Albert Astals Cid wrote:
>> >> >> > El divendres, 21 d’abril de 2017, a les 8:10:36 CEST, Jan Grulich va
>> >> >>
>> >> >> escriure:
>> >> >> > > Hi,
>> >> >> > >
>> >> >> > > I would like to request review of xdg-desktop-portal-kde [1]. We
>> >> >> > > would
>> >> >> > > like
>> >> >> > > to make it part of Plasma releases, see [2].
>> >> >> > >
>> >> >> > > What is xdg-desktop-portal-kde:
>> >> >> > > It's a KDE implementation of Flatpak portals backend [3],
>> >> >> > > currently
>> >> >> > > with
>> >> >> > > support of AppChooser, FileChooser, Notification and Print
>> >> >> > > portals.
>> >> >> > >
>> >> >> > > One mentioned issue on plasma-devel mailing list was usage of Qt's
>> >> >> > > private
>> >> >> > > print API. This will most likely go away if I find out it's
>> >> >> > > useless,
>> >> >> > > otherwise I'll have to keep it as it's used to set CUPS properties
>> >> >> > > which
>> >> >> > > are not available to the outside world.
>>
>> Hi, doesn't seem to work here. If I click Open in your test app I get:
>>
>> qt.qpa.qflatpakplatform.FileDialog: File dialog: selectedNameFilter()
>> qt.qpa.qflatpakplatform.FileDialog: File dialog: selectedFiles()
>> qt.qpa.qflatpakplatform.FileDialog: File dialog: show()
>> qt.qpa.qflatpakplatform.FileDialog: File dialog: initializeDialog()
>> qt.qpa.qflatpakplatform.FileDialog: Initial values:
>> qt.qpa.qflatpakplatform.FileDialog:Multiple files:  true
>> qt.qpa.qflatpakplatform.FileDialog:  Accept label:  "Open (portal)"
>> qt.qpa.qflatpakplatform.FileDialog:   Window title:  "Flatpak
>> test - open dialog"
>> qt.qpa.qflatpakplatform.FileDialog: Save/Open:  Open
>> qt.qpa.qflatpakplatform.FileDialog:  Name filters:  ("plain
>> text document (*.txt *.asc *,v *.doc)", "PNG image (*.png)")
>> qt.qpa.qflatpakplatform.FileDialog: MimeTypes filters:
>> ("text/plain", "image/png")
>> qt.qpa.qflatpakplatform.FileDialog: Initial directory:
>> "file:///home/elvis" qt.qpa.qflatpakplatform.FileDialog: File dialog:
>> exec()
>> qt.qpa.qflatpakplatform.FileDialog: Couldn't get reply
>> qt.qpa.qflatpakplatform.FileDialog: Error:  "Did not receive a reply.
>> Possible causes include: the remote application did not send a reply,
>> the message bus security policy blocked the reply, the reply timeout
>> expired, or the network connection was broken."
>>
>> but I don't see any file dialog (the app just freezes). Not sure if
>> related, but I also have xdg-desktop-portal-gtk installed.
>
> Do you have xdg-desktop-portal installed?

Yes.

>
>> Another thing, shouldn't we renamed it to xdg-desktop-portal-plasma?
>> (at least the repository/package, which is what the end user is going
>> to install).
>
> Not sure, gnome folks use xdg-desktop-portal-gtk because it's only gtk related
> and not tied to Gnome, but we use both Qt and KDE Frameworks so I decided to
> go for xdg-desktop-portal-kde, there is nothing really Plasma specific.

The point is to integrate flatpak Qt applications with Plasma, no?
(plasma file picker, plasma notifications, etc.)
Or I can use this portal also to integrate a Qt application with, say, LXQt?

>
> Jan

Elvis

Re: kdereview - xdg-desktop-portal-kde

[Elvis Angelaccio]

On Tue, May 2, 2017 at 12:36 PM, Jan Grulich  wrote:
> On úterý 2. května 2017 12:21:31 CEST Aleix Pol wrote:
>> On Tue, May 2, 2017 at 12:15 PM, Albert Astals Cid  wrote:
>> > El dimarts, 2 de maig de 2017, a les 7:22:04 CEST, Jan Grulich va
> escriure:
>> >> On pondělí 1. května 2017 22:59:44 CEST Albert Astals Cid wrote:
>> >> > El divendres, 21 d’abril de 2017, a les 8:10:36 CEST, Jan Grulich va
>> >>
>> >> escriure:
>> >> > > Hi,
>> >> > >
>> >> > > I would like to request review of xdg-desktop-portal-kde [1]. We
>> >> > > would
>> >> > > like
>> >> > > to make it part of Plasma releases, see [2].
>> >> > >
>> >> > > What is xdg-desktop-portal-kde:
>> >> > > It's a KDE implementation of Flatpak portals backend [3], currently
>> >> > > with
>> >> > > support of AppChooser, FileChooser, Notification and Print portals.
>> >> > >
>> >> > > One mentioned issue on plasma-devel mailing list was usage of Qt's
>> >> > > private
>> >> > > print API. This will most likely go away if I find out it's useless,
>> >> > > otherwise I'll have to keep it as it's used to set CUPS properties
>> >> > > which
>> >> > > are not available to the outside world.

Hi, doesn't seem to work here. If I click Open in your test app I get:

qt.qpa.qflatpakplatform.FileDialog: File dialog: selectedNameFilter()
qt.qpa.qflatpakplatform.FileDialog: File dialog: selectedFiles()
qt.qpa.qflatpakplatform.FileDialog: File dialog: show()
qt.qpa.qflatpakplatform.FileDialog: File dialog: initializeDialog()
qt.qpa.qflatpakplatform.FileDialog: Initial values:
qt.qpa.qflatpakplatform.FileDialog:Multiple files:  true
qt.qpa.qflatpakplatform.FileDialog:  Accept label:  "Open (portal)"
qt.qpa.qflatpakplatform.FileDialog:   Window title:  "Flatpak
test - open dialog"
qt.qpa.qflatpakplatform.FileDialog: Save/Open:  Open
qt.qpa.qflatpakplatform.FileDialog:  Name filters:  ("plain
text document (*.txt *.asc *,v *.doc)", "PNG image (*.png)")
qt.qpa.qflatpakplatform.FileDialog: MimeTypes filters:
("text/plain", "image/png")
qt.qpa.qflatpakplatform.FileDialog: Initial directory:  "file:///home/elvis"
qt.qpa.qflatpakplatform.FileDialog: File dialog: exec()
qt.qpa.qflatpakplatform.FileDialog: Couldn't get reply
qt.qpa.qflatpakplatform.FileDialog: Error:  "Did not receive a reply.
Possible causes include: the remote application did not send a reply,
the message bus security policy blocked the reply, the reply timeout
expired, or the network connection was broken."

but I don't see any file dialog (the app just freezes). Not sure if
related, but I also have xdg-desktop-portal-gtk installed.

Another thing, shouldn't we renamed it to xdg-desktop-portal-plasma?
(at least the repository/package, which is what the end user is going
to install).

>
> Jan

Cheers,
Elvis

Re: kdereview - xdg-desktop-portal-kde

[Jan Grulich]

On úterý 2. května 2017 14:19:04 CEST Elvis Angelaccio wrote:
> On Tue, May 2, 2017 at 12:36 PM, Jan Grulich  wrote:
> > On úterý 2. května 2017 12:21:31 CEST Aleix Pol wrote:
> >> On Tue, May 2, 2017 at 12:15 PM, Albert Astals Cid  wrote:
> >> > El dimarts, 2 de maig de 2017, a les 7:22:04 CEST, Jan Grulich va
> > 
> > escriure:
> >> >> On pondělí 1. května 2017 22:59:44 CEST Albert Astals Cid wrote:
> >> >> > El divendres, 21 d’abril de 2017, a les 8:10:36 CEST, Jan Grulich va
> >> >> 
> >> >> escriure:
> >> >> > > Hi,
> >> >> > > 
> >> >> > > I would like to request review of xdg-desktop-portal-kde [1]. We
> >> >> > > would
> >> >> > > like
> >> >> > > to make it part of Plasma releases, see [2].
> >> >> > > 
> >> >> > > What is xdg-desktop-portal-kde:
> >> >> > > It's a KDE implementation of Flatpak portals backend [3],
> >> >> > > currently
> >> >> > > with
> >> >> > > support of AppChooser, FileChooser, Notification and Print
> >> >> > > portals.
> >> >> > > 
> >> >> > > One mentioned issue on plasma-devel mailing list was usage of Qt's
> >> >> > > private
> >> >> > > print API. This will most likely go away if I find out it's
> >> >> > > useless,
> >> >> > > otherwise I'll have to keep it as it's used to set CUPS properties
> >> >> > > which
> >> >> > > are not available to the outside world.
> 
> Hi, doesn't seem to work here. If I click Open in your test app I get:
> 
> qt.qpa.qflatpakplatform.FileDialog: File dialog: selectedNameFilter()
> qt.qpa.qflatpakplatform.FileDialog: File dialog: selectedFiles()
> qt.qpa.qflatpakplatform.FileDialog: File dialog: show()
> qt.qpa.qflatpakplatform.FileDialog: File dialog: initializeDialog()
> qt.qpa.qflatpakplatform.FileDialog: Initial values:
> qt.qpa.qflatpakplatform.FileDialog:Multiple files:  true
> qt.qpa.qflatpakplatform.FileDialog:  Accept label:  "Open (portal)"
> qt.qpa.qflatpakplatform.FileDialog:   Window title:  "Flatpak
> test - open dialog"
> qt.qpa.qflatpakplatform.FileDialog: Save/Open:  Open
> qt.qpa.qflatpakplatform.FileDialog:  Name filters:  ("plain
> text document (*.txt *.asc *,v *.doc)", "PNG image (*.png)")
> qt.qpa.qflatpakplatform.FileDialog: MimeTypes filters:
> ("text/plain", "image/png")
> qt.qpa.qflatpakplatform.FileDialog: Initial directory: 
> "file:///home/elvis" qt.qpa.qflatpakplatform.FileDialog: File dialog:
> exec()
> qt.qpa.qflatpakplatform.FileDialog: Couldn't get reply
> qt.qpa.qflatpakplatform.FileDialog: Error:  "Did not receive a reply.
> Possible causes include: the remote application did not send a reply,
> the message bus security policy blocked the reply, the reply timeout
> expired, or the network connection was broken."
> 
> but I don't see any file dialog (the app just freezes). Not sure if
> related, but I also have xdg-desktop-portal-gtk installed.

Do you have xdg-desktop-portal installed?
 
> Another thing, shouldn't we renamed it to xdg-desktop-portal-plasma?
> (at least the repository/package, which is what the end user is going
> to install).

Not sure, gnome folks use xdg-desktop-portal-gtk because it's only gtk related 
and not tied to Gnome, but we use both Qt and KDE Frameworks so I decided to 
go for xdg-desktop-portal-kde, there is nothing really Plasma specific.

Jan

Re: kdereview - xdg-desktop-portal-kde

[Jan Grulich]

On úterý 2. května 2017 12:21:31 CEST Aleix Pol wrote:
> On Tue, May 2, 2017 at 12:15 PM, Albert Astals Cid  wrote:
> > El dimarts, 2 de maig de 2017, a les 7:22:04 CEST, Jan Grulich va 
escriure:
> >> On pondělí 1. května 2017 22:59:44 CEST Albert Astals Cid wrote:
> >> > El divendres, 21 d’abril de 2017, a les 8:10:36 CEST, Jan Grulich va
> >> 
> >> escriure:
> >> > > Hi,
> >> > > 
> >> > > I would like to request review of xdg-desktop-portal-kde [1]. We
> >> > > would
> >> > > like
> >> > > to make it part of Plasma releases, see [2].
> >> > > 
> >> > > What is xdg-desktop-portal-kde:
> >> > > It's a KDE implementation of Flatpak portals backend [3], currently
> >> > > with
> >> > > support of AppChooser, FileChooser, Notification and Print portals.
> >> > > 
> >> > > One mentioned issue on plasma-devel mailing list was usage of Qt's
> >> > > private
> >> > > print API. This will most likely go away if I find out it's useless,
> >> > > otherwise I'll have to keep it as it's used to set CUPS properties
> >> > > which
> >> > > are not available to the outside world.
> >> > 
> >> > Since you have copied some code from Okular maybe you can add some
> >> > other
> >> > (C) there other than RedHat's?
> >> 
> >> Added.
> >> 
> >> > What about the unusued QVariantMap  in the print.cpp file? What
> >> > are
> >> > you supposed to return there?
> >> 
> >> Seems not to be used at this moment or the portal frontend doesn't expect
> >> something to be returned with "results". I guess it's just reserved for
> >> future usage, given how complex the print API is.
> >> 
> >> > I've no idea how to use this so can't really test it :/
> >> 
> >> You can test it with this [1]. You just go to flapak-build folder and run
> >> build.sh which will generate you a flatpak repo, you add it and install
> >> using flatpak, but you also need to have xdg-desktop-portal installed.
> > 
> > Got stuck trying to figure out what to install from that local flatpak
> > repo
> > 
> > $ flatpak remote-ls mylocalrepo
> > error: GPG verification enabled, but no summary signatures found (use gpg-
> > verify-summary=false in remote config to disable)
> > 
> > And couldn't figure out how to do that, seems like the hint is only half
> > there> 
> > :D
> 
> Hi,
> Here it's explained how to use a local repo:
> https://community.kde.org/Guidelines_and_HOWTOs/Flatpak#Compile_your_applica
> tion
> 
> The catch is --no-gpg-verify.

And I think you also have to use "--user" because system-wide repositories 
actually need to be installed with gpg-verification or at least later when you 
want to use them.

Jan

Re: kdereview - xdg-desktop-portal-kde

[Aleix Pol]

On Tue, May 2, 2017 at 12:15 PM, Albert Astals Cid  wrote:
> El dimarts, 2 de maig de 2017, a les 7:22:04 CEST, Jan Grulich va escriure:
>> On pondělí 1. května 2017 22:59:44 CEST Albert Astals Cid wrote:
>> > El divendres, 21 d’abril de 2017, a les 8:10:36 CEST, Jan Grulich va
>>
>> escriure:
>> > > Hi,
>> > >
>> > > I would like to request review of xdg-desktop-portal-kde [1]. We would
>> > > like
>> > > to make it part of Plasma releases, see [2].
>> > >
>> > > What is xdg-desktop-portal-kde:
>> > > It's a KDE implementation of Flatpak portals backend [3], currently with
>> > > support of AppChooser, FileChooser, Notification and Print portals.
>> > >
>> > > One mentioned issue on plasma-devel mailing list was usage of Qt's
>> > > private
>> > > print API. This will most likely go away if I find out it's useless,
>> > > otherwise I'll have to keep it as it's used to set CUPS properties which
>> > > are not available to the outside world.
>> >
>> > Since you have copied some code from Okular maybe you can add some other
>> > (C) there other than RedHat's?
>>
>> Added.
>>
>> > What about the unusued QVariantMap  in the print.cpp file? What
>> > are
>> > you supposed to return there?
>>
>> Seems not to be used at this moment or the portal frontend doesn't expect
>> something to be returned with "results". I guess it's just reserved for
>> future usage, given how complex the print API is.
>>
>> > I've no idea how to use this so can't really test it :/
>>
>> You can test it with this [1]. You just go to flapak-build folder and run
>> build.sh which will generate you a flatpak repo, you add it and install
>> using flatpak, but you also need to have xdg-desktop-portal installed.
>
> Got stuck trying to figure out what to install from that local flatpak repo
>
> $ flatpak remote-ls mylocalrepo
> error: GPG verification enabled, but no summary signatures found (use gpg-
> verify-summary=false in remote config to disable)
>
> And couldn't figure out how to do that, seems like the hint is only half there
> :D

Hi,
Here it's explained how to use a local repo:
https://community.kde.org/Guidelines_and_HOWTOs/Flatpak#Compile_your_application

The catch is --no-gpg-verify.

Aleix

Re: kdereview - xdg-desktop-portal-kde

[Albert Astals Cid]

El dimarts, 2 de maig de 2017, a les 7:22:04 CEST, Jan Grulich va escriure:
> On pondělí 1. května 2017 22:59:44 CEST Albert Astals Cid wrote:
> > El divendres, 21 d’abril de 2017, a les 8:10:36 CEST, Jan Grulich va
> 
> escriure:
> > > Hi,
> > > 
> > > I would like to request review of xdg-desktop-portal-kde [1]. We would
> > > like
> > > to make it part of Plasma releases, see [2].
> > > 
> > > What is xdg-desktop-portal-kde:
> > > It's a KDE implementation of Flatpak portals backend [3], currently with
> > > support of AppChooser, FileChooser, Notification and Print portals.
> > > 
> > > One mentioned issue on plasma-devel mailing list was usage of Qt's
> > > private
> > > print API. This will most likely go away if I find out it's useless,
> > > otherwise I'll have to keep it as it's used to set CUPS properties which
> > > are not available to the outside world.
> > 
> > Since you have copied some code from Okular maybe you can add some other
> > (C) there other than RedHat's?
> 
> Added.
> 
> > What about the unusued QVariantMap  in the print.cpp file? What
> > are
> > you supposed to return there?
> 
> Seems not to be used at this moment or the portal frontend doesn't expect
> something to be returned with "results". I guess it's just reserved for
> future usage, given how complex the print API is.
> 
> > I've no idea how to use this so can't really test it :/
> 
> You can test it with this [1]. You just go to flapak-build folder and run
> build.sh which will generate you a flatpak repo, you add it and install
> using flatpak, but you also need to have xdg-desktop-portal installed.

Got stuck trying to figure out what to install from that local flatpak repo

$ flatpak remote-ls mylocalrepo
error: GPG verification enabled, but no summary signatures found (use gpg-
verify-summary=false in remote config to disable)

And couldn't figure out how to do that, seems like the hint is only half there 
:D

Cheers,
  Albert

> 
> [1] - https://github.com/grulja/flatpak-portal-test-kde
> 
> Regards,
> Jan