Re: Zanshin is in kdereview

2017-06-20 Thread Kevin Ottens
Hello,

On Monday, 19 June 2017 21:50:16 CEST Luigi Toscano wrote:
> Kevin Ottens ha scritto:
> > On Monday, 19 June 2017 18:56:39 CEST Luigi Toscano wrote:
> >> On Monday, 19 June 2017 18:50:23 CEST Kevin Ottens wrote:
> >>> On Tuesday, 13 June 2017 00:07:01 CEST Albert Astals Cid wrote:
>  Have you read the page that speaks about how to write Messages.sh
>  files?
>  It's quite good. Please read it and explain what you don't understand.
> >>> 
> >>> It's more that I don't quite see clearly the distribution of the .po and
> >>> such after the Message.sh is run.
> >>> 
> >>> That being said, wouldn't that be more natural to either extend
> >>> extractrc
> >>> to spit out mock QObject::tr() calls? Or to have the Message.sh run perl
> >>> on the file?
> >>> 
> >>> Sounds cleaner to me than having several catalogs loaded for an
> >>> otherwise
> >>> self-contained application.
> >> 
> >> I haven't checked the code, but the idea is that:
> >> - messages handled by Qt translation system should end up in the
> >> _qt file;
> >> - messages from KI18n should end up in a file or a set of files named as
> >> you want (you just need to set the proper domain which matches the file
> >> name).
> >> 
> >> So please try to follow these guidelines. If the application already uses
> >> KI18n directly or indirectly, I would just use it for everything.
> > 
> > I find unfortunate we actively discourage being able to work without ki18n
> > in such case. But OK, got better things to do I'll stop fighting this
> > one.
> We are not discouraging anyone.

Technically we do, too many hoops to go through. I didn't mean *you* were 
discouraging me, I'm just saying that the fact that I have kparts in the mix 
makes it somewhat harder.

> You can definitely work without KI18n, or mixing Qt-only modules with
> KI18n-managed modules. Marble and Step are two example of this, and this is
> not because we like it or not but there are specific technical reasons for
> it.

Sure, I guess we'd be more similar to the Marble case.

> In this case, every module which links to kparts should use KI18n, but you
> can have pure Qt libraries (even static) which uses ::tr. And of course you
> need two translations files.
> 
> I'm not sure why you didn't like the above solution.

Just more work over time, and I don't have the bandwidth ATM. Typically we 
tend to assume ki18n and a single catalog as the common case (and rightly so), 
so does releaseme assume that too? And then I have to think about both files 
for shipping, etc.

I just don't have the energy to think all that through so I'd rather go the 
lazy and easy path with the patch I did.

> Now, can we properly discuss this? I don't want people coming back and
> saying that a solution was forced for $reasons when it was not forced at
> all.
> (that said, KI18n is better, but again you don't need to use it).
> 
> > This one switches it all to i18n: https://phabricator.kde.org/D6283
> 
> I'm going to put a -1 until we discuss this properly.

Hope the above clarifies my reasons a bit.

In a nutshell: tr() was used for an hypothetical mobile port, this port is 
still not in sight with the bandwidth I currently have and tr() is creating me 
troubles mainly due to the kparts plugins; so either I drop said plugins or I 
switch to i18n to be like everyone else. I'm going for being like everyone 
else.

It can always be revisited later if there's really a mobile port or such 
emerging.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.


Re: Zanshin is in kdereview

2017-06-20 Thread Kevin Ottens
Hello,

On Monday, 19 June 2017 23:11:09 CEST Albert Astals Cid wrote:
> That makes no sense, the kxmlgui code will call i18n(), so you need to have
> it in a .mo file not on a .ts file.

Fair enough, I abandoned that patch, did another one to switch to i18n 
everywhere instead: https://phabricator.kde.org/D6283

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.


Re: Zanshin is in kdereview

2017-06-20 Thread Kevin Ottens
Hello,

On Monday, 19 June 2017 21:49:26 CEST Jonathan Riddell wrote:
> On Mon, Jun 19, 2017 at 09:36:39PM +0200, Kevin Ottens wrote:
> > Looks like I just didn't clone at the right time.
> > 
> > That said, there's something fishy with the signature:
> > https://paste.kde.org/pgh6b1em7
> 
> releaseme doesn't do anything special with gpg, it just runs
>  gpg2 --armor --detach-sign -o #{sigfile} #{file}
> 
> So does gpg2 work for you signing a text file?

Yep it does and the signature is valid... it's just that it somehow returns 
with an exit code of 2 here and not 0. Really odd...
 
Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.


Re: kdereview - qtcurve

2017-06-20 Thread David Edmundson
> What do you need kdelibs4support for in the qt5 code?

Nothing that couldn't be ported long term, but it does currently use
KMimeData, KStandardDirs and KFileDialog.


Re: Ksysguard dev

2017-06-20 Thread Christoph Feck

On 19.06.2017 20:50, Alexandre Biche wrote:

I want to add network I/O stats to ksysguard but I you closed
kde-workspace's github repo and I don't find the plasma 5 github repo.
Can you give me the way to start contributing please


Our repositories are at https://cgit.kde.org/

KSysGuard is splitted between 'ksysguard' and 'libksysguard'.
It does not have a maintainer, so if you use phabricator for patches, 
please add the Plasma group as reviewers.


Re: Ksysguard dev

2017-06-20 Thread Luigi Toscano
On Monday, 19 June 2017 20:50:25 CEST Alexandre Biche wrote:
> Hi guys,
> I want to add network I/O stats to ksysguard but I you closed
> kde-workspace's github repo and I don't find the plasma 5 github repo.
> Can you give me the way to start contributing please


Github is a mirror; kde-workspace is the kdelibs4 version.

Also (all the page, and "Getting the code"):
https://community.kde.org/Get_Involved/development

-- 
Luigi