Re: Moving AtCore to Extragear

[Ben Cooksley]

On Fri, Jun 23, 2017 at 7:56 AM, Luigi Toscano  wrote:
> Albert Astals Cid ha scritto:
>> El diumenge, 18 de juny de 2017, a les 9:48:07 CEST, Lays Rodrigues va
>> escriure:
>>> Hey guys, good morning. =D
>>> Any more comments on AtCore code?
>>> How the moving to Extragear work?
>>
>> Are you planning to at least answer my last comments saying "we don't really
>> care about that level of perfection"? (which is a fair position)
>>
>
> In addition to Albert's comment, I noticed now (still going through the
> backlog after vacation) that atcore use tr() for messages, but there is no
> Messages.sh file to extract the strings (which should be called atcore_qt,
> check the similar files in step or marble or in tier1 frameworks).
>
> Unfortunately the repository was already moved directly to extragear, and I
> expressed already my disagreement about this move with still open questions.

I'm going to be reversing that move, as the repository hasn't cleared review.
Additionally, the commit is technically wrong and was committed while
I had noted objections on the review.

As such i'm placing an indefinite embargo on AtCore and Atelier moving
from KDE Review until I get an explanation of why it was committed
without the corrections I requested.
Should I not get a response within the week, they'll be returned to
playground and will be required to re-transit KDE Review including the
full 2 week process.

Jonathan and Lays, please read the documentation as contained in
sysadmin/repo-metadata before making any further changes to the
repository.

>
> --
> Luigi
>

Regards,
Ben Cooksley
KDE Sysadmin

Re: Moving AtCore to Extragear

[Luigi Toscano]

Albert Astals Cid ha scritto:
> El diumenge, 18 de juny de 2017, a les 9:48:07 CEST, Lays Rodrigues va 
> escriure:
>> Hey guys, good morning. =D
>> Any more comments on AtCore code?
>> How the moving to Extragear work?
> 
> Are you planning to at least answer my last comments saying "we don't really 
> care about that level of perfection"? (which is a fair position)
> 

In addition to Albert's comment, I noticed now (still going through the
backlog after vacation) that atcore use tr() for messages, but there is no
Messages.sh file to extract the strings (which should be called atcore_qt,
check the similar files in step or marble or in tier1 frameworks).

Unfortunately the repository was already moved directly to extragear, and I
expressed already my disagreement about this move with still open questions.

-- 
Luigi

Re: kdereview - qtcurve

[David Edmundson]

On Mon, Jun 19, 2017 at 11:42 PM, Albert Astals Cid  wrote:

> El divendres, 16 de juny de 2017, a les 11:07:19 CEST, Yichao Yu va
> escriure:
> > QtCurve is now in kdereview with the intention of being in extragear/base
>
> By default it assumes i want a Qt4 build and then fails because i don't
> have
> the necessary packages. Maybe it could be a bit gentler and just give me a
> nice warning?
>
>
Possibly fixed. You'll need to wipe your CMakeCache though.

David

Re: Kirigami in Frameworks

[Marco Martin]

On Wed, Jun 21, 2017 at 6:22 PM, Jonathan Riddell  wrote:
> On 21 June 2017 at 15:00, Marco Martin  wrote:
>> As there were no replies for quite a while, i assume there are no
>> particular objections.
>>
>> so, how to proceed? what needs to be doe to do the actual move?
>
> Does it comply with the policies (as much as they are relevant for QML)?
> https://community.kde.org/Frameworks/Policies

yeah, it should for pretty much all rules

> Get David Faure to give his approval then see what the reponse to my
> "who is authorised to move repos around?" thead is.
> https://marc.info/?l=kde-core-devel=149806172721190=2



ok, waiting David's comment on it.

--
Marco Martin

Re: who is authorised to move repos around?

[Ben Cooksley]

On Thu, Jun 22, 2017 at 4:14 AM, Jonathan Riddell  wrote:
> I'm unclear who is authorised to move git repos around, e.g. from
> playground to kdereview to kde-extra
>
> It used to be only sysadmins which seems like a political burden on a tech 
> team.
>
> Now anyone can edit repo-metadata.  So can anyone move repos around as
> long as rules and conventions are followed?
>
> I wonder if it should be a task moved to a team such as the release
> team (but then that's not a well defined team).
>
> I'm asked because I was asked to review atcore being moved around
> https://phabricator.kde.org/D6318

Historically (prior to the transition to Git at least) there were no
technical limitations preventing any developer from moving projects
from Playground to KDE Review to main modules / Extragear (or even
skipping KDE Review as the case may be).

The rules about transitioning to KDE Review and then to the
appropriate main module following successful review are entirely
social.

Assuming the rules and conventions surrounding KDE Review and entry of
projects into modules continues to be followed, I see no reason why we
should change. All changes to the structure are fairly easy to monitor
(simply watch sysadmin/repo-metadata on git.kde.org) and it's overseen
by Sysadmin anyway as all changes to that repository are announced on
#kde-sysadmin.

>
> Jonathan

Cheers,
Ben