Re: KMarkdownWebView (kpart) in KDE Review

2017-08-22 Thread Friedrich W. H. Kossebau
Am Dienstag, 22. August 2017, 23:38:06 CEST schrieb Friedrich W. H. Kossebau: > Am Dienstag, 22. August 2017, 22:41:28 CEST schrieb Albert Astals Cid: > > You don't have a Messages.sh > > Thanks for taking a look, though... there is one, in src/: >

Re: KMarkdownWebView (kpart) in KDE Review

2017-08-22 Thread Friedrich W. H. Kossebau
Am Dienstag, 22. August 2017, 23:09:18 CEST schrieb Allen Winter: > One Krazy issue about making an explicit ctor, see > http://ebn.kde.org/krazy/reports/kdereview/kmarkdownwebview/src/index.html Fixed. > I ran clazy too and it found no issues. Happy to read. Thanks for having had a look, Allen

Re: KMarkdownWebView (kpart) in KDE Review

2017-08-22 Thread Friedrich W. H. Kossebau
Am Dienstag, 22. August 2017, 22:41:28 CEST schrieb Albert Astals Cid: > You don't have a Messages.sh Thanks for taking a look, though... there is one, in src/: https://cgit.kde.org/kmarkdownwebview.git/tree/src/Message.sh Placement missing to follow some pattern? For completeness I just pushed

Re: KMarkdownWebView (kpart) in KDE Review

2017-08-22 Thread Allen Winter
One Krazy issue about making an explicit ctor, see http://ebn.kde.org/krazy/reports/kdereview/kmarkdownwebview/src/index.html I ran clazy too and it found no issues. On Monday, August 21, 2017 6:18:19 PM EDT Friedrich W. H. Kossebau wrote: > Hi, > > KMarkdownWebView today entered KDE Review.

Re: KMarkdownWebView (kpart) in KDE Review

2017-08-22 Thread Albert Astals Cid
El dimarts, 22 d’agost de 2017, a les 0:18:19 CEST, Friedrich W. H. Kossebau va escriure: > Hi, > > KMarkdownWebView today entered KDE Review. This repo contains a kpart for > rendered display of Markdown files, using web technologies (webpage with > JavaScript library which creates HTML from