Re: Symmy in kde-review
On Friday, April 12, 2019 10:13:10 AM CEST Jonathan Riddell wrote: > On Sat, 25 Nov 2017 at 13:31, Elvis Angelaccio wrote: > > symmy has been moved to kde-review for the usual review process. > > > > It's a tiny frontend for the symmetric encryption functionality of GPG. It > > doesn't handle signing or public/private keys, as we already have kgpg or > > kleopatra for that. > > > > Symmy can be useful if you have to send some sensitive file to someone, of > > if you want to store it on some proprietary cloud service. I should have piped up earlier: # Compatibility I wonder about Messages.sh. It claims to need bash, but I don't actually see any bash-ism in it. $() command substitution is POSIX-compatible. I haven't looked at tooling to produce manpages from docbook, but good on you for including a manpage. Compiled without meaningful warnings w/ clang 6 (which is often more picky than gcc). # Licensing You might want to add SPDX identifiers to files, but that's icing on the cake. Looks like a consistent GPLv2+ codebase, well-documented. # Runtime Since it's supposed to be a CLI application, you might want to massage the QPA loading a bit, since when I run it (ssh'ed in to my build machine) It does this: [adridg@beastie ~/src/kde/symmy/build]$ ./src/symmy qt.qpa.xcb: could not connect to display qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found. This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem. Available platform plugins are: wayland-org.kde.kwin.qpa, bsdfb, minimal, offscreen, vnc, xcb. Abort trap (core dumped) But overall: well done, welcome to extragear. [ade] signature.asc Description: This is a digitally signed message part.
Re: liquidshell in kdereview
On Fri, Mar 15, 2019 at 7:59 AM Ivan Čukić wrote: > Anyhow, while I do find it strange to market a non-feature in the features > list, I don't have anything against it. I have a bit of a problem about putting doesn't use activities as a feature, because it's a bit confrontational towards other KDE products (and as you point out, often not 100% true as kactivitymanagerd will be very probably started anyways) That said, i don't have problems of having a competing shell as a KDE project, choice is usually good. Marco Martin
Re: liquidshell in kdereview
On Sunday, March 10, 2019 1:25:14 PM CEST Martin Koller wrote: > since some time has already passed and there was no conclusion, I'll try > once again to announce liquidshell. # Documentation issues The features list, both in German and English, lists a bunch of features that distinguish it from, say, twm, not from Plasma. The feature list in English doesn't match the one in German. The English one includes dubious claims such as "instant startup" and "low memory footprint", which I'd still want to see measured and/or demonstrated. Typo's in (English) README. # License issues None, actually. Well done. Consistent use of GPLv3+ everywhere. You might want to add SPDX identifiers, but that would be the icing on the cake. # Source issues Doesn't report nicely at end of CMake (use FeatureSummary). Ancient CMake and Qt versions listed as "minimum" (that's ok, I guess). Unusual source layout and file suffixes (again, I guess it's ok, just weird and being difficult). Poor C++11 hygiene (include guards, conversions, nullptr). # Compatibility issues Fails to document that NetworkManager and BlueZ are required. Uses bash for things that are POSIX shell scripts. Those (two items) above are symptoms of "liquidshell is a shell for Martin Koller and people with exactly his computer setup and workflow". Since the KDE community has traditionally produced general, flexible software, it's weird to have a restricted, limited, non-flexible product as well. [ade] signature.asc Description: This is a digitally signed message part.
Re: Symmy in kde-review
This has now moved into extragear/utils. Jonathan On Sat, 25 Nov 2017 at 13:31, Elvis Angelaccio wrote: > > Hi, > symmy has been moved to kde-review for the usual review process. > > It's a tiny frontend for the symmetric encryption functionality of GPG. It > doesn't handle signing or public/private keys, as we already have kgpg or > kleopatra for that. > > Symmy can be useful if you have to send some sensitive file to someone, of > if you want to store it on some proprietary cloud service. > > It comes with a CLI application and plugins for GUI integration with > Dolphin/Plasma. > > I'd like to move it to either extragear-utils or kde-utils, if everything > looks good. > > Thanks, > Elvis
