Re: Kup in KDE Review

2020-04-06 Thread Albert Astals Cid
El dilluns, 6 d’abril de 2020, a les 12:32:54 CEST, Simon Persson va escriure:
> Hello!
> 
> 
> Please help to review kup.
> 
> It is a backup scheduler tightly integrated with plasma (has system 
> setting kcm, systray plasmoid, kioslave). It supports saving backups 
> either with bup or with rsync.
> 
> It has been developed outside of KDE for many years and only now is 
> being incubated.

When in the kcm i go to add new plan i get the "Versioned backup" disabled 
because bup is not installed *BUT* it is still the selected radio button, i 
guess in that case it would make more sense if the "Synchronized backup" was 
the selected one, no?

kup-filedigger stars off really small here (less than 300x300).

Not critical but it seems like it would benefit for having some 
minimum/recommended size set.

Cheers,
  Albert

> 
> I am unsure if it should end up in extragear or some release service 
> bundle. Perhaps people have an opinion on this?
> 
> https://invent.kde.org/kde/kup
> 
> 
> Thanks,
> 
> Simon
> 
> 






Re: Kup in KDE Review

2020-04-06 Thread Adriaan de Groot
On Monday, 6 April 2020 12:32:54 CEST Simon Persson wrote:
> Please help to review kup.

- It's probably worthwhile looking at REUSE licensing compliance (see 
reuse.software, or ask on IRC #kde-devel) so that the license is machine-
readable and checkable.
- Although you find_package(LibGit2) you were linking "old style" instead of 
using the imported target LibGit2::LibGit2. I pushed a build fix, now it 
builds on FreeBSD as well.


- Uses a handful of deprecated methods; depending on what exactly you want to 
be compatible with, you might chase those.


[ade]




Kup in KDE Review

2020-04-06 Thread Simon Persson

Hello!


Please help to review kup.

It is a backup scheduler tightly integrated with plasma (has system 
setting kcm, systray plasmoid, kioslave). It supports saving backups 
either with bup or with rsync.


It has been developed outside of KDE for many years and only now is 
being incubated.


I am unsure if it should end up in extragear or some release service 
bundle. Perhaps people have an opinion on this?


https://invent.kde.org/kde/kup


Thanks,

Simon



[sysadmin/repo-metadata] projects/kdereview/kup: Move Kup to KDE Review per the request of it's maintainer.

2020-04-06 Thread Ben Cooksley
Git commit cc33a7e893e58ad817b7358cbdfce56b3b93142d by Ben Cooksley.
Committed on 06/04/2020 at 09:30.
Pushed by bcooksley into branch 'master'.

Move Kup to KDE Review per the request of it's maintainer.

Fixes T12928

CCMAIL: kde-core-devel@kde.org

R  +0-0projects/kdereview/kup/i18n.json [from: 
projects/playground/base/kup/i18n.json - 100% similarity]
R  +1-1projects/kdereview/kup/metadata.yaml [from: 
projects/playground/base/kup/metadata.yaml - 085% similarity]

https://commits.kde.org/sysadmin/repo-metadata/cc33a7e893e58ad817b7358cbdfce56b3b93142d

diff --git a/projects/playground/base/kup/i18n.json 
b/projects/kdereview/kup/i18n.json
similarity index 100%
rename from projects/playground/base/kup/i18n.json
rename to projects/kdereview/kup/i18n.json
diff --git a/projects/playground/base/kup/metadata.yaml 
b/projects/kdereview/kup/metadata.yaml
similarity index 85%
rename from projects/playground/base/kup/metadata.yaml
rename to projects/kdereview/kup/metadata.yaml
index 1e85c05..479ffe3 100644
--- a/projects/playground/base/kup/metadata.yaml
+++ b/projects/kdereview/kup/metadata.yaml
@@ -5,7 +5,7 @@ members:
 - displayname: Simon Persson
   username: persson
 name: Kup
-projectpath: playground/base/kup
+projectpath: kdereview/kup
 repoactive: true
 repopath: kup
 type: project


[sysadmin/repo-metadata] projects/kdereview/calindori: Move Calindori to KDE Review per the request of it's maintainer.

2020-04-06 Thread Ben Cooksley
Git commit a638a66a8d676ec40a46e6cb9e18224ce3a50ccb by Ben Cooksley.
Committed on 06/04/2020 at 09:25.
Pushed by bcooksley into branch 'master'.

Move Calindori to KDE Review per the request of it's maintainer.

Fixes T12927

CCMAIL: kde-core-devel@kde.org

R  +0-0projects/kdereview/calindori/i18n.json [from: 
projects/playground/mobile/calindori/i18n.json - 100% similarity]
R  +1-1projects/kdereview/calindori/metadata.yaml [from: 
projects/playground/mobile/calindori/metadata.yaml - 083% similarity]

https://commits.kde.org/sysadmin/repo-metadata/a638a66a8d676ec40a46e6cb9e18224ce3a50ccb

diff --git a/projects/playground/mobile/calindori/i18n.json 
b/projects/kdereview/calindori/i18n.json
similarity index 100%
rename from projects/playground/mobile/calindori/i18n.json
rename to projects/kdereview/calindori/i18n.json
diff --git a/projects/playground/mobile/calindori/metadata.yaml 
b/projects/kdereview/calindori/metadata.yaml
similarity index 83%
rename from projects/playground/mobile/calindori/metadata.yaml
rename to projects/kdereview/calindori/metadata.yaml
index ab307a8..fc88d67 100644
--- a/projects/playground/mobile/calindori/metadata.yaml
+++ b/projects/kdereview/calindori/metadata.yaml
@@ -5,7 +5,7 @@ members:
 - displayname: Dimitris Kardarakos
   username: dkardarakos
 name: Calindori
-projectpath: playground/mobile/calindori
+projectpath: kdereview/calindori
 repoactive: true
 repopath: calindori
 type: project