Re: Git merge workflow: reverse it?

2020-08-02 Thread Aleix Pol
On Sun, Aug 2, 2020 at 2:44 PM Bhushan Shah wrote: > > Hello everyone! > > At plasma, we are experimenting with new workflow regarding how bugfixes > are put on the stable branch [1]. > > # Previous workflow > > - Current workflow is that we commit to stable branch and then merge it > upwords un

Re: KDEReview for Kontrast

2020-08-02 Thread Albert Astals Cid
El dijous, 30 de juliol de 2020, a les 11:16:25 CEST, Carl Schwan va escriure: > Hi, > I would like to move Kontrast, a contrast checker application, to KDEReview > Kontrast can check if two colors pass the WCAG 2.0 specification and save > some user's favorite color combinations. > > Some scree

Re: KDEReview for Kontrast

2020-08-02 Thread Nicolas Fella
Hi Carl, a couple of nitpicks, otherwise looks neat. - your CMakeLists.txt does not specify a minimum Qt/KF5 version. Also ECM 0.0.8 is likely quite old and a bit optimistic - Setting CMAKE_CXX_STANDARD to 11 is implicitly done by ECM, no need to do that manually. It also contradicts the target

Re: KDEReview for Kontrast

2020-08-02 Thread Nate Graham
Hello Carl, This looks very useful! Overall I'd say the UI is good. One thing I find myself missing while playing around is the ability to test system colorschemes though. That would be a really nice addition. Nate On 7/30/20 3:16 AM, Carl Schwan wrote: Hi, I would like to move Kontrast, a

KDEReview for Kontrast

2020-08-02 Thread Carl Schwan
Hi, I would like to move Kontrast, a contrast checker application, to KDEReview. Kontrast can check if two colors pass the WCAG 2.0 specification and save some user's favorite color combinations. Some screenshots of the application and a design review from the VSG is available here: https://inv

Git merge workflow: reverse it?

2020-08-02 Thread Bhushan Shah
Hello everyone! At plasma, we are experimenting with new workflow regarding how bugfixes are put on the stable branch [1]. # Previous workflow - Current workflow is that we commit to stable branch and then merge it upwords until master branch - i.e commit to Plasma/5.18 branch, merge 5.18 into