Re: Please review KUserFeedback support in Dolphin

2020-11-04 Thread Elvis Angelaccio

Thanks Nicolas and Christoph for your feedback.

I'll be pushing the MR tomorrow before the 20.12 dependency freeze, 
unless there are objections.


On 29/10/20 22:05, Christoph Cullmann wrote:

On 2020-10-29 21:46, Elvis Angelaccio wrote:

Hi everyone,

I was planning to add KUserFeedback in Dolphin for the upcoming 20.12
release, but then I realized that our telemetry policy [1] says we
should go through a public review on kde-core-devel first.

So here I am, this is the MR:
https://invent.kde.org/system/dolphin/-/merge_requests/45

Please have a look.

Dependency freeze for 20.12 is on November 5th, so in one week. I'd
appreciate some feedback before that.

Thanks :)


Hi,

could we make KUserFeedback a framework then, to ensure we have some
proper released and updated foundation, if we use that in more stuff now?


+1


Cheers,
Elvis



Greetings
Christoph



Cheers,
Elvis

[1]: https://community.kde.org/Policies/Telemetry_Policy#Compliance




Re: plasma-systemmonitor in kdereview

2020-11-04 Thread Arjen Hiemstra
On Thursday, 1 October 2020 14:11:16 CET Harald Sitter wrote:
> 
> Cool stuff.
> 
> L10n is currently a bit incomplete.
> Notably
> - the pages files lack any localization at all and I'm also not sure how
> those could be best localized.

As an update to this, this should be fixed for 5.21. The pages are now treated 
as desktop files and include the translations once things have been extracted.

Since that was as far as I know the last major issue raised during review and 
we did the release yesterday it has now been moved to Plasma proper.

Thank you everyone who reviewed.

- Arjen

> 
> HS