Hi Han,
let's have this discussion public on kde-core-devel and kde-framworks,
so other can contribute.
On Sat, Jan 2, 2021 at 1:29 PM hanyoung wrote:
>
> Hi Dominik,
>
> Thank you for your time. This is my first time writing a library, I tried my
> best by looking
> at existing KDE frameworks
On Samstag, 2. Januar 2021 12:44:31 CET Dominik Haumann wrote:
> This is just by looking at the first two header files.
>
> Looking at WeatherForecast.cpp:
>
> double maxTemp = std::numeric_limits::min();
> double minTemp = std::numeric_limits::max();
>
> Initializing the temperature to
Hi Han,
just having a quick glance at the code, and I feel like there is a lot of
polishing
missing. I'll give some examples, but this is by no means a complete review,
and I'll not comment on technical aspects at all, since this is not the
domain
of my expertise.
- #pragma once: It's used in