Re: Haruna in kdereview

2021-07-21 Thread Jonah BrĂ¼chert
- you should codify the runtime dep on youtube-dl via cmake. make a dummy finder and set_package_properties it as type RUNTIME e.g. https://invent.kde.org/plasma/plasma-disks/-/blob/master/cmake/Findsmartctl.cmake In AudioTube I've been using this FindYoutubeDl module. Maybe you can make

Re: Haruna in kdereview

2021-07-21 Thread Harald Sitter
On Wed, Jul 21, 2021 at 4:38 PM George Florea Banus wrote: > > On 21.07.2021 13:53, Harald Sitter wrote: > > - the color-schemes dir seems to do nothing. it installs files that > > don't actually exist in the source. fix it or rm -rf? > > It had the Breeze color schemes, but I removed them

Re: Haruna in kdereview

2021-07-21 Thread George Florea Banus
On 21.07.2021 13:53, Harald Sitter wrote: It's an amazing app! Really awesome. Thank you. - you might want to consider using a newer version in your find_package call for ECM. ECM does enable more modern/useful features but only when used with a suitably high version. so, I'd put this at the

Re: Haruna in kdereview

2021-07-21 Thread Harald Sitter
It's an amazing app! Really awesome. - you might want to consider using a newer version in your find_package call for ECM. ECM does enable more modern/useful features but only when used with a suitably high version. so, I'd put this at the actual minimal version you want to support - the