Re: RKWard is in kdereview - again

2022-03-28 Thread Adriaan de Groot
On Monday, 28 March 2022 17:39:17 CEST Thomas Friedrichsmeier wrote: > On Mon, 28 Mar 2022 17:09:44 +0200 > Nicolas Fella wrote: > [...] > > > Talking about FreeBSD: I started adding Gitlab CI and the FreeBSD > > build fails: https://invent.kde.org/education/rkward/-/jobs/274861, > > presumably

Re: RKWard is in kdereview - again

2022-03-28 Thread Thomas Friedrichsmeier
On Mon, 28 Mar 2022 17:09:44 +0200 Nicolas Fella wrote: [...] > Talking about FreeBSD: I started adding Gitlab CI and the FreeBSD > build fails: https://invent.kde.org/education/rkward/-/jobs/274861, > presumably due to having a different tar implementation than Linux. Sweet! > I'd appreciate

Re: RKWard is in kdereview - again

2022-03-28 Thread Thomas Friedrichsmeier
On Mon, 28 Mar 2022 00:09:38 +0200 Albert Astals Cid wrote: [...] > Results of running clang-tidy with some of my favorite options > attached. Thanks! > The first group [bugprone-integer-division] seems an actual bug since >double RKGraphicsDeviceFrontendTransmitter::lwdscale = 72/96; >

Re: RKWard is in kdereview - again

2022-03-28 Thread Nicolas Fella
On 3/28/22 16:53, Adriaan de Groot wrote: On Saturday, 26 March 2022 21:34:06 CEST Thomas Friedrichsmeier wrote: KDE.org has been our home for a 7.5(!) years, now (after over a decade on sourceforge), but we still haven't left playground... After a lot of procrastination on that matter, a

Re: RKWard is in kdereview - again

2022-03-28 Thread Thomas Friedrichsmeier
Hi, On Mon, 28 Mar 2022 15:39:55 +0200 Nicolas Fella wrote: > I recently used RKWard for my Master Thesis, cool project! thanks! > A couple of observations: > > - CommitPolicy.txt still mentions Phabricator, that should point to > Gitlab instead Done. > - CommitPolicy.txt mentions Ubuntu

Re: RKWard is in kdereview - again

2022-03-28 Thread Adriaan de Groot
On Saturday, 26 March 2022 21:34:06 CEST Thomas Friedrichsmeier wrote: > KDE.org has been our home for a 7.5(!) years, now (after over a > decade on sourceforge), but we still haven't left playground... After a > lot of procrastination on that matter, a previous review failed due to > lack of time

Re: RKWard is in kdereview - again

2022-03-28 Thread Nicolas Fella
Hi, I recently used RKWard for my Master Thesis, cool project! A couple of observations: - CommitPolicy.txt still mentions Phabricator, that should point to Gitlab instead - CommitPolicy.txt mentions Ubuntu Trusty as base for requirements, that is *ancient* by now, maybe 20.04 would be a more