Re: Plasma Welcome Center on KDEReview
On 9/18/22 11:03, Harald Sitter wrote: Not all code is licensing policy compliant (e.g. appdata is missing spdx tags). I'd suggest enabling the reuse linter pipeline. How do I do this? Is there an example I can copy from elsewhere (which in case people haven't noticed, is basically how I do everything)? Nate
Re: Plasma Welcome Center on KDEReview
On 9/19/22 01:42, Ingo Klöcker wrote: Please try to keep in mind that there are people who cannot see screenshots. They may not need captions, but they do need a textual description of the screenshot. That's an excellent point, and thanks for the reminder. Captions added. Nate
KDEReview for kio-s3
Hi all, I think kio-s3 [1] is now ready to go through the KDEReview process and get a first release. dfaure and sitter did a first code review in the original MR against kio-extras [1]. The code hasn't changed much since then, mostly the port to the new WorkerBase interface. Please have a look. Thanks :) P.S. You might notice that the gitlab CI is currently broken, I have already filed a sysadmin ticket trying to sort it out. [1]: https://invent.kde.org/network/kio-s3 [2]: https://invent.kde.org/network/kio-extras/-/merge_requests/35 Cheers, Elvis
Re: Plasma Welcome Center on KDEReview
On Montag, 19. September 2022 03:01:14 CEST Nate Graham wrote: > On 9/18/22 11:44, Nicolas Fella wrote: > > - appstreamcli validate --pedantic org.kde.plasma-welcome.appdata.xml > > has some warnings: > > > > P: org.kde.plasma-welcome.desktop:12: screenshot-no-caption > > P: org.kde.plasma-welcome.desktop:~: releases-info-missing > > I: org.kde.plasma-welcome.desktop:3: cid-contains-hyphen > > org.kde.plasma-welcome.desktop > > P: org.kde.plasma-welcome.desktop:15: screenshot-no-caption > > I don't think these are real issues. There are no releases yet, the > screenshots not having captions is intentional (their content seems > totally obvious to me), Please try to keep in mind that there are people who cannot see screenshots. They may not need captions, but they do need a textual description of the screenshot. Regards, Ingo signature.asc Description: This is a digitally signed message part.
