Re: New repo in kdereview: KRecorder
Thanks for all the hard work, Devin. Looks great now! +1 from me. Nate On 12/7/22 22:21, Devin wrote: Here are my audio settings: https://i.imgur.com/8YqR82x.jpg I've adjusted the settings for vorbis visualization which *should* be better now. I think the way the visualization is calculated probably needs to be more sophisticated eventually to be smoother. I think I found the problem; I use 11pt Noto Sans font. I can't reproduce the issue with the default 10pt. This probably points to some width value somewhere being a hardcoded number rather than a multiple of Kirigami.Units.GridUnit, which hopefully should be easy to fix. I've changed it to be based on gridUnit. On Mon, Dec 5, 2022 at 4:55 PM Nate Graham wrote: On 12/4/22 16:47, Devin wrote: I can reproduce it in the following way on Desktop: Hmm, I'm on Kirigami from master and still can't reproduce it, see the attached video. I think I found the problem; I use 11pt Noto Sans font. I can't reproduce the issue with the default 10pt. This probably points to some width value somewhere being a hardcoded number rather than a multiple of Kirigami.Units.GridUnit, which hopefully should be easy to fix. For example: src/contents/ui/main.qml:25:width: Kirigami.Settings.isMobile ? 400 : 800 src/contents/ui/main.qml:28:property bool isWidescreen: (appwindow.width >= 700) && appwindow.wideScreen // prevent being widescreen at first launch I found one new issue that wasn't present the last time I tested: while recording, the volume level indicator always indicates that it's recording at max volume, even when I'm just, like, whispering: This is a hard issue to solve because different combinations of formats and containers produce varying audio levels, so I can't figure out a way to produce them properly. Perhaps once Qt 6 comes around I can look at the issue again since the formats will be reworked but perhaps what I can do is hardcode them for preset formats (currently all audio formats have the maximum hardcoded to 1000, which gets higher if the audio level exceeds that) Here are my audio settings: https://i.imgur.com/8YqR82x.jpg Like I said, this just started happening between the last time I reviewed the app and the time before that. I didn't change any audio settings between those times. Nate
Re: New repo in kdereview: KRecorder
> Here are my audio settings: https://i.imgur.com/8YqR82x.jpg I've adjusted the settings for vorbis visualization which *should* be better now. I think the way the visualization is calculated probably needs to be more sophisticated eventually to be smoother. > I think I found the problem; I use 11pt Noto Sans font. I can't reproduce the > issue with the default 10pt. This probably points to some width value > somewhere being a hardcoded number rather than a multiple of > Kirigami.Units.GridUnit, which hopefully should be easy to fix. I've changed it to be based on gridUnit. On Mon, Dec 5, 2022 at 4:55 PM Nate Graham wrote: > > On 12/4/22 16:47, Devin wrote: > >> I can reproduce it in the following way on Desktop: > > > > Hmm, I'm on Kirigami from master and still can't reproduce it, see the > > attached video. > > I think I found the problem; I use 11pt Noto Sans font. I can't > reproduce the issue with the default 10pt. This probably points to some > width value somewhere being a hardcoded number rather than a multiple of > Kirigami.Units.GridUnit, which hopefully should be easy to fix. > > For example: > > src/contents/ui/main.qml:25:width: Kirigami.Settings.isMobile ? 400 > : 800 > src/contents/ui/main.qml:28:property bool isWidescreen: > (appwindow.width >= 700) && appwindow.wideScreen // prevent being > widescreen at first launch > > > > >> I found one new issue that wasn't present the last time I tested: while > >> recording, the volume level indicator always indicates that it's recording > >> at max volume, even when I'm just, like, whispering: > > > > This is a hard issue to solve because different combinations of > > formats and containers produce varying audio levels, so I can't figure > > out a way to produce them properly. Perhaps once Qt 6 comes around I > > can look at the issue again since the formats will be reworked but > > perhaps what I can do is hardcode them for preset formats (currently > > all audio formats have the maximum hardcoded to 1000, which gets > > higher if the audio level exceeds that) > > Here are my audio settings: https://i.imgur.com/8YqR82x.jpg > > Like I said, this just started happening between the last time I > reviewed the app and the time before that. I didn't change any audio > settings between those times. > > > Nate
