Re: Kandalf: request for review
On 12/8/23 00:49, Albert Astals Cid wrote: El divendres, 8 de desembre de 2023, a les 0:44:11 (CET), Carl Schwan va escriure: On Fri, Dec 8, 2023, at 12:10 AM, Albert Astals Cid wrote: El dijous, 7 de desembre de 2023, a les 16:28:48 (CET), Loren Burkholder va escriure: Hi all! I've been working towards getting Kandalf ready for integration into KDE (and I'd like to thank everyone who has pitched in to help me, mainly Laurent and redstrate). At this point, while the app is not necessarily feature-complete or fully polished, it's getting close to that point. Therefore, I'd like to officially request a review of Kandalf for inclusion in the KDE apps. Where is the thing we're supposed to review? In the wrong place:https://invent.kde.org/lorendb/kandalf/-/issues/1 And again we have people self-checking the checkboxes or their own review :sad_dance: To be fair, nowhere in https://community.kde.org/Policies/Application_Lifecycle#kdereview does it say who is supposed to check what box, so people checking "obvious" boxes like "It has a passing CI build" themselves isn't that far off. I asked Loren to create a sysadmin ticket to get it moved to an offical namespace. That seems premature? What if the review never succeeds?
Re: Kandalf: request for review
On 12/8/23 00:49, Albert Astals Cid wrote: El divendres, 8 de desembre de 2023, a les 0:44:11 (CET), Carl Schwan va escriure: On Fri, Dec 8, 2023, at 12:10 AM, Albert Astals Cid wrote: El dijous, 7 de desembre de 2023, a les 16:28:48 (CET), Loren Burkholder va escriure: Hi all! I've been working towards getting Kandalf ready for integration into KDE (and I'd like to thank everyone who has pitched in to help me, mainly Laurent and redstrate). At this point, while the app is not necessarily feature-complete or fully polished, it's getting close to that point. Therefore, I'd like to officially request a review of Kandalf for inclusion in the KDE apps. Where is the thing we're supposed to review? In the wrong place: https://invent.kde.org/lorendb/kandalf/-/issues/1 And again we have people self-checking the checkboxes or their own review :sad_dance: I asked Loren to create a sysadmin ticket to get it moved to an offical namespace. That seems premature? What if the review never succeeds? You don't need a passing kdereview to be able to get a repository. kdereview typically happens (much) later than that.
Re: Kandalf: request for review
El divendres, 8 de desembre de 2023, a les 0:44:11 (CET), Carl Schwan va escriure: > On Fri, Dec 8, 2023, at 12:10 AM, Albert Astals Cid wrote: > > El dijous, 7 de desembre de 2023, a les 16:28:48 (CET), Loren Burkholder > > va > > > > escriure: > > > Hi all! > > > > > > I've been working towards getting Kandalf ready for integration into KDE > > > (and I'd like to thank everyone who has pitched in to help me, mainly > > > Laurent and redstrate). At this point, while the app is not necessarily > > > feature-complete or fully polished, it's getting close to that point. > > > Therefore, I'd like to officially request a review of Kandalf for > > > inclusion > > > in the KDE apps. > > > > Where is the thing we're supposed to review? > > In the wrong place: https://invent.kde.org/lorendb/kandalf/-/issues/1 And again we have people self-checking the checkboxes or their own review :sad_dance: > I asked Loren to create a sysadmin ticket to get it moved to an offical > namespace. That seems premature? What if the review never succeeds? Cheers, Albert > > Cheers, > Carl
Re: Kandalf: request for review
On Fri, Dec 8, 2023, at 12:10 AM, Albert Astals Cid wrote: > El dijous, 7 de desembre de 2023, a les 16:28:48 (CET), Loren Burkholder va > escriure: > > Hi all! > > > > I've been working towards getting Kandalf ready for integration into KDE > > (and I'd like to thank everyone who has pitched in to help me, mainly > > Laurent and redstrate). At this point, while the app is not necessarily > > feature-complete or fully polished, it's getting close to that point. > > Therefore, I'd like to officially request a review of Kandalf for inclusion > > in the KDE apps. > > Where is the thing we're supposed to review? In the wrong place: https://invent.kde.org/lorendb/kandalf/-/issues/1 I asked Loren to create a sysadmin ticket to get it moved to an offical namespace. Cheers, Carl
Re: Kandalf: request for review
El dijous, 7 de desembre de 2023, a les 16:28:48 (CET), Loren Burkholder va escriure: > Hi all! > > I've been working towards getting Kandalf ready for integration into KDE > (and I'd like to thank everyone who has pitched in to help me, mainly > Laurent and redstrate). At this point, while the app is not necessarily > feature-complete or fully polished, it's getting close to that point. > Therefore, I'd like to officially request a review of Kandalf for inclusion > in the KDE apps. Where is the thing we're supposed to review? Cheers, Albert > > You can reach me on Matrix at @lorendb:nheko.im for more instant > communications. > > Thanks, > Loren Burkholder
Re: Kandalf: request for review
This isn't going to be very useful, but I'm sure I'm not the only one who has heard of the story that the Tolkien Estate wasn't too happy with our original kandalf. Consequently I'm not sure we should actually name this thing kandalf. But then I wasn't around back then so I don't know if there is any truth to it or if it's just an urban legend. Regardless it's confusing to recycle the name for something entirely different and I'd reconsider the name here. Food for thought. On Thu, Dec 7, 2023 at 7:10 PM Loren Burkholder wrote: > > Hi all! > > I've been working towards getting Kandalf ready for integration into KDE (and > I'd like to thank everyone who has pitched in to help me, mainly Laurent and > redstrate). At this point, while the app is not necessarily feature-complete > or fully polished, it's getting close to that point. Therefore, I'd like to > officially request a review of Kandalf for inclusion in the KDE apps. > > You can reach me on Matrix at @lorendb:nheko.im for more instant > communications. > > Thanks, > Loren Burkholder
Kandalf: request for review
Hi all! I've been working towards getting Kandalf ready for integration into KDE (and I'd like to thank everyone who has pitched in to help me, mainly Laurent and redstrate). At this point, while the app is not necessarily feature-complete or fully polished, it's getting close to that point. Therefore, I'd like to officially request a review of Kandalf for inclusion in the KDE apps. You can reach me on Matrix at @lorendb:nheko.im for more instant communications. Thanks, Loren Burkholder signature.asc Description: This is a digitally signed message part.
