Re: Review Request: Rework kdebugdialog --fullmode ui

2011-12-19 Thread Aurélien Gâteau
. 13, 2011, 1:15 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103403/ --- (Updated Dec. 13, 2011

Re: Review Request: Rework kdebugdialog --fullmode ui

2011-12-13 Thread Aurélien Gâteau
--- On Dec. 13, 2011, 1:15 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103403

Re: Review Request: Fix KGlobalSettingsTest failure

2011-08-02 Thread Aurélien Gâteau
On July 28, 2011, 10:26 a.m., Aurélien Gâteau wrote: I don't think it is good for unit-tests to test different things depending on environment variables ( @David, what is your opinion on the subject?) I was actually about to commit a simpler fix: @@ -26,11 +26,11

Re: Review Request: Use platform palette and fonts when running on other desktop environments

2011-07-28 Thread Aurélien Gâteau
On July 2, 2011, 9:49 p.m., Oswald Buddenhagen wrote: hmm. but now things are still done twice in a kde session, no? what was wrong with the suggestion to notify qt that it should update stuff? Aurélien Gâteau wrote: createApplicationPalette() is indeed called twice when running

Re: Review Request: Fix KGlobalSettingsTest failure

2011-07-28 Thread Aurélien Gâteau
On July 28, 2011, 10:26 a.m., Aurélien Gâteau wrote: I don't think it is good for unit-tests to test different things depending on environment variables ( @David, what is your opinion on the subject?) I was actually about to commit a simpler fix: @@ -26,11 +26,11

Re: Formal complaint concerning the use of the name System Settings by GNOME

2011-07-26 Thread Aurélien Gâteau
Le 25/07/2011 19:51, Lennart Poettering a écrit : On Mon, 25.07.11 17:40, Giovanni Campagna (scampa.giova...@gmail.com) wrote: The spec does not provide a list of shared keys, does such a list exist? If there is no such list I don't see how we could share anything.

Re: Formal complaint concerning the use of the name System Settings by GNOME

2011-07-24 Thread Aurélien Gâteau
Le 24/07/2011 12:55, Giovanni Campagna a écrit : Which is a KDE bug. You should use GNOME shortcuts when possible. I mean, Gtk has emacs and Mac OS modes for keybindings, I doubt Qt hasn't something similar. It is true that you can change KDE theme without changing the GTK one, but why

Re: Formal complaint concerning the use of the name System Settings by GNOME

2011-07-23 Thread Aurélien Gâteau
Le 23/07/2011 12:33, Emmanuele Bassi a écrit : On 2011-07-23 at 11:27, Dodji Seketeli wrote: Matthias Clasen matthias.cla...@gmail.com a écrit: I don't think Shauns proposal addresses the issue, really. Why? Do you have an example that would show where Shaun's proposal falls short? it

Re: Review Request: Use platform palette and fonts when running on other desktop environments

2011-07-22 Thread Aurélien Gâteau
On July 2, 2011, 9:49 p.m., Oswald Buddenhagen wrote: hmm. but now things are still done twice in a kde session, no? what was wrong with the suggestion to notify qt that it should update stuff? Aurélien Gâteau wrote: createApplicationPalette() is indeed called twice when running

Re: Fixes in Git (first in stable, then merge to master)

2011-07-21 Thread Aurélien Gâteau
Le 20/07/2011 11:52, Alex Fiestas a écrit : Hi there Last few days I have been patching some pieces of our workspace here and there, the first set of patches I did them directly into master which if I remember correctly was against the policy. So, the second round of fixes I tried to do

Re: Review Request: Use platform palette and fonts when running on other desktop environments

2011-07-17 Thread Aurélien Gâteau
On July 2, 2011, 9:49 p.m., Oswald Buddenhagen wrote: hmm. but now things are still done twice in a kde session, no? what was wrong with the suggestion to notify qt that it should update stuff? Aurélien Gâteau wrote: createApplicationPalette() is indeed called twice when running

Re: Review Request: Use platform palette and fonts when running on other desktop environments

2011-07-16 Thread Aurélien Gâteau
On July 2, 2011, 9:49 p.m., Oswald Buddenhagen wrote: hmm. but now things are still done twice in a kde session, no? what was wrong with the suggestion to notify qt that it should update stuff? Aurélien Gâteau wrote: createApplicationPalette() is indeed called twice when running

Re: Review Request: Use platform palette and fonts when running on other desktop environments

2011-07-03 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101805/#review4333 --- On July 2, 2011, 9:19 p.m., Aurélien Gâteau wrote: --- This is an automatically

Re: Review Request: Use platform palette when running on other desktop environments

2011-07-01 Thread Aurélien Gâteau
/#review4278 --- On June 30, 2011, 3:36 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101805

Re: [kdelibs] kdeui/widgets: Get rid of the deprecated KMessageWidget::MessageType enum values

2011-05-19 Thread Aurélien Gâteau
On 19/05/2011 08:01, Kevin Krammer wrote: On Wednesday, 2011-05-18, Aurélien Gâteau wrote: Git commit 388edfe3362c07c0d46b3990a325258684aaeb97 by Aurélien Gâteau. Committed on 18/05/2011 at 22:27. Pushed by gateau into branch 'master'. Get rid of the deprecated KMessageWidget::MessageType

[kdelibs] kdeui/widgets: Get rid of the deprecated KMessageWidget::MessageType enum values

2011-05-18 Thread Aurélien Gâteau
Git commit 388edfe3362c07c0d46b3990a325258684aaeb97 by Aurélien Gâteau. Committed on 18/05/2011 at 22:27. Pushed by gateau into branch 'master'. Get rid of the deprecated KMessageWidget::MessageType enum values I checked with lxr.kde.org and fixed existing users, so it shouldn't break any build

[kdelibs] kdeui/widgets: Shorten length of MessageType enums

2011-05-10 Thread Aurélien Gâteau
Git commit a7801bf4fd347462840df1a62e718f77cf489a5b by Aurélien Gâteau. Committed on 11/05/2011 at 06:41. Pushed by gateau into branch 'master'. Shorten length of MessageType enums KMessageWidget::MessageType enums were annoying to type because they are quite long. I shortened them by removing

Re: Review Request: Fix the layout of KNameAndUrlInputDialog (kfile)

2011-05-10 Thread Aurélien Gâteau
On May 9, 2011, 10:45 p.m., Aurélien Gâteau wrote: Looks good. I would even go a bit further and suggest the following: - Remove the Clear button, I don't think it serves any purpose - Change the label of the OK button to Create Link Jonathan Marten wrote: Good idea to remove

Re: Adding a dependency on libkonq to Gwenview

2011-05-09 Thread Aurélien Gâteau
On 09/05/2011 09:31, Aurélien Gâteau wrote: On 07/05/2011 10:43, Aurélien Gâteau wrote: Hi, As part of my work on the image comparison feature in Gwenview, I want to make it possible to restore trashed images from within Gwenview (in case the user trashes the wrong image while comparing

Re: Review Request: Fix the layout of KNameAndUrlInputDialog (kfile)

2011-05-09 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101312/#review3233 --- Looks good. I would even go a bit further and suggest the

Adding a dependency on libkonq to Gwenview

2011-05-07 Thread Aurélien Gâteau
Hi, As part of my work on the image comparison feature in Gwenview, I want to make it possible to restore trashed images from within Gwenview (in case the user trashes the wrong image while comparing). In the past I have been duplicating code from libkonq in Gwenview because kdegraphics was not

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

2011-05-01 Thread Aurélien Gâteau
--- On April 30, 2011, 1:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

2011-04-30 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/ --- (Updated April 30, 2011, 1:10 p.m.) Review request for kdelibs. Changes

Re: Deploying new kdelibs classes

2011-04-25 Thread Aurélien Gâteau
On 23/04/2011 23:22, Jaroslaw Staniek wrote: Aurélien, I am writing regarding http://agateau.wordpress.com/2011/04/21/kde-ux-2011/ One thing, about deploying the kmessagewidget (and similar things) in kdelibs. If it's part of kdelibs 4.7 or something, apps that support kdelibs 4.7 would have

Re: More about kdelibs unittests

2010-12-13 Thread Aurélien Gâteau
On 10/12/2010 00:44, David Faure wrote: Yes, this will crash with QT_FATAL_WARNINGS. So? It's good to have a unit test test border conditions too, even if these conditions lead to warnings from Qt. One could try to use QTest::ignoreMessage() [1] to skip expected error messages. Does not

Re: More about kdelibs unittests

2010-12-09 Thread Aurélien Gâteau
On 09/12/2010 17:52, David Faure wrote: On Tuesday 07 December 2010, Jaime wrote: Hi, I've run the kdelibs with the environment variable QT_FATAL_WARNINGS=1, and the number of failed tests has grown in a noticeable way. (also with 2 crashes). I guess that less Qt warnings usually means

Re: Review Request: Prevent crash in KJob::emitResult() if job is deleted

2010-12-02 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6022/ --- (Updated 2010-12-02 16:51:19.493828) Review request for kdelibs and Kevin

Review Request: Prevent crash in KJob::emitResult() if job is deleted

2010-12-01 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6022/ --- Review request for kdelibs and Kevin Ottens. Summary --- If a someone

Re: Review Request: Prevent crash in KJob::emitResult() if job is deleted

2010-12-01 Thread Aurélien Gâteau
--- On 2010-12-01 17:01:44, Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6022

KDE/kdelibs/kdeui

2010-11-13 Thread Aurélien Gâteau
SVN commit 1196662 by gateau: Removed KStandardAction::showHideStatusbar() and showHideMenubar() CCMAIL:kde-core-devel@kde.org M +0 -50 actions/kstandardaction.cpp M +0 -12 actions/kstandardaction.h M +8 -9 xmlgui/kxmlguiwindow.cpp ---

Re: Changing my mind: reverting my menubar, toolbars and statusbar changes

2010-11-08 Thread Aurélien Gâteau
On 08/11/2010 14:18, Thomas Lübking wrote: Am Monday 08 November 2010 schrieb Johannes Sixt: How is a checkable menu entry that is not checked different from a menu entry that is not checkable, hm? There is *no* difference. Broken UI style? There *can be* a difference ;-P Unchecked Box:

Changing my mind: reverting my menubar, toolbars and statusbar changes

2010-11-06 Thread Aurélien Gâteau
Hi, I have been quite busy trying to convince everyone actions to toggle UI items such as menubar, toolbars, sidebars or statusbar should be labeled Show/hide Foo depending on the visibility of Foo rather than implemented as a checkable [ ] Show Foo item. Having started to work on converting

<    1   2