Re: kio-extras

2015-01-23 Thread Bhushan Shah
ma 5.2 about to go out shall I ask for kio-extras to be moved and > if so into which module? Also related, http://mail.kde.org/pipermail/kde-frameworks-devel/2015-January/021686.html -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode

Re: Build dependency issues with kdesrc-build

2015-02-03 Thread Bhushan Shah
include. > > So should we move plasmate into Applications ? > Or move KDevPlatform into Workspace ? Please see http://mail.kde.org/pipermail/plasma-devel/2015-January/038642.html -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode

plasma-mediacenter in kdereview from extragear

2015-02-20 Thread Bhushan Shah
. Looking forward to review from community Thanks! -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode

Re: plasma-mediacenter in kdereview from extragear

2015-02-20 Thread Bhushan Shah
On Thu, Feb 19, 2015 at 8:22 PM, Bhushan Shah wrote: > Looking forward to review from community Just for record : This mail is sent to both plasma-devel and kde-core-devel, reply to kde-core-devel -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode

Re: plasma-mediacenter in kdereview from extragear

2015-02-21 Thread Bhushan Shah
ced this dep already mentions the required plasma-workspace commit commit 451eceffaf4a1c06e162dc629bb5fc945e40ae73 Author: Bhushan Shah Date: Tue Feb 17 22:50:08 2015 +0530 Install session file for pmc For that session file to work it will require recen

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-02-21 Thread Bhushan Shah
> On Feb. 21, 2015, 8:16 a.m., Hrvoje Senjan wrote: > > can you check what needs to be adjusted in plasma-workspace? it fails to > > build with your change: > > > > > > > > [ 451s] > > /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:471:43: > > error: 'pr

Re: plasma-mediacenter in kdereview from extragear

2015-03-06 Thread Bhushan Shah
Hello! On Thu, Feb 19, 2015 at 8:22 PM, Bhushan Shah wrote: > We want to move plasma-mediacenter to kde/workspace for releasing it > with Plasma 5.x release cycle, Plasma media center is living room > solution of plasma workspaces, it is integrated as shell package for > PMC. Given

Re: kde-build-metadata for beta branches

2015-11-21 Thread Bhushan Shah
stable. Thanks -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode

Re: apidocs page seems broken

2016-02-09 Thread Bhushan Shah
ls/draganddrop/CMakeFiles/draganddropplugin_automoc.dir/build.make' Resulting in all this chaos.. I've triggered rebuild of kdeclarative and hopefully that will fix this. Cheers! -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode

Re: apidocs page seems broken

2016-02-09 Thread Bhushan Shah
On Mon, Feb 8, 2016 at 7:44 PM, Bhushan Shah wrote: > Resulting in all this chaos.. I've triggered rebuild of kdeclarative > and hopefully that will fix this. And wooho! seems latest run fixed this.. :-) -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode

Re: CI Requirements - Lessons Not Learnt?

2017-01-12 Thread Bhushan Shah
zy bugs to debug. -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D

PSA: Phabricator staging repositories

2018-06-29 Thread Bhushan Shah
g this to some list, feel free to forward it and please make sure to include sysad...@kde.org or me in reply. Thanks [1] https://secure.phabricator.com/book/phabricator/article/harbormaster/ -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B

Re: Downtime announcement: www.kde.org

2018-11-05 Thread Bhushan Shah
- Any application using GHNS > > > > In addition, any other site which is hosted by the server known as > > "olios.kde.org" will also be unavailable during this time. > > > > Apologies for any inconvenience caused. > > The maintenance window has n

Re: Downtime announcement: www.kde.org

2018-11-09 Thread Bhushan Shah
logies for any inconvenience caused. > > The maintenance window has now commenced. > The above sites will be inaccessible until the maintenance is completed. > > > > > Regards, > > Ben Cooksley > > KDE Sysadmin > > Regards, > Ben -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Taking over maintainership of the kaccounts-* repos

2019-09-13 Thread Bhushan Shah
with this, let me know. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

plasma-nano and plasma-phone-components are now in kdereview

2019-11-07 Thread Bhushan Shah
can extend, while plasma-phone-components is a shell package, look and feel and several other components which makes Plasma Mobile. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc

Keysmith in kdereview

2019-12-18 Thread Bhushan Shah
Hello everyone! Keysmith (https://invent.kde.org/kde/keysmith) has been moved to kdereview. Keysmith is a Two-factor code generator for Plasma Mobile and Desktop and is using oath-toolkit for this purpose. User interface is written in the kirigami. Thanks! -- Bhushan Shah http://blog.bshah.in

Re: Keysmith in kdereview

2020-01-22 Thread Bhushan Shah
much better! Since there has been no other objections, I will move the keysmith into extragear today. Cheers! -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Move some out-of-date bindings to unmaintained

2020-04-24 Thread Bhushan Shah
f is maintained? Anyway, any objections to me moving following to unmaintained? Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Move kimagemapeditor to kdegraphics

2020-04-24 Thread Bhushan Shah
? -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Moving several repositories in kdesupport to unmaintained

2020-04-24 Thread Bhushan Shah
Any objections to moving following out of kdesupport to unmaintained? - automoc - emerge - emerge-history - libqzeitgeist - soprano - strigi All of this is kde4 based our outdated Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643

Information regarding upcoming Gitlab Migration

2020-04-26 Thread Bhushan Shah
lement this next week and move projects to https://invent.kde.org. Thanks! Bhushan for sysadmin team [1] https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Bhushan Shah
refer when I don't have to guess this kind of things when > fetching a repository. [*] Ironically, in your case search would be helpful as you know you are looking for knetwalk so you can just add it and search it -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Bhushan Shah
sitories but they are instead offered the empty page. One have to click on Shared repositories tab to actually see the list. https://invent.kde.org/groups/sysadmin/test/test2/-/shared This defeats the purpose of the creating subgroups (offering easy reachability). -- Bhushan Shah http://blog.bshah.in IR

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Bhushan Shah
ma" and > "Frameworks", and so on). As explained above, while grouping repositories is trying to solve the merge requests/issue organization, it is not sole purpose of the suggested grouping, discoverability and reachability is the main issue we are trying to solve here. [1] https://

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Bhushan Shah
n it was projects.kde.org (chiliproject installation). [1] https://blog.bshah.in/2013/09/01/hello-planet/ -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Information regarding upcoming Gitlab Migration

2020-04-28 Thread Bhushan Shah
nclude any namespace. [url "https://invent.kde.org/";] insteadOf = invent: [url "g...@invent.kde.org:"] pushInsteadOf = invent: > (That said, bigflatlistofrepositories.kde.org .. or maybe call it > cgit.kde.org > .. could be a particular view onto gitlab wh

Information regarding upcoming Gitlab Migration: clarifications

2020-04-29 Thread Bhushan Shah
a.git/tree/projects-invent?h=bshah/invent -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Migration to Gitlab -- Update

2020-05-10 Thread Bhushan Shah
> the metadata repopath has not been updated yet: > https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent/utilities/keysmith/metadata.yaml?h=bshah/invent Yes, that is correct, currently directory structure is what will be final structure, repopath and other bits will migrated al

Re: Namespaces for a few repositories on invent (was Re: Migration to Gitlab -- Update)

2020-05-10 Thread Bhushan Shah
not even sure where this content is hosted if at all (seems to have .php files in there) > Also unmaintained/ contains two of them (necessitas, strigi), but it doesn't > matter much I guess. I've flattened necessitas and strigi. > Ciao! > -- > Luigi -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

Re: Gitlab Turn-off Issues

2020-06-30 Thread Bhushan Shah
eature, they can also decide to restrict it to enterprise customers. May I please suggest to make public statements which have the facts backing to it? Because that statement is not correct and have zero backing to it. -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key finger

Re: Review Request 112260: Enable Dict DataEngine on KF5

2013-08-26 Thread Bhushan Shah
-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112260/#review38609 --- On Aug. 26, 2013, 12:55 p.m., Bhushan Shah wrote: > >

Review Request 112326: enable keystate dataengine on KF5

2013-08-28 Thread Bhushan Shah
Links - check Installs - check Works - check However somehow its not showing keyboard keys, looks like problem in kdelibs KModifierKeyInfo. Thanks, Bhushan Shah

Review Request 112327: Enable soliddevice DataEngine on KF5

2013-08-28 Thread Bhushan Shah
--- Compiles, Links, installs and works. Thanks, Bhushan Shah

Review Request 112351: Application jobs dataengine for KF5

2013-08-29 Thread Bhushan Shah
59a4de7 Diff: http://git.reviewboard.kde.org/r/112351/diff/ Testing --- compiles links installs but not sure how to test? Thanks, Bhushan Shah

Re: Review Request 112200: Remove unused CMake qimageblitz includes and links

2013-09-01 Thread Bhushan Shah
> On Aug. 30, 2013, 1:58 p.m., David Faure wrote: > > Confirmed with http://lxr.kde.org/ident?i=Blitz can we ship it on frameworks-scratch? - Bhushan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard

Re: Review Request 112641: port about kio slave

2013-09-10 Thread Bhushan Shah
://git.reviewboard.kde.org/r/112641/diff/ Testing --- Thanks, Bhushan Shah

Review Request 112641: port about kio slave

2013-09-10 Thread Bhushan Shah
Diffs - kioslave/CMakeLists.txt ff66ab6 kioslave/about/CMakeLists.txt 4f8d91f kioslave/about/kio_about.h 620d6aa kioslave/about/kio_about.cpp d7396d8 Diff: http://git.reviewboard.kde.org/r/112641/diff/ Testing --- Thanks, Bhushan Shah

Review Request 113056: Port ksgrd library to KF5

2013-10-02 Thread Bhushan Shah
grd/SensorManager.cpp f1657ee libs/ksysguard/ksgrd/SensorShellAgent.cpp df6b20f libs/ksysguard/ksgrd/SensorSocketAgent.cpp 5104e62 Diff: http://git.reviewboard.kde.org/r/113056/diff/ Testing --- No tests, we can test this by porting systemmonitor dataengine later. Thanks, Bhushan Shah

Re: Review Request 113056: Port ksgrd library to KF5

2013-10-02 Thread Bhushan Shah
tor dataengine later. Tested, works as expected. https://git.reviewboard.kde.org/r/113072/ Thanks, Bhushan Shah

Re: Review Request 113056: Port ksgrd library to KF5

2013-10-03 Thread Bhushan Shah
tor dataengine later. Tested, works as expected. https://git.reviewboard.kde.org/r/113072/ Thanks, Bhushan Shah

Re: Review Request 113056: Port ksgrd library to KF5

2013-10-03 Thread Bhushan Shah
No tests, we can test this by porting systemmonitor dataengine later. Tested, works as expected. https://git.reviewboard.kde.org/r/113072/ Thanks, Bhushan Shah

Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

2013-10-24 Thread Bhushan Shah
ip It!" - Bhushan Shah On Oct. 24, 2013, 8:02 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Splitting kde-workspace and kde-runtime proposal

2014-01-21 Thread Bhushan Shah
os to the related group. Advantages: 1) Easy to assign maintainer to individual component. 2) If we split only some repos, we can not mark it as part of workspace but this way we can do it. 3) More, may be? That's my humble suggestion. :) > Again, this is a proposal so please! send any fee

Re: Splitting kde-workspace and kde-runtime proposal

2014-01-21 Thread Bhushan Shah
something as a standard > solution. So each person will consider "Plasma Desktop" as something entirely > different. Yes having group is essential, otherwise it will create confusion.. repo like kde:kf5umbrella will be also needed. Thanks! -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode

Using kqmlgraphplugin in Plasma Next

2014-01-30 Thread Bhushan Shah
interested in porting it to KDE Frameworks 5. Is someone already working on that? If yes can I help with that? Otherwise I will start to port it. :) Thanks! -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode

Re: Using kqmlgraphplugin in Plasma Next

2014-01-31 Thread Bhushan Shah
want to pull in extra C++ based models to plot charts. So I am totally confused and diverged, I can not decide what to do? Thanks! -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode

Re: Using kqmlgraphplugin in Plasma Next

2014-01-31 Thread Bhushan Shah
On Fri, Jan 31, 2014 at 7:51 PM, Bhushan Shah wrote: > I already have working port of kqmlgraphplugin, (Surprise? :D) by working I mean I can compile it.. Not actually working.. -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode

Review Request 116600: depend upon CMake 2.8.12

2014-03-04 Thread Bhushan Shah
- CMakeLists.txt 41923b6 Diff: https://git.reviewboard.kde.org/r/116600/diff/ Testing --- works, warning is gone Thanks, Bhushan Shah

Re: Review Request 116600: depend upon CMake 2.8.12

2014-03-04 Thread Bhushan Shah
(message): Your project should require at least CMake 2.8.12 to use FindXCB.cmake Diffs - CMakeLists.txt 41923b6 Diff: https://git.reviewboard.kde.org/r/116600/diff/ Testing --- works, warning is gone Thanks, Bhushan Shah

Git merge workflow: reverse it?

2020-08-02 Thread Bhushan Shah
and if it works fine in general testing then, cherry-pick it in stable branches. Proposal is to probably adapt this policy kde-wise if people feel that advantages are worth it. Thanks [1] https://mail.kde.org/pipermail/plasma-devel/2020-June/117887.html -- Bhushan Shah http://blog.bshah.i

plasma-mobile/plasma-dialer in kdereview

2020-12-19 Thread Bhushan Shah
is dialer application for Plasma Mobile. It is basically telepathy client with two parts, approver and dialer client. To test this on local system if you want you need ofono-phonesim and telepathy-ofono or telepathy-ring. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freeno

plasma-mobile/spacebar in kdereview

2020-12-19 Thread Bhushan Shah
them in database, spacebar client is what users interact with to check the incoming messages and send outgoing messages. Similar to plasma-dialer, to test this you need ofono phonesim and telepathy-ring or telepathy-ofono. Cheers! -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on

Re: plasma-mobile/spacebar in kdereview

2021-01-19 Thread Bhushan Shah
Hello, I have fixed the i18n issue with the spacebar, and crash fix was committed by the JBB, Since it has been in kdereview for month now, I will proceed to move this to extragear and prepare 0.1 release of it. Thanks! On Thu, Dec 17, 2020 at 06:02:20PM +0530, Bhushan Shah wrote: > He

New repo in kdereview: plasma-phonebook

2021-01-24 Thread Bhushan Shah
contacts on your system. Another thing I want to discuss is, branding, currently it is named as Plasma Phonebook which is bit awkward because Plasma is not related to app at all and even android port for app exists. Maybe we should name this just phonebook? Thanks -- Bhushan Shah http

New repo in kdereview: plasma-angelfish

2021-01-24 Thread Bhushan Shah
available in README.md of the repository. Before moving it to extragear I would like to drop plasma- prefix from the repository as this repo have nothing much to do with "Plasma". And it is otherwise already called just "Angelfish" in its desktop files and stuff. Cheers. -

New repo in kdereview: plasma-settings

2021-01-24 Thread Bhushan Shah
desktop is, this code is much more lean and modern, it is my understanding that long term idea is to replace the original systemsettings code base with plasma-settings. But for now this is mobile specific. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint

Re: New repo in kdereview: plasma-phonebook

2021-02-14 Thread Bhushan Shah
Hello, On Mon, Jan 25, 2021 at 02:18:51PM +0100, Harald Sitter wrote: > On 25.01.21 06:48, Bhushan Shah wrote: > > Hello everyone! > > > > I am back with more Plasma Mobile related repositories in kdereview. I > > want to move plasma-phonebook in kdereview. plasma-phon

Re: New repo in kdereview: plasma-angelfish

2021-02-14 Thread Bhushan Shah
On Mon, Jan 25, 2021 at 02:56:39PM +0100, Harald Sitter wrote: > On 25.01.21 06:55, Bhushan Shah wrote: > > Hello everyone! > > > > Yet another Plasma Mobile repository in kdereview: > > > > https://invent.kde.org/plasma-mobile/plasma-angelfish > > >

Re: New repo in kdereview: plasma-settings

2021-02-14 Thread Bhushan Shah
Forwarding message, since had wrong reply to address in previous message - Forwarded message from Bhushan Shah - Date: Mon, 15 Feb 2021 11:44:14 +0530 From: Bhushan Shah To: Harald Sitter Subject: Re: New repo in kdereview: plasma-settings On Mon, Jan 25, 2021 at 03:29:18PM +0100

Review Request 111648: Fix for GroupExpander that overlaps application icon

2013-07-22 Thread Bhushan Shah
current task manager Arrow for the GroupExpander overlaps the application icon, Fix for it. Diffs - plasma/desktop/applets/tasks/package/contents/ui/GroupExpanderOverlay.qml 7aa0d00 Diff: http://git.reviewboard.kde.org/r/111648/diff/ Testing --- Thanks, Bhushan Shah

Re: Review Request 111648: Fix for GroupExpander that overlaps application icon

2013-07-22 Thread Bhushan Shah
(updated) --- Works for me Thanks, Bhushan Shah

Re: Review Request 111648: Fix for GroupExpander that overlaps application icon

2013-07-23 Thread Bhushan Shah
Thanks, Bhushan Shah

Re: Review Request 111648: Fix for GroupExpander that overlaps application icon

2013-08-08 Thread Bhushan Shah
, Bhushan Shah

Review Request 111992: Activity bar in QML.

2013-08-10 Thread Bhushan Shah
--- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah

Re: Review Request 111992: Activity bar in QML.

2013-08-10 Thread Bhushan Shah
activity manager. That don't make sense to me.. - Bhushan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37476 -------

Re: Review Request 111992: Activity bar in QML.

2013-08-10 Thread Bhushan Shah
b7155de Diff: http://git.reviewboard.kde.org/r/111992/diff/ Testing --- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah

Re: Review Request 111992: Activity bar in QML.

2013-08-10 Thread Bhushan Shah
b7155de Diff: http://git.reviewboard.kde.org/r/111992/diff/ Testing --- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah

Re: Review Request 111992: Activity bar in QML.

2013-08-11 Thread Bhushan Shah
-applet-activitybar.desktop b7155de Diff: http://git.reviewboard.kde.org/r/111992/diff/ Testing --- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah

Re: Review Request 111992: Activity bar in QML.

2013-08-11 Thread Bhushan Shah
/git.reviewboard.kde.org/r/111992/#review37549 --- On Aug. 11, 2013, 11:39 a.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 111992: Activity bar in QML.

2013-08-11 Thread Bhushan Shah
-activitybar.desktop b7155de Diff: http://git.reviewboard.kde.org/r/111992/diff/ Testing --- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah

Re: Review Request 111992: Activity bar in QML.

2013-08-12 Thread Bhushan Shah
Anything to do in this applet? Or just Drop this issue? - Bhushan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37558 ---------

Re: Review Request 111992: Activity bar in QML.

2013-08-12 Thread Bhushan Shah
-activitybar.desktop b7155de Diff: http://git.reviewboard.kde.org/r/111992/diff/ Testing --- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah

Re: Review Request 111992: Activity bar in QML.

2013-08-12 Thread Bhushan Shah
--- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah

Re: Review Request 111992: Activity bar in QML.

2013-08-13 Thread Bhushan Shah
you can make TabBar the root item. > > > > i.e instead of > > > > Item { > > TabBar { > > } > > } > > > > we can just have > > TabBar { > > > > } > > > > >

Re: Review Request 111992: Activity bar in QML.

2013-08-13 Thread Bhushan Shah
b7155de Diff: http://git.reviewboard.kde.org/r/111992/diff/ Testing --- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah

Re: Review Request 111992: Activity bar in QML.

2013-08-13 Thread Bhushan Shah
://git.reviewboard.kde.org/r/111992/diff/ Testing --- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah

Re: Review Request 111992: Activity bar in QML.

2013-08-13 Thread Bhushan Shah
://git.reviewboard.kde.org/r/111992/diff/ Testing --- Works, Tested in plasmoidviewer and desktop Thanks, Bhushan Shah

Review Request 112223: Enable FileBrowser DataEngine

2013-08-23 Thread Bhushan Shah
/filebrowserengine.cpp 2387bee Diff: http://git.reviewboard.kde.org/r/112223/diff/ Testing --- Compiles = check Plasma Engine explorer = Check Thanks, Bhushan Shah

Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-24 Thread Bhushan Shah
ng --- Testing compilation - check installation - check plasmoidviewer - check in panel - check independently - check Thanks, Bhushan Shah

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-24 Thread Bhushan Shah
e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/#review38481 ------- On Aug. 24, 2013, 2 p.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/11

Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget

2013-08-24 Thread Bhushan Shah
ly - it might be treating a symptom > > instead of addressing the root cause. > > Bhushan Shah wrote: > Are you sure that this happens on 32 bit only? > > Eike Hein wrote: > No, I'm not - except I can't reproduce it on any of my 64 bit machines, > an

Review Request 112260: Enable Dict DataEngine on KF5

2013-08-25 Thread Bhushan Shah
/diff/ Testing --- Compiles - check Installs - check Engine Explorer - check Functions - check Thanks, Bhushan Shah

Re: Review Request 112260: Enable Dict DataEngine on KF5

2013-08-26 Thread Bhushan Shah
Diff: http://git.reviewboard.kde.org/r/112260/diff/ Testing --- Compiles - check Installs - check Engine Explorer - check Functions - check Thanks, Bhushan Shah