Accessibility content

2011-04-20 Thread Jeremy Whiting
themes in kdeaccessibility/ColorSchemes that I propose we move into kde-workspace/kcontrol/colors with the other color schemes. Losing their history shouldn't be a problem in my opinion. If there are no objections I'll make the proposed moves in a week (April 27th). Best Regards, Jeremy Whiting

Re: Accessibility content

2011-04-26 Thread Jeremy Whiting
Ok, so nobody objected, so I migrated IconThemes/mono into kdeartwork/IconThemes and ColorSchemes/Zion and ZionReversed into kdeartwork/ColorSchemes just now. Enjoy. Jeremy On Wed, Apr 20, 2011 at 3:39 PM, Jeremy Whiting jpwhit...@kde.org wrote: Hey all, In preparation for kdeaccessibility

Re: [Kde-accessibility] Re: Accessibility content

2011-04-26 Thread Jeremy Whiting
On Tue, Apr 26, 2011 at 11:35 AM, Olaf Schmidt-Wischhöfer ojschm...@kde.org wrote: Hi Jeremy, Ok, so nobody objected, so I migrated IconThemes/mono into kdeartwork/IconThemes and ColorSchemes/Zion and ZionReversed into kdeartwork/ColorSchemes just now. Enjoy. No objection from my

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-04-29 Thread Jeremy Whiting
On Mon, Apr 25, 2011 at 4:54 PM, Olivier Goffart ogoff...@kde.org wrote: Le Monday 25 April 2011, Michael Pyne a écrit : On Sunday, April 24, 2011 16:42:22 Christoph Feck wrote: On Sunday 24 April 2011 15:04:38 Thiago Macieira wrote: Olivier, these are your moc changes. Given that

Re: Review kdelibs whiting/fixQByteArrays

2011-04-29 Thread Jeremy Whiting
On Apr 29, 2011 6:26 PM, David Faure fa...@kde.org wrote: On Friday 29 April 2011, Jeremy Whiting wrote: Since David added QT_USE_FAST_OPERATOR_PLUS to our build rules for kdelibs, it wont build here. Oops? I've got a commit on the whiting/fixQByteArrays that fixes this, but I'd like

Re: Review kdelibs whiting/fixQByteArrays

2011-05-12 Thread Jeremy Whiting
Ok, I cleaned this up, redid it basically with the suggestions from this thread. I put a review request on reviewboard, and the code is in kdelibs whiting/buildwithqt48 branch. Enjoy, Jeremy On Mon, May 2, 2011 at 11:37 AM, Olivier Goffart ogoff...@kde.org wrote: Le Monday 02 May 2011, David

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-05-16 Thread Jeremy Whiting
Ping, Anyone know who should/can fix this issue? I've got a hack locally, but a proper fix would be very good imho. Jeremy On Fri, Apr 29, 2011 at 12:50 PM, Jeremy Whiting jpwhit...@kde.org wrote: On Mon, Apr 25, 2011 at 4:54 PM, Olivier Goffart ogoff...@kde.org wrote: Le Monday 25 April

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

2011-06-01 Thread Jeremy Whiting
Until those that know the code get this issue sorted out, I've pasted a small workaround that gets it to build here: http://paste.kde.org/77059/ Jeremy On Wed, Jun 1, 2011 at 2:39 AM, Thiago Macieira thi...@kde.org wrote: On Wednesday, 1 de June de 2011 01:42:13 argonel wrote: This makes a

Re: QComboBox vs KConfigDialogManager

2011-06-01 Thread Jeremy Whiting
On Tue, May 31, 2011 at 11:13 PM, Aaron J. Seigo ase...@kde.org wrote: On Tuesday, May 31, 2011 21:55:59 Jeremy Whiting wrote: 1) Check if the widget has a kcfg_property is set on the widget. If so, use that property's value as the property to record. 2) Check if the widget has a User

Re: -Wunused-but-set-variable warnings

2011-07-08 Thread Jeremy Whiting
On Mon, Jul 4, 2011 at 10:02 AM, Dawit A ada...@kde.org wrote: The following files all contain set but unused variables: kdelibs/kdecore/io/kar.cpp:109:19: warning: variable ‘uid’ set but not used [-Wunused-but-set-variable] kdelibs/kdecore/io/kar.cpp:109:24: warning: variable ‘gid’ set but

Fix kopete/kdenetwork build against Qt 4.8

2011-08-04 Thread Jeremy Whiting
Hello, Qt 4.8 has a change to moc which makes virtual inheritance from QObject no longer possible. This caused a problem in Jovie that was fixed by not virtually inheriting from QObject anymore. There is a similar compile problem in kdenetwork/kopete/libkopete at the moment and the attached

Re: Summary from Buildsystem BoF at Desktop Summit

2011-08-16 Thread Jeremy Whiting
On Mon, Aug 15, 2011 at 3:31 PM, Alexander Neundorf neund...@kde.orgwrote: ** snip - 7) (Getting rid of) kdeinit - There was a discussion about what makes a KDE application different from a non-KDE

Re: Git migration status (Was: Re: Where is kmix hidden?)

2011-08-19 Thread Jeremy Whiting
On Fri, Aug 19, 2011 at 1:27 PM, John Layt jl...@kde.org wrote: On Friday 19 Aug 2011 19:54:21 Harald Sitter wrote: On Fri, Aug 19, 2011 at 6:54 PM, Lukas Appelhans l.appelh...@gmx.de wrote: I guess there were no efforts yet from the kdemultimedia team to make the move. I did not

Re: Git migration status (Was: Re: Where is kmix hidden?)

2011-08-22 Thread Jeremy Whiting
On Sun, Aug 21, 2011 at 5:06 PM, Lukas Appelhans l.appelh...@gmx.de wrote: On Sunday 21 August 2011 23:13:30 George Goldberg wrote: On 21 August 2011 14:05, Lukas Appelhans l.appelh...@gmx.de wrote: Hey! Cool... I see you go for a split up of kdenetwork (makes sense imo). Yup.

Re: git workflow draft

2011-08-22 Thread Jeremy Whiting
On Tue, Feb 15, 2011 at 10:51 AM, Aaron J. Seigo ase...@kde.org wrote: hi all so after the meeting on Sunday, here is where we are in terms of a draft workflow. more complete meeting minutes can be seen here: http://titanpad.com/SnJwFW2iXL the goal of the meeting was to come up

Re: git workflow draft

2011-08-23 Thread Jeremy Whiting
On Tue, Aug 23, 2011 at 12:38 AM, Ben Cooksley bcooks...@kde.org wrote: On Tue, Aug 23, 2011 at 6:15 PM, Aaron J. Seigo ase...@kde.org wrote: On Monday, August 22, 2011 11:33:49 Jeremy Whiting wrote: Was this decided upon at some point? I got conflicting stories fromsysadmin and other

Re: git workflow draft

2011-08-24 Thread Jeremy Whiting
On Wed, Aug 24, 2011 at 5:29 AM, Thomas Zander zan...@kde.org wrote: On Wednesday 24 August 2011 06.20.06 Torgny Nyblom wrote: My vote goes for the X.Y scheme as the repo is already under the KDE namespace. That information is lost as soon as the repository is cloned, though. As disc and

Re: git workflow draft

2011-08-31 Thread Jeremy Whiting
Ok it seems most people with a preference prefer KDE/X.Y over X.Y and for valid reasons 1) Other non-kde blessed branches can have obvious names. 2) Kdelibs, base, etc. are already KDE/X.Y 3) More modules are already KDE/X.Y than X.Y so less to fix when enforcing consistency. (after looking at

Re: git workflow draft

2011-08-31 Thread Jeremy Whiting
I forgot to mention some details about my proposal. See below. On Wed, Aug 31, 2011 at 9:07 AM, Jeremy Whiting jpwhit...@kde.org wrote: Ok it seems most people with a preference prefer KDE/X.Y over X.Y and for valid reasons 1) Other non-kde blessed branches can have obvious names. 2) Kdelibs

Re: Renaming X.Y branches to KDE/X.Y

2011-09-16 Thread Jeremy Whiting
Albert, Since you are a project manager for okular and mobipocket, would you do the branch renames on those two repositories sometime. Those are the last remaining repositories with X.Y naming. In addition to updating the i18n branch settings when you do would you update

Re: Re: Renaming X.Y branches to KDE/X.Y

2011-09-16 Thread Jeremy Whiting
On Fri, Sep 16, 2011 at 11:03 AM, Albert Astals Cid aa...@kde.org wrote: A Divendres, 16 de setembre de 2011, Jeremy Whiting vàreu escriure: Albert, Since you are a project manager for okular and mobipocket, would you do the branch renames on those two repositories sometime.  Those

Re: Re: Renaming X.Y branches to KDE/X.Y

2011-09-16 Thread Jeremy Whiting
, 2011 at 5:06 AM, Jeremy Whiting jpwhit...@kde.org wrote: On Fri, Sep 16, 2011 at 11:03 AM, Albert Astals Cid aa...@kde.org wrote: A Divendres, 16 de setembre de 2011, Jeremy Whiting vàreu escriure: Albert, Since you are a project manager for okular and mobipocket, would you do the branch

Re: Frameworks mailing list

2011-11-22 Thread Jeremy Whiting
On Tue, Nov 22, 2011 at 9:28 AM, Alexander Neundorf neund...@kde.org wrote: On Tuesday 22 November 2011, Alex Merry wrote: On 20/11/11 20:57, Albert Astals Cid wrote: This sounds like a If you are going to disagree we don't want you in mantra, which is kind of worrying. I think it's more

Re: How Can I change wallpaper from CLI?

2012-09-05 Thread Jeremy Whiting
On Wed, Sep 5, 2012 at 11:30 AM, Alexander Neundorf neund...@kde.org wrote: On Wednesday 05 September 2012, Shaun Reich wrote: On Wed, Sep 5, 2012 at 10:53 AM, Tomaz Canabrava tcanabr...@kde.org wrote: 2012/9/5 Weng Xuetian wen...@gmail.com: On Wed, Sep 5, 2012 at 9:48 AM, kevinzhow

Re: Techbase: schedules for playground and extragear

2013-06-05 Thread Jeremy Whiting
I'm not terribly involved here as I don't maintain anything in extragear or work on translations of such, but I agree with Luigi that if there are schedules for each of those projects elsewhere we ought to replace that page's content with links to the places that have the official schedules. My

Fixing plasma theme removal

2013-08-02 Thread Jeremy Whiting
Hello, Today I applied and pushed a fix to make uninstalling from KNS3 for most cases work again, however https://bugs.kde.org/show_bug.cgi?id=149479 is still broken for plasma theme uninstallation and here's why: PlasmaStructure doesn't accept application/x-xz-compressed-tar format files which

Re: Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only subfolder of extracted plasmapkg archives

2013-10-14 Thread Jeremy Whiting
: http://git.reviewboard.kde.org/r/112129/diff/ Testing --- The bug is fixed here with this and my other patch. Any better ideas for getting the only subdirectory are welcome, it feels a bit kludgy as is. Thanks, Jeremy Whiting

Re: Review Request 113839: kcmshell: change internal references to kcmshell5

2013-11-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113839/#review43692 --- Ship it! - Jeremy Whiting On Nov. 13, 2013, 7:36 a.m

Review Request 118816: Don't crash konsole when a container destructs

2014-06-18 Thread Jeremy Whiting
://git.reviewboard.kde.org/r/118816/diff/ Testing --- Manual testing, it seems to work fine. Thanks, Jeremy Whiting

Re: Review Request 118816: Don't crash konsole when a container destructs

2014-06-18 Thread Jeremy Whiting
://git.reviewboard.kde.org/r/118816/diff/ Testing --- Manual testing, it seems to work fine. Thanks, Jeremy Whiting

Re: Review Request 118816: Don't crash konsole when a container destructs

2014-06-18 Thread Jeremy Whiting
: https://git.reviewboard.kde.org/r/118816/#review60442 --- On June 18, 2014, 1:24 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 118816: Don't crash konsole when a container destructs

2014-06-18 Thread Jeremy Whiting
generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118816/#review60445 --- On June 18, 2014, 1:24 p.m., Jeremy Whiting wrote: --- This is an automatically generated e

Re: Review Request 118816: Don't crash konsole when a container destructs

2014-06-18 Thread Jeremy Whiting
. Diffs - src/ViewSplitter.h c1e4552 src/ViewSplitter.cpp bfc727e src/ViewContainer.cpp 79c24d5 Diff: https://git.reviewboard.kde.org/r/118816/diff/ Testing --- Manual testing, it seems to work fine. Thanks, Jeremy Whiting

Re: Review Request 118816: Don't crash konsole when a container destructs

2014-06-18 Thread Jeremy Whiting
, Jeremy Whiting

Re: Review Request 118816: Don't crash konsole when a container destructs

2014-06-19 Thread Jeremy Whiting
of a tab in yakuake and on closing a tab in konsole. Diffs - src/ViewSplitter.h c1e4552 src/ViewSplitter.cpp bfc727e src/ViewContainer.cpp 79c24d5 Diff: https://git.reviewboard.kde.org/r/118816/diff/ Testing --- Manual testing, it seems to work fine. Thanks, Jeremy Whiting

Updating our tools

2014-09-23 Thread Jeremy Whiting
Hello all, Since some of our applications and our workspace will be updated for the next major release (14.12 is the name iirc) to use Qt5 and KDE Frameworks I thought I would check englishbreakfastnetwork.org code checker of kanagram (which has master branch based on qt5 and kf5).

Re: Updating our tools

2014-09-23 Thread Jeremy Whiting
, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 23 de setembre de 2014, a les 15:56:58, Jeremy Whiting va escriure: Hello all, Since some of our applications and our workspace will be updated for the next major release (14.12 is the name iirc) to use Qt5 and KDE Frameworks I thought I would

Re: Updating our tools

2014-09-24 Thread Jeremy Whiting
PM Jeremy Whiting wrote: Albert, I can take a look at it if someone points me in the right direction. I also found this: http://ebn.kde.org/krazy/reports/frameworks-5.x/kdelibs/knewstuff/index.html which seems to check the right way for frameworks suggestions, but it hasn't been ran since Dec

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

2014-10-05 Thread Jeremy Whiting
On Sun, Oct 5, 2014 at 12:30 PM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 3 d'octubre de 2014, a les 03:28:44, Aleix Pol va escriure: On Fri, Oct 3, 2014 at 1:52 AM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 3 d'octubre de 2014, a les 00:04:42, Aleix Pol va escriure:

kompare, libkomparediff2 and KDE Applications 14.12

2014-10-07 Thread Jeremy Whiting
Kevin, Others, Libkomparediff2 has been ported to kf5 for quite some time, kdevelop or kdevplatform frameworks based code (not sure if it's master or frameworks branches) uses it and it seems to work ok there. I wonder when we should merge libkomparediff2's frameworks branch into master though.

Re: kompare, libkomparediff2 and KDE Applications 14.12

2014-10-07 Thread Jeremy Whiting
Kevin, On Tue, Oct 7, 2014 at 4:30 PM, Kevin Kofler kevin.kof...@chello.at wrote: Hi, On Tuesday 07 October 2014 at 15:59:17, Jeremy Whiting wrote: Libkomparediff2 has been ported to kf5 for quite some time, kdevelop or kdevplatform frameworks based code (not sure if it's master

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
that are const and deprecate these non-const ones instead. Thanks, Jeremy Whiting

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120535/#review68095 --- On Oct. 8, 2014, 3:20 p.m., Jeremy Whiting wrote

Re: kompare, libkomparediff2 and KDE Applications 14.12

2014-10-08 Thread Jeremy Whiting
K, sounds like we've agreed then, libkomparediff2 frameworks branch wont merge to master until some time after 14.12 is tagged and such. If I find a few minutes I'll take a look at improving the api and such as Aleix noted. BR, Jeremy On Wed, Oct 8, 2014 at 3:25 PM, Kevin Kofler

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
or not is for someone else to answer. Jeremy Whiting wrote: Yes, I saw that, the real question is if we allow BIC changes or not. Also I guess if we don't allow BIC changes in frameworks anymore we should change that page to not say BIC changes should all happen on Monday's anymore :) Aleix Pol

Re: kompare, libkomparediff2 and KDE Applications 14.12

2014-10-08 Thread Jeremy Whiting
Aleix, Yes, master is what will be released with KDE Applications 14.12 so it needs to stay qt4 based for now since kompare itself will be in this upcoming release. BR, Jeremy On Wed, Oct 8, 2014 at 4:14 PM, Kevin Kofler kevin.kof...@chello.at wrote: On Thursday 09 October 2014 at 00:12:03,

kdelibs coding style.

2014-10-08 Thread Jeremy Whiting
Hey all, In updating some frameworks I took a look at the kdelibs coding style (Is there a frameworks coding style, if not maybe it should be created?) and especially the Qt Includes section seems a bit backwards from what I see in actual code in frameworks.

oldish websites

2014-10-10 Thread Jeremy Whiting
Hey all, The other day we moved accessibility.kde.org's content from svn to git. I got an rsync of svn and made the simple rules and got it done. Since I have a setup now I thought I'd go through the rest of the websites currently at http://websvn.kde.org/trunk/www/sites/ and migrate/kill the

Re: oldish websites

2014-10-10 Thread Jeremy Whiting
Ok, the obvious ones are done. On Fri, Oct 10, 2014 at 1:59 PM, Jeremy Whiting jpwhit...@kde.org wrote: Hey all, The other day we moved accessibility.kde.org's content from svn to git. I got an rsync of svn and made the simple rules and got it done. Since I have a setup now I thought I'd go

Review Request 120554: Initial frameworks port of kompare

2014-10-10 Thread Jeremy Whiting
need to play with the filters etc. Thanks, Jeremy Whiting

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-13 Thread Jeremy Whiting
wasn't showing files I expected to see though, may need to play with the filters etc. Also ported from KGlobal::ref() and KGlobal::unref() to QEventLoopLocker, though quitting one window closes all windows, not sure if that's expected or not. Thanks, Jeremy Whiting

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-14 Thread Jeremy Whiting
and folders. The QFileDialog it uses wasn't showing files I expected to see though, may need to play with the filters etc. Also ported from KGlobal::ref() and KGlobal::unref() to QEventLoopLocker, though quitting one window closes all windows, not sure if that's expected or not. Thanks, Jeremy

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-15 Thread Jeremy Whiting
. Also ported from KGlobal::ref() and KGlobal::unref() to QEventLoopLocker, though quitting one window closes all windows, not sure if that's expected or not. Thanks, Jeremy Whiting

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-16 Thread Jeremy Whiting
wasn't showing files I expected to see though, may need to play with the filters etc. Also ported from KGlobal::ref() and KGlobal::unref() to QEventLoopLocker, though quitting one window closes all windows, not sure if that's expected or not. Thanks, Jeremy Whiting

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-16 Thread Jeremy Whiting
::unref() to QEventLoopLocker, though quitting one window closes all windows, not sure if that's expected or not. Thanks, Jeremy Whiting

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-16 Thread Jeremy Whiting
with the filters etc. Also ported from KGlobal::ref() and KGlobal::unref() to QEventLoopLocker, though quitting one window closes all windows, not sure if that's expected or not. Thanks, Jeremy Whiting

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-16 Thread Jeremy Whiting
. Also ported from KGlobal::ref() and KGlobal::unref() to QEventLoopLocker, though quitting one window closes all windows, not sure if that's expected or not. Thanks, Jeremy Whiting

Review Request 120627: Remove kdelibs4support.

2014-10-17 Thread Jeremy Whiting
://git.reviewboard.kde.org/r/120627/diff/ Testing --- It builds and runs. The compare dialog ui looks squished though and doesn't resize like it used to, must be something I did wrong when porting away from KVBox Thanks, Jeremy Whiting

Review Request 120630: Port from KTempDir to QTemporaryDir. Port from KUrl to QUrl.

2014-10-17 Thread Jeremy Whiting
and an updated kompare frameworks branch builds against it and runs. Thanks, Jeremy Whiting

Re: Review Request 120630: Port from KTempDir to QTemporaryDir. Port from KUrl to QUrl.

2014-10-17 Thread Jeremy Whiting
--- It builds and an updated kompare frameworks branch builds against it and runs. Thanks, Jeremy Whiting

Re: Review Request 120627: Remove kdelibs4support.

2014-10-17 Thread Jeremy Whiting
porting away from KVBox Thanks, Jeremy Whiting

Re: Review Request 120627: Remove kdelibs4support.

2014-10-17 Thread Jeremy Whiting
://git.reviewboard.kde.org/r/120627/diff/ Testing --- It builds and runs. The compare dialog ui looks squished though and doesn't resize like it used to, must be something I did wrong when porting away from KVBox Thanks, Jeremy Whiting

Re: Review Request 120627: Remove kdelibs4support.

2014-10-17 Thread Jeremy Whiting
to, must be something I did wrong when porting away from KVBox Thanks, Jeremy Whiting

Re: Review Request 120627: Remove kdelibs4support.

2014-10-17 Thread Jeremy Whiting
://git.reviewboard.kde.org/r/120627/#review68628 --- On Oct. 17, 2014, 9:40 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 120627: Remove kdelibs4support.

2014-10-17 Thread Jeremy Whiting
did wrong when porting away from KVBox Thanks, Jeremy Whiting

Re: Review Request 120627: Remove kdelibs4support.

2014-10-17 Thread Jeremy Whiting
be something I did wrong when porting away from KVBox Thanks, Jeremy Whiting

Re: Review Request 120627: Remove kdelibs4support.

2014-10-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627/#review68642 --- On Oct. 17, 2014, 11:01 p.m., Jeremy Whiting wrote

Re: Review Request 120627: Remove kdelibs4support.

2014-10-18 Thread Jeremy Whiting
like it used to, must be something I did wrong when porting away from KVBox Thanks, Jeremy Whiting

Re: Review Request 120627: Remove kdelibs4support.

2014-10-18 Thread Jeremy Whiting
KVBox Thanks, Jeremy Whiting

Review Request 120652: Remove kdemacros.h and use generate_export_header for interfaces folder.

2014-10-18 Thread Jeremy Whiting
eed5c85eb4e4c091df2f32e58d3183600ca3a8c0 Diff: https://git.reviewboard.kde.org/r/120652/diff/ Testing --- Still builds and runs as expected. Thanks, Jeremy Whiting

Re: Review Request 120627: Remove kdelibs4support.

2014-10-18 Thread Jeremy Whiting
19th, 2014, 12:13 a.m. CEST, Jeremy Whiting wrote: Review request for kdelibs and Kevin Kofler. By Jeremy Whiting. *Updated Oct. 19, 2014, 12:13 a.m.* *Repository: * kompare Description Change KUrl to QUrl. Use QLayout/QFrame instead of KVBox (seems broken though somehow) Use QFileDialog

Re: Review Request 120652: Remove kdemacros.h and use generate_export_header for interfaces folder.

2014-10-19 Thread Jeremy Whiting
/kompareinterface.h 07a271d0844767a2fee5af3e985c1b05d3640f05 interfaces/kompareinterfaceexport.h eed5c85eb4e4c091df2f32e58d3183600ca3a8c0 Diff: https://git.reviewboard.kde.org/r/120652/diff/ Testing --- Still builds and runs as expected. Thanks, Jeremy Whiting

Re: Review Request 120630: Port from KTempDir to QTemporaryDir. Port from KUrl to QUrl.

2014-10-19 Thread Jeremy Whiting
://git.reviewboard.kde.org/r/120630/diff/ Testing --- It builds and an updated kompare frameworks branch builds against it and runs. Thanks, Jeremy Whiting

Review Request 120676: Remove other kdelibs4support headers

2014-10-20 Thread Jeremy Whiting
://git.reviewboard.kde.org/r/120676/diff/ Testing --- It builds and runs, but I'm not sure if I got all of the kdelibs4support stuff since I have kdelibs headers in /usr/include here. I'll do further cleanup on a vm witohut kdelibs to check later on. Thanks, Jeremy Whiting

Re: Review Request 120627: Remove kdelibs4support.

2014-10-20 Thread Jeremy Whiting
- Hrvoje On October 19th, 2014, 12:13 a.m. CEST, Jeremy Whiting wrote: Review request for kdelibs and Kevin Kofler. By Jeremy Whiting. *Updated Oct. 19, 2014, 12:13 a.m.* *Repository: * kompare Description Change KUrl to QUrl. Use QLayout/QFrame instead of KVBox (seems broken though

Re: Review Request 120676: Remove other kdelibs4support headers

2014-10-21 Thread Jeremy Whiting
on a vm witohut kdelibs to check later on. Thanks, Jeremy Whiting

Review Request 120697: Remove one last klocale.h include.

2014-10-21 Thread Jeremy Whiting
Description --- Remove one last klocale.h include. Diffs - komparenavtreepart/komparenavtreepart.cpp f5a7f9fc8df9b9ee330ebfad1fb57835aadaca7f Diff: https://git.reviewboard.kde.org/r/120697/diff/ Testing --- It still builds and runs. Thanks, Jeremy Whiting

Re: Review Request 120697: Remove one last klocale.h include.

2014-10-21 Thread Jeremy Whiting
/diff/ Testing --- It still builds and runs. Thanks, Jeremy Whiting

Re: Kdepim* master will not release with 4.14.12

2014-10-27 Thread Jeremy Whiting
Everyone keeps perpetuating this typo. There is no 4.14.12. Wednesday will be 14.12 freeze, which will become the beta. Thursday 4.14.3 will be tagged. On Mon, Oct 27, 2014 at 2:32 AM, laurent Montel mon...@kde.org wrote: Hi, Finally there is still more work to do. So we can't release kdepim

KConfigDialog

2014-10-27 Thread Jeremy Whiting
Hello, Is there a way to have custom settings mixed with kcfg_ type settings in a KConfigDialog? Kanagram does this, but it only works when another kcfg_ named widget changes too. The combobox to select which language to use gets saved to disk by a slot that's connected to KConfigDialog's

Re: KConfigDialog

2014-10-29 Thread Jeremy Whiting
d'octubre de 2014, a les 22:22:12, Jeremy Whiting va escriure: Hello, Is there a way to have custom settings mixed with kcfg_ type settings in a KConfigDialog? Kanagram does this, but it only works when another kcfg_ named widget changes too. The combobox to select which language to use gets

Re: Ksshaskpass ?

2014-11-03 Thread Jeremy Whiting
ksshaskpass has no more krazy issues and has been moved to kdereview. I think it's final resting place should be kde/workspace but I'm open to other ideas. It is usable on other platforms besides plasma, but it saves passwords in kwallet, so may make the most sense there. thanks, Jeremy P.S. We

autostart confusion

2014-11-06 Thread Jeremy Whiting
Hey all, In kdelibs4 times one used to be able to put any script into ~/.kde/Autostart/ make it executable and when startkde ran it would launch those scripts. In kf5/plasma next time ~/.config/autostart should be able to do likewise, but doesn't seem to. On one hand the autostart kcm shows

Re: autostart confusion

2014-11-06 Thread Jeremy Whiting
Answering myself in case anyone is interested in the cause and possible solutions. I discussed this with Luca this evening and problem cause and possible solutions are on the plasma-devel list. On Thu, Nov 6, 2014 at 10:01 PM, Jeremy Whiting jpwhit...@kde.org wrote: Hey all, In kdelibs4 times

Re: autostart confusion

2014-11-07 Thread Jeremy Whiting
: On Thursday 06 November 2014 22:01:13 Jeremy Whiting wrote: Hey all, In kdelibs4 times one used to be able to put any script into ~/.kde/Autostart/ make it executable and when startkde ran it would launch those scripts. In kf5/plasma next time ~/.config/autostart should be able to do likewise

Re: autostart confusion

2014-11-07 Thread Jeremy Whiting
...@gmail.com wrote: On Freitag, 7. November 2014 21:28:15 CEST, Jeremy Whiting wrote: The way I see it this should be documented well, and the kcm needs to be adjusted to not show scripts from ~/.config/autostart since kinit wont be starting those. http://standards.freedesktop.org/autostart-spec

Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.

2014-11-07 Thread Jeremy Whiting
/autostart/ doesn't appear in the kcm here anymore. Thanks, Jeremy Whiting

attica_kde.so closing crash

2014-11-16 Thread Jeremy Whiting
Hey all, I recently fixed attica's plugin loading so it now finds and loads the attica_kde.so plugin but when applications using knewstuff (and thus attica) close it's giving a segfault when the PlatformDependent object is destructed. I've not done much at all with plugins in the past, but I've

Re: attica_kde.so closing crash

2014-11-16 Thread Jeremy Whiting
to see the code. I don't have any local changes besides adding qDebug() lines. On Sun, Nov 16, 2014 at 6:09 PM, Jeremy Whiting jpwhit...@kde.org wrote: I'm not deleting anything in the destructor except m_wallet which is a KWallet. The crash is in the base class destructor QNetworkAccessManager

Re: attica_kde.so closing crash

2014-11-17 Thread Jeremy Whiting
Thomas, Thanks for the pointer. I tried changing KIO::AccessManager's destructor to this: AccessManager::~AccessManager() { QObjectList childList = children(); Q_FOREACH(QObject *child, childList) { QNetworkReply *reply = qobject_castQNetworkReply*(child); if (reply != 0)

Re: attica_kde.so closing crash

2014-11-17 Thread Jeremy Whiting
Ok, how can I fix the unload order then? On Mon, Nov 17, 2014 at 12:02 PM, Thiago Macieira thi...@kde.org wrote: On Sunday 16 November 2014 18:18:07 Jeremy Whiting wrote: ==22353== Address 0x1cd1b758 is not stack'd, malloc'd or (recently) free'd This looks like the case of accessing

Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Jeremy Whiting
/ Testing --- knewstuff tests no longer crash on close. Thanks, Jeremy Whiting

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Jeremy Whiting
://git.reviewboard.kde.org/r/121161/diff/ Testing --- knewstuff tests no longer crash on close. Thanks, Jeremy Whiting

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Jeremy Whiting
/#review70542 --- On Nov. 17, 2014, 2:11 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121161

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-18 Thread Jeremy Whiting
the leak would really matter) If not, then yes: superfluous complication. Jeremy Whiting wrote: Did I hear a Ship it! in there somewhere? Thomas Lübking wrote: Leaving aside that don't maintain the attica plugin, you have a +1 from here, IF a) the conditional reparent

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-18 Thread Jeremy Whiting
489c03b18b7bb940007ab51cb197105fbc25de9f Diff: https://git.reviewboard.kde.org/r/121161/diff/ Testing --- knewstuff tests no longer crash on close. Thanks, Jeremy Whiting

Adventures in Bodega

2014-11-22 Thread Jeremy Whiting
Hello list, I realize this list will reach many more people than could probably answer, but the -active list seems to be dead from what I hear, so I thought I'd try here. In looking into bodega as a successor to opendesktop and ocs I've tried to setup a local bodega instance on my machine. The

Re: Adventures in Bodega

2014-11-24 Thread Jeremy Whiting
to the session.Store.prototype while session.Store is undefined. main.sh thus doesn't run with the error message I pasted in the original mail. On Mon, Nov 24, 2014 at 3:41 AM, Aaron J. Seigo ase...@kde.org wrote: On Saturday, November 22, 2014 07.56:39 Jeremy Whiting wrote: getting an error inside the node redis module

QIcon::fromTheme on non linux platforms

2014-12-09 Thread Jeremy Whiting
Hey all, In looking into building some kde applications on windows and mac besides linux I've come across a minor hiccup. In many applications and frameworks possibly we use QIcon::fromTheme to get icons from a named icon. This is even recommended in the kf5 porting notes, however on non linux

Re: Ksshaskpass ?

2014-12-11 Thread Jeremy Whiting
ksshaskspass has been in kdereview and has been improved since it got there. Is it ready to be moved to kde/workspace ? On Wed, Nov 5, 2014 at 12:50 PM, David Faure fa...@kde.org wrote: [cutting down on the massive cross-posting] On Monday 03 November 2014 14:13:50 Jeremy Whiting wrote

  1   2   >