Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

2013-01-09 Thread Martin Gräßlin
, Plasma, Aaron J. Seigo, and Martin Gräßlin. Changes --- added plasma to CC group - I think they should be in to comment on it. Description --- When setting Keep window thumbnails to Always (Breaks minimization), kwin will keep WM_STATE to be NORMAL when a client is minimized while

Re: New lockscreen

2013-01-10 Thread Martin Gräßlin
On Thursday 10 January 2013 19:37:57 Martin Sandsmark wrote: Hi! The new lock screen has some more or less serious regressions, and doesn't seem to be maintained by anyone in particular (one of the regression bugs filed against it is from november, and I don't really see anyone in

Re: Re: New lockscreen

2013-01-11 Thread Martin Gräßlin
On Friday 11 January 2013 09:28:19 Martin Sandsmark wrote: Well, the old one managed to be both, so IMHO if we remove features it is a regression (though which ones are you talking about?). no, removing features is not a regression. It is the decision to remove the feature. The use case for

Re: Re: Re: New lockscreen

2013-01-11 Thread Martin Gräßlin
On Friday 11 January 2013 10:12:13 Martin Sandsmark wrote: On Fri, Jan 11, 2013 at 09:49:06AM +0100, Martin Gräßlin wrote: no, removing features is not a regression. It is the decision to remove the feature. The use case for screen savers does no longer exist or when did you last have

Re: Re: Re: Re: New lockscreen

2013-01-11 Thread Martin Gräßlin
On Friday 11 January 2013 10:47:40 Martin Sandsmark wrote: On Fri, Jan 11, 2013 at 10:28:22AM +0100, Martin Gräßlin wrote: and what has protecting the screen against burn-ins to do with security? Nothing, right. Which is why the lock screen has usually been activated separately from

Re: Re: Re: Re: Re: Re: New lockscreen

2013-01-11 Thread Martin Gräßlin
On Friday 11 January 2013 13:49:00 Martin Sandsmark wrote: On Fri, Jan 11, 2013 at 01:23:04PM +0100, Martin Gräßlin wrote: On Fri, Jan 11, 2013 at 11:37:43AM +0100, Martin Gräßlin wrote: Which is why the lock screen has usually been activated separately from the screensaver

Re: Color Management in KDE

2013-01-21 Thread Martin Gräßlin
and if such an abstraction helps to get color correction to more users it's the way to go. -- Martin Gräßlin signature.asc Description: This is a digitally signed message part.

Review Request 108808: Do not reset opacity if call for GetWindowProperty fails

2013-02-06 Thread Martin Gräßlin
: 314427 FIXED-IN: 4.10.1 Diffs - kdeui/windowmanagement/netwm.cpp cf28339f90dff1d17ed17842c7c11d8a9718a459 Diff: http://git.reviewboard.kde.org/r/108808/diff/ Testing --- Thanks, Martin Gräßlin

Re: Re: Login for bug reporting

2013-02-07 Thread Martin Gräßlin
from recognizing whether a backtrace is useful. -- Martin Gräßlin signature.asc Description: This is a digitally signed message part.

Re: Re: Login for bug reporting

2013-02-07 Thread Martin Gräßlin
and look at the report. There is multiple times written that we don't want any further comments on the bug and that doesn't help anything. Still attachements, still duplicates. -- Martin Gräßlin signature.asc Description: This is a digitally signed message part.

Re: Re: cxx11-cmake-modules in kdereview

2013-03-01 Thread Martin Gräßlin
then. Can we discuss whether such module should be used? Why can't you use the #defines from QtCore? because we don't use Qt 5 yet? -- Martin Gräßlin signature.asc Description: This is a digitally signed message part.

Review Request 109282: Drop usage of KWindowSystem::doNotMange from KJavaApplet

2013-03-04 Thread Martin Gräßlin
/109282/diff/ Testing --- installed Java, got it somehow magically configured to even have a plugin, found a website, applet is shown. Thanks, Martin Gräßlin

Re: Review Request 109282: Drop usage of KWindowSystem::doNotMange from KJavaApplet

2013-03-04 Thread Martin Gräßlin
4, 2013, 8:29 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109282/ --- (Updated March 4, 2013, 8

Re: Review Request 109282: Drop usage of KWindowSystem::doNotMange from KJavaApplet

2013-03-05 Thread Martin Gräßlin
configured to even have a plugin, found a website, applet is shown. Thanks, Martin Gräßlin

Re: Review Request 109282: Drop usage of KWindowSystem::doNotMange from KJavaApplet

2013-03-12 Thread Martin Gräßlin
it into master. - Martin Gräßlin On March 5, 2013, 7:26 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109282

Re: Review Request 109809: Extend Mesa 9.1 restriction to SandyBridge

2013-04-01 Thread Martin Gräßlin
a SandyBridge myself and are *not* experiencing this issue (just tested again). So a general block all SandyBridge would be too broad. Furthermore I hope that this issue will be resolved upstream till we release 4.9.3 - Martin Gräßlin On April 1, 2013, 2:44 p.m., Michael Palimaka wrote

Re: Review Request 109809: Extend Mesa 9.1 restriction to SandyBridge

2013-04-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109809/ --- (Updated April 1, 2013, 7:17 p.m.) Review request for kde-workspace and

Re: Review Request 109809: Extend Mesa 9.1 restriction to SandyBridge

2013-04-02 Thread Martin Gräßlin
On April 1, 2013, 7:16 p.m., Martin Gräßlin wrote: the SandyBridge situation seems to be more complex. I am using a SandyBridge myself and are *not* experiencing this issue (just tested again). So a general block all SandyBridge would be too broad. Furthermore I hope

Re: Re: Plasma Workspaces 4.11: the last feature release in the 4.x series for kde-workspace

2013-05-03 Thread Martin Gräßlin
the Qt 5 transition in our GSoC applications. For example one of the ideas for KWin explicitly states that it has to be developed with Qt 5. -- Martin Gräßlin signature.asc Description: This is a digitally signed message part.

Re: Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

2013-05-15 Thread Martin Gräßlin
On May 15, 2013, 8:06 a.m., Aaron J. Seigo wrote: I am not in favour of this patch for a couple of reasons. First, there is a port underway to QML which does not need to be delayed further by adding more features. More importantly, however, middle click is a special case of not the

Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-24 Thread Martin Gräßlin
://git.reviewboard.kde.org/media/uploaded/files/2013/05/24/drkonqi-disabled.png Thanks, Martin Gräßlin

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-25 Thread Martin Gräßlin
://git.reviewboard.kde.org/r/110633/#review33110 --- On May 24, 2013, 4:54 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-25 Thread Martin Gräßlin
on a patch for the usability improvement and plan to make it into 4.11. I will create a review request today or tomorrow. [1] https://bugs.kde.org/show_bug.cgi?id=315073#c3 [2] https://bugs.kde.org/show_bug.cgi?id=318769#c1 Martin Gräßlin wrote: Bugzilla itself (since

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-25 Thread Martin Gräßlin
on a patch for the usability improvement and plan to make it into 4.11. I will create a review request today or tomorrow. [1] https://bugs.kde.org/show_bug.cgi?id=315073#c3 [2] https://bugs.kde.org/show_bug.cgi?id=318769#c1 Martin Gräßlin wrote: Bugzilla itself (since

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-25 Thread Martin Gräßlin
on a patch for the usability improvement and plan to make it into 4.11. I will create a review request today or tomorrow. [1] https://bugs.kde.org/show_bug.cgi?id=315073#c3 [2] https://bugs.kde.org/show_bug.cgi?id=318769#c1 Martin Gräßlin wrote: Bugzilla itself (since

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-27 Thread Martin Gräßlin
for this version anymore. File Attachments With it disabled http://git.reviewboard.kde.org/media/uploaded/files/2013/05/24/drkonqi-disabled.png Thanks, Martin Gräßlin

Re: Review Request 110687: DrKonqi should check for disabled version as the very first step in the reporting assistant.

2013-05-28 Thread Martin Gräßlin
not sure whether they like words like unmaintained and upgrade. The fact that we as upstream don't accept bugs doesn't mean it's unmaintained by the distro and it's not said that one could upgrade (think of Debian Stable). - Martin Gräßlin On May 28, 2013, 1:01 p.m., Jekyll Wu wrote

Re: Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

2013-06-16 Thread Martin Gräßlin
On June 15, 2013, 7:06 p.m., Albert Astals Cid wrote: Is this some kind of joke? Honestly upstreaming patches is good, but when they make sense, and adding billions of If #SUSE to our code does not make any sense. Please discard this review, break stuff in separate patches and if

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-22 Thread Martin Gräßlin
On June 22, 2013, 12:58 p.m., Thomas Lübking wrote: kdeui/util/kglobalsettings.cpp, line 308 http://git.reviewboard.kde.org/r/71/diff/1/?file=165092#file165092line308 These are the colors for the window titlbar (with ambiguous function names, though), the default for

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-22 Thread Martin Gräßlin
information. Martin Gräßlin wrote: It's worse - KWin does not just read the values by itself, it reads them from kwinrc instead of kdeglobals. So whatever is set in KGlobalSettings: KWin ignores it. Thomas Lübking wrote: No ;-) Welcome to the magics of KConfig. I for one have

Re: All KConfig files inherit kdeglobals keys by default, good or bad?

2013-06-25 Thread Martin Gräßlin
On Tuesday 25 June 2013 10:10:03 Aurélien Gâteau wrote: Eventually the default actually should have been CascadeOnly (because IncludeGlobals seems mostly interesting to libs only). I agree, especially because I assume all the code which benefits from inheriting from kdeglobals has been

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-07-01 Thread Martin Gräßlin
there. - Martin Gräßlin On July 1, 2013, 1:33 p.m., Patrick von Reth wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-07-01 Thread Martin Gräßlin
-it. This is a decision to the kinfocenter developers whether they are fine with the ifdefs. - Martin Gräßlin On July 1, 2013, 3:14 p.m., Patrick von Reth wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Disable by default KRandR in 4.11

2013-07-03 Thread Martin Gräßlin
On Thursday 04 July 2013 01:06:27 Àlex Fiestas wrote: Hi there I want to propose to disable by default KRandR from kde-workspace release for 4.11. +1 Ideally I would like to remove the source code completely, but I guess we are too late into 4.11 to do such thing. why not? You could replace

Re: Re: openSUSE packagers' take on the 3 month release cycle

2013-07-09 Thread Martin Gräßlin
On Tuesday 09 July 2013 06:33:21 Scott Kitterman wrote: On Tuesday, July 09, 2013 12:05:30 PM Àlex Fiestas wrote: On Monday 08 July 2013 22:01:29 Andrea Scarpino wrote: We don't just run a sed rule on each spec (pkgbuild, in my case) file. We check for new dependencies (resp.

Re: Re: Releases in 3 months

2013-07-09 Thread Martin Gräßlin
On Tuesday 09 July 2013 16:12:35 Andras Mantia wrote: I also find the motivation somewhat contradictory. Yes, you want to provide new features faster, but by cutting down testing time. *Are you sure?* Well here we have to ask whether the current testing procedure works. Since the beta got

Re: Re: KDE/4.11 branched what to do with kde-workspace?

2013-07-10 Thread Martin Gräßlin
On Wednesday 10 July 2013 22:39:29 Thomas Lübking wrote: On Mittwoch, 10. Juli 2013 21:58:34 CEST, Albert Astals Cid wrote: Those who want to develop on or use it will hopefully find it and others can continue to use master as it is. (And where important bugfixes etc. for 4.12 can go)

Re: Review Request 112236: krunner: Add the full name of completion matches to history

2013-08-24 Thread Martin Gräßlin
On Aug. 24, 2013, 12:08 p.m., Thomas Lübking wrote: kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml, line 274 http://git.reviewboard.kde.org/r/112236/diff/1/?file=184315#file184315line274 ... ;-) Harald Hvaal wrote: yeah, not sure what happened with

Re: Review Request 112235: Move focus to search field upon typing from result list

2013-08-24 Thread Martin Gräßlin
in the results list when using those. - Martin Gräßlin On Aug. 24, 2013, 11:45 a.m., Harald Hvaal wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112235

Re: Review Request 112328: Add case sensitive sorting option to KGlobalSettings and KDirSortFilterProxyModel

2013-09-04 Thread Martin Gräßlin
would suggest to not add new API to an already deprecated class. Maybe you want to provide a patch for the proper way in frameworks? - Martin Gräßlin On Aug. 29, 2013, 3:11 p.m., Eugene Shalygin wrote: --- This is an automatically

Re: kde-workspace master becomes Qt5-based

2013-09-24 Thread Martin Gräßlin
On Thursday 19 September 2013 19:30:52 Sebastian Kügler wrote: Hi all, We're planning to merge the frameworks-scratch branch of kde-workspace into master next Monday. That means if you're building your Plasma yourself from Git (and you're not yet ready for Plasma2 ;)), you should switch to

Re: Re: kde-workspace master becomes Qt5-based

2013-09-24 Thread Martin Gräßlin
On Tuesday 24 September 2013 13:51:57 Albert Astals Cid wrote: El Dimarts, 24 de setembre de 2013, a les 11:34:45, Martin Gräßlin va escriure: On Thursday 19 September 2013 19:30:52 Sebastian Kügler wrote: Hi all, We're planning to merge the frameworks-scratch branch of kde

Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-10-17 Thread Martin Gräßlin
On Oct. 17, 2013, 5:11 p.m., Gilles Caulier wrote: Ok, thanks for you feedback. I make patch with git/master, not KDE/4.11 branch. I will checkout this code and adapt patch accordingly Gilles Caulier I make patch with git/master, not KDE/4.11 branch You are aware that master is

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Martin Gräßlin
On Oct. 24, 2013, 6:17 p.m., Fredrik Höglund wrote: What's the cold startup time like for KSplashQML compared to KSplashX? Let's not forget that the reason KPlash was rewritten to only depend on X + libjpeg + libpng was so that the startup time would be limited by the time it takes

Re: kde-workspace git broken ?

2013-11-11 Thread Martin Gräßlin
On Monday 11 November 2013 13:29:32 Hugo Pereira Da Costa wrote: Hello, I think commits 9f70241d57f3ba1013b9f28650478c8bbb1233e0 137dd285bdf821fd2c8a5c17e30dc9c1a6eca87b 09ea308ab55505efe7aeaebcd4aef6292cd884e6 seriously broke kde-workspace yes, it's broken. I already created a sysadmin

Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-11-30 Thread Martin Gräßlin
://git.reviewboard.kde.org/r/114219/ --- (Updated Nov. 30, 2013, 5:38 a.m.) Review request for kde-workspace, David Faure, Martin Gräßlin, and Hugo Pereira Da Costa. Bugs: 327919 http://bugs.kde.org/show_bug.cgi?id=327919

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-07 Thread Martin Gräßlin
(that is no screensaver)? - Martin Gräßlin On Jan. 5, 2014, 9:55 a.m., Wolfgang Bauer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-07 Thread Martin Gräßlin
merge to master and fix the merge conflict I expect to see :-) I merged 4.11 into master yesterday so there should no be anything else which could conflict. - Martin Gräßlin On Jan. 5, 2014, 9:55 a.m., Wolfgang Bauer wrote

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-08 Thread Martin Gräßlin
On Jan. 8, 2014, 8:10 a.m., Martin Gräßlin wrote: If you have the possibility (build setup) please merge to master and fix the merge conflict I expect to see :-) I merged 4.11 into master yesterday so there should no be anything else which could conflict. Wolfgang Bauer wrote: I

Re: Review Request 110813: Add support for just smooth window movement and resizing to wobbly windows effect

2014-01-08 Thread Martin Gräßlin
excuse again the long time for the review. - Martin Gräßlin On June 3, 2013, 9:55 p.m., Stefanos Harhalakis wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110813

Re: Review Request 115001: add kf5 namespace to kglobalaccel dbus interface

2014-01-13 Thread Martin Gräßlin
to kglobalacceld from KF5? - Martin Gräßlin On Jan. 13, 2014, 4:51 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115001

Re: Review Request 114999: Add KF5 namespace to dbus interface

2014-01-14 Thread Martin Gräßlin
idea as that breaks any communication with the kdelibs4. - Martin Gräßlin On Jan. 14, 2014, 4:21 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114999

Re: Review Request 114999: Add KF5 namespace to dbus interface

2014-01-14 Thread Martin Gräßlin
On Jan. 14, 2014, 8:22 p.m., Martin Gräßlin wrote: like with the other patch I'm not sure whether that's a good idea as that breaks any communication with the kdelibs4. Thomas Lübking wrote: is there a functional incompitibility between SC4 and KF5 that requires

Re: Qt 5.3 to log all debug/warning/error messages to journald on systemd systems

2014-01-20 Thread Martin Gräßlin
. KDE applications are the largest users of qDebug today. If we changed the default, it would mean ~/.xsession-errors would probably become rather empty. Is that ok for KDE? I like this +1 -- Martin Gräßlin signature.asc Description: This is a digitally signed message part.

Re: Review Request 115079: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Martin Gräßlin
for kgloballacel: I consider copying the files to every user as the wrong solution. In Qt terms I would give it a -2. - Martin Gräßlin On Jan. 21, 2014, 1:48 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail

Re: Review Request 115079: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115079/#review47882 --- much better! Thanks for working on it. - Martin Gräßlin

Re: Re: Splitting kde-workspace and kde-runtime proposal

2014-01-22 Thread Martin Gräßlin
On Tuesday 21 January 2014 13:12:58 David Hubner wrote: In the plasma sprint we have done a session to plan what we are going to do with kde-workspace/kde-runtime repositories, here is the proposal we came with. We are going to create 2 new repos called plasma-desktop and

Re: Review Request 115311: [kwin] Don't call into GL without a context

2014-01-28 Thread Martin Gräßlin
On Jan. 28, 2014, 8:03 a.m., Commit Hook wrote: This review has been submitted with commit 77202a2102306a288431462e6c874216ac4cd29c by Martin Gräßlin on behalf of James Jones to branch KDE/4.11. James Jones wrote: Thanks Martin. Will the change automatically be merged up

Re: Review Request 115515: [oxygen] Check whether we are on platform X11 before calling into xcb

2014-02-06 Thread Martin Gräßlin
--- On Feb. 6, 2014, 11:55 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115515

Re: Review Request 115515: [oxygen] Check whether we are on platform X11 before calling into xcb

2014-02-06 Thread Martin Gräßlin
/diff/ Testing --- running Kate on Wayland till it crashes (or doesn't) Thanks, Martin Gräßlin

Review Request 115519: Do not use KDE_VERSION_STRING for workspace applications

2014-02-06 Thread Martin Gräßlin
and looked at e.g. startkde and systemsettings which have now 4.11.6. Thanks, Martin Gräßlin

Re: Review Request 115515: [oxygen] Check whether we are on platform X11 before calling into xcb

2014-02-07 Thread Martin Gräßlin
it crashes (or doesn't) Thanks, Martin Gräßlin

Re: Review Request 116600: depend upon CMake 2.8.12

2014-03-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116600/#review51906 --- Ship it! Ship It! - Martin Gräßlin On March 4, 2014, 5:25

Re: Review Request 108808: Do not reset opacity if call for GetWindowProperty fails

2014-03-18 Thread Martin Gräßlin
--- Thanks, Martin Gräßlin

Re: Review Request 116956: rename kglobalaccel to kglobalaccel5 for co-installability

2014-03-24 Thread Martin Gräßlin
a benefit in renaming the desktop files, etc. in the source dir. Otherwise we will have to rename again with kglobalaccel6 - Martin Gräßlin On March 21, 2014, 5:35 p.m., Jonathan Riddell wrote: --- This is an automatically generated e

Re: Review Request 116956: rename kglobalaccel to kglobalaccel5 for co-installability

2014-03-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116956/#review54152 --- Ship it! Ship It! - Martin Gräßlin On March 25, 2014, 7

Re: small but Big request

2014-03-29 Thread Martin Gräßlin
On Friday 28 March 2014 16:17:19 David Boosalis wrote: At the risk of getting 50 lashes. Can I make a request for new KDE Git build instructions. All the instructions for building might be out there and I know there is the uber kdesrc-build script, but you really got to squint to get all the

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Martin Gräßlin
for this is and I consider this as a security issue. It basically means that the session can get unlocked without going through authentication. - Martin Gräßlin On March 29, 2014, 12:58 p.m., Kirill Elagin wrote: --- This is an automatically

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Martin Gräßlin
On March 29, 2014, 1:05 p.m., Martin Gräßlin wrote: I also have problems imagining what a use case for this is and I consider this as a security issue. It basically means that the session can get unlocked without going through authentication. Kirill Elagin wrote: You have

Re: Review Request 117157: Unlock session via DBus

2014-03-29 Thread Martin Gräßlin
On March 29, 2014, 1:05 p.m., Martin Gräßlin wrote: I also have problems imagining what a use case for this is and I consider this as a security issue. It basically means that the session can get unlocked without going through authentication. Kirill Elagin wrote: You have

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Martin Gräßlin
On March 29, 2014, 1:05 p.m., Martin Gräßlin wrote: I also have problems imagining what a use case for this is and I consider this as a security issue. It basically means that the session can get unlocked without going through authentication. Kirill Elagin wrote: You have

Re: Re: Review Request 117157: Unlock session via DBus

2014-03-31 Thread Martin Gräßlin
On Sunday 30 March 2014 18:06:52 Thiago Macieira wrote: Leaving access to an open shell is certainly bad enough - beyond question. The question is whether gaining direct access to a running session and random open clients (and leaving the stage untraced) is more valuable and thus worth

Re: Review Request 117157: Unlock session via DBus

2014-04-02 Thread Martin Gräßlin
://git.reviewboard.kde.org/r/117324/ to use logind as an authority to unlock. - Martin Gräßlin On March 29, 2014, 12:58 p.m., Kirill Elagin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117157

Re: Freedesktop summit 2014

2014-04-19 Thread Martin Gräßlin
On Thursday 17 April 2014 20:17:38 David Faure wrote: I represented KDE again this year at the freedesktop summit in Nuremberg. Please find our report below. sorry to ask, but were there any discussions about the fact that GTK+ based applications start to be broken on other environments? See

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

2014-04-22 Thread Martin Gräßlin
(new master)? - Martin Gräßlin On April 22, 2014, 10:41 p.m., Wolfgang Bauer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117644

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-22 Thread Martin Gräßlin
for the new locker? I'm just wondering whether it needs to be ported to master - Martin Gräßlin On April 22, 2014, 10:34 p.m., Wolfgang Bauer wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

2014-04-23 Thread Martin Gräßlin
On April 23, 2014, 7:36 a.m., Martin Gräßlin wrote: would you please also adapt that for plasma-workspace repo (new master)? Wolfgang Bauer wrote: Yes, I will. Should I create a new review request for that, or should I just submit it? The code looks pretty straight forward

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-23 Thread Martin Gräßlin
On April 23, 2014, 7:41 a.m., Martin Gräßlin wrote: Is that only relevant for the legacy (XSS) locker or also for the new locker? I'm just wondering whether it needs to be ported to master Wolfgang Bauer wrote: Yes. I just tried, and the screen locker in master does have the same

Re: Review Request 117779: fix crash when textureNode-texture() is null

2014-04-26 Thread Martin Gräßlin
. There is an underlying problem which needs a more proper fix. I recently hit this problem myself on one on my systems and a crash one can reproduce is as good as fixed ;-) - Martin Gräßlin On April 26, 2014, 12:51 a.m., Alexander Richardson wrote

Re: Review Request 117779: fix crash when textureNode-texture() is null

2014-04-28 Thread Martin Gräßlin
? That could help me to reproduce and find the root cause. - Martin Gräßlin On April 26, 2014, 12:51 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779

Re: Review Request 117779: fix crash when textureNode-texture() is null

2014-04-28 Thread Martin Gräßlin
On April 28, 2014, 10:24 a.m., Martin Gräßlin wrote: did you notice any pattern which triggers the crash? That could help me to reproduce and find the root cause. I found the condition myself: 1. show thumbnail 2. let it hide again 3. show thumbnail for same task when switching

Compatibility problems with latest GTK+ applications

2014-05-07 Thread Martin Gräßlin
Hi all, I need some advice. The new GTK+ release introduced and enforces client-side- decorations (CSD) and that is causing severe compatibility problems with Plasma Workspaces (especially the stable release which we cannot adjust any more). I'll give a list of issues below. I'm not sure what

Re: Re: Compatibility problems with latest GTK+ applications

2014-05-07 Thread Martin Gräßlin
On Wednesday 07 May 2014 11:24:03 Marco Martin wrote: On Wednesday 07 May 2014 10:11:37 Martin Gräßlin wrote: * A hung window can no longer be closed or moved. Technical explanation: there is a ping protocol to detect hung applications. KWin only sends ping requests when the window is being

Re: Compatibility problems with latest GTK+ applications

2014-05-08 Thread Martin Gräßlin
Martin GräßlinOn Wednesday 07 May 2014 10:11:37 wrote: Any advice on how to handle this situation is appreciated. As several people responded that I should report the issues I just did that and reported the following bug reports against GTK: * CSD styled windows don't react on compositing

Re: Re: Compatibility problems with latest GTK+ applications

2014-05-08 Thread Martin Gräßlin
On Thursday 08 May 2014 14:39:49 Matthias Klumpp wrote: 2014-05-08 9:31 GMT+02:00 Martin Gräßlin mgraess...@kde.org: Martin GräßlinOn Wednesday 07 May 2014 10:11:37 wrote: Any advice on how to handle this situation is appreciated. As several people responded that I should report

Re: Re: Compatibility problems with latest GTK+ applications

2014-05-09 Thread Martin Gräßlin
On Friday 09 May 2014 09:54:53 John Layt wrote: On 8 May 2014 13:56, Sebastian Kügler se...@kde.org wrote: On Thursday, May 08, 2014 14:39:49 Matthias Klumpp wrote: However, to support the cross-desktop efforts, the GNOME people should maybe make a few compromises (e.g. make GTK+ behave

Re: Re: Compatibility problems with latest GTK+ applications

2014-05-09 Thread Martin Gräßlin
On Friday 09 May 2014 09:42:50 Daniel Nicoletti wrote: +Martin, does clicking on the shadow drawn by the window also prevents you from say focusing the window below (when no windeco is in place)? As from what I understood there is no hint margins. Maybe add this to your big list :P Just

Re: Review Request 118091: Changed formatting to fit the KDE Coding Standard

2014-05-11 Thread Martin Gräßlin
started port to xcb and thus Qt5, see https://git.reviewboard.kde.org/r/114178/ - Martin Gräßlin On May 12, 2014, 3:36 a.m., Uzair Shamim wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 118366: Porting keyboard module to Framework5

2014-05-28 Thread Martin Gräßlin
has not been adjusted to xcb yet. - Martin Gräßlin On May 27, 2014, 11:02 p.m., shivam makkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366

Re: Review Request 118563: kscreenlocker_greet: use SA_RESTART for signal handler

2014-06-05 Thread Martin Gräßlin
for the signals. But I'm not sure whether we can extend it to catch this condition (we don't have a BSD CI system yet). - Martin Gräßlin On June 5, 2014, 3:16 p.m., Wolfgang Bauer wrote: --- This is an automatically generated e-mail

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-16 Thread Martin Gräßlin
to the Review Request, though. The review request made me wonder whether we still need to find XLib in Oxygen, though. The parts shown only use XCB, so maybe we could just go for finding only XCB? - Martin Gräßlin On June 15, 2014, 2:47 p.m., Bernd Steinhauser wrote

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-20 Thread Martin Gräßlin
On May 28, 2014, 8:10 a.m., Martin Gräßlin wrote: kcms/keyboard/kcmmisc.cpp, lines 77-78 https://git.reviewboard.kde.org/r/118366/diff/2/?file=275630#file275630line77 for new connects I would use the new compile time checked syntax. shivam makkar wrote: I tried

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Martin Gräßlin
/118898/#comment42380 please use a copyright header as in http://techbase.kde.org/Policies/Licensing_Policy#GPL_Header kcmkgamma/init_kgamma.cpp https://git.reviewboard.kde.org/r/118898/#comment42381 why delete config? I would just use a KSharedConfig::openConfig - Martin Gräßlin

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Martin Gräßlin
On June 23, 2014, 5:13 p.m., Martin Gräßlin wrote: kcmkgamma/init_kgamma.cpp, line 39 https://git.reviewboard.kde.org/r/118898/diff/1/?file=283881#file283881line39 why delete config? I would just use a KSharedConfig::openConfig Wolfgang Bauer wrote: I just copy/pasted

Re: Bug 92237: patch submitted, but... is anyone watching?

2014-06-24 Thread Martin Gräßlin
no one noticed (the bug's CC list is empty...) In comment #5 you are asked to use review board. Bugzilla is very bad in tracking or reviewing patches, that's why we have a dedicated application for it. Cheers Martin Gräßlin signature.asc Description: This is a digitally signed message part.

Re: Re: code guideline

2014-07-09 Thread Martin Gräßlin
On Wednesday 09 July 2014 10:23:59 Kevin Ottens wrote: On Wednesday 09 July 2014 10:15:03 David Faure wrote: On Saturday 28 June 2014 08:51:42 Rodrigo Bonifacio wrote: Dear all, is there any code guideline that recommends developers to avoid the use of exception handling mechanisms

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Martin Gräßlin
what's the RJVB 20140706 standing for? - Martin Gräßlin On July 12, 2014, 4:22 p.m., Marko Käning wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread Martin Gräßlin
://git.reviewboard.kde.org/r/118180/#comment43523 here the coding style looks wrong - Martin Gräßlin On June 5, 2014, 12:32 p.m., TOM Harrison wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Scripting/Extensions BoF at Akademy?

2014-08-10 Thread Martin Gräßlin
On Saturday 09 August 2014 17:34:04 Kevin Krammer wrote: Greetings all, I'd like to ask if there is any interest of having a BoF around the topic of script language based extensions for KDE applications. Some applications already offer that, e.g. Kate, and Plasma is even designed around

Re: Re: Using Gerrit for code review in KDE

2014-09-13 Thread Martin Gräßlin
On Saturday 13 September 2014 16:51:15 Albert Astals Cid wrote: El Divendres, 12 de setembre de 2014, a les 22:52:40, Marco Martin va escriure: On Tuesday, September 9, 2014, Jan Kundrát j...@flaska.net wrote: If you would like all plasma to go, just give me a list of repos and I can

<    1   2   3   4   >