Re: Gwenview maintainership

2014-10-15 Thread Aurélien Gâteau
On Tue, Oct 14, 2014, at 22:10, Lukáš Tinkl wrote: Dne 14.10.2014 v 17:51 Aurélien Gâteau napsal(a): For the past few months, I haven't been doing any work on KDE projects, and I don't see this changing for now. It's time for me to step down from the projects I maintain. This includes

Re: Gwenview maintainership

2014-10-15 Thread Aurélien Gâteau
in these details, specially since I was fooling around on a gallery application based on the VDG mockups [1] [1] https://forum.kde.org/viewtopic.php?f=285t=122869 On Wed, Oct 15, 2014 at 8:56 AM, Aurélien Gâteau agat...@kde.org wrote: On Tue, Oct 14, 2014, at 22:10, Lukáš Tinkl wrote: Dne

Gwenview maintainership

2014-10-14 Thread Aurélien Gâteau
For the past few months, I haven't been doing any work on KDE projects, and I don't see this changing for now. It's time for me to step down from the projects I maintain. This includes Gwenview. Awesome David Edmundson did the grunt work of porting it to KDE Frameworks 5 (Thanks again David!), but

Re: Tests still failing in 4.13

2014-04-04 Thread Aurélien Gâteau
On Sun, Mar 30, 2014, at 16:42, Albert Astals Cid wrote: Hello people, at the moment we have various 4.13 projects failing. Since we promised a while ago to not release without failing tests we have 10 days until tagging to fix the tests or we'll have to delay the release. If you need

Re: Tests still failing in 4.13

2014-04-04 Thread Aurélien Gâteau
On Fri, Apr 4, 2014, at 1:11, Aurélien Gâteau wrote: On Sun, Mar 30, 2014, at 16:42, Albert Astals Cid wrote: Hello people, at the moment we have various 4.13 projects failing. Since we promised a while ago to not release without failing tests we have 10 days until tagging to fix

Re: Review Request 114686: Do not use a standard shortcut for KMessageWidget's close action

2014-01-14 Thread Aurélien Gâteau
On Jan. 14, 2014, 9:05 a.m., Aurélien Gâteau wrote: Makes sense to me, go for it. Frank Reininghaus wrote: Thanks! BTW, I was just going to forward-port the patch to Frameworks (kwidgetsaddons), but I see that KMessageWidget does not use KStandardAction any more. I

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-07 Thread Aurélien Gâteau
Le mardi 7 janvier 2014 11:36:34 Alex Merry a écrit : On 06/01/14 06:52, Kevin Ottens wrote: I used to say that the maintenance model of kdelibs was David Faure by default. It's great to have someone like David around, but at the same time it's delusional and dangerous to think that he'll

Re: KClasses vs. Qt5Classes

2014-01-06 Thread Aurélien Gâteau
Le mardi 31 décembre 2013 12:42:22 Martin Graesslin a écrit : On Tuesday 31 December 2013 12:15:09 David Faure wrote: QSystemTrayIcon = KNotificationItem No clue. I can't even find KNotificationItem in KF5 anywhere !?!? In fact it doesn't exist in kdelibs4 either. I think it

Re: KMountPoint::probablySlow and cifs mount points

2013-11-26 Thread Aurélien Gâteau
Le lundi 25 novembre 2013 20:38:58 Ingo Klöcker a écrit : On Monday 25 November 2013 18:46:27 Aurélien Gâteau wrote: Le lundi 25 novembre 2013 18:23:53 Mark Gaiser a écrit : On Mon, Nov 25, 2013 at 5:41 PM, Aurélien Gâteau agat...@kde.org wrote: 2. If you follow this route, you

Re: KMountPoint::probablySlow and cifs mount points

2013-11-25 Thread Aurélien Gâteau
Le dimanche 24 novembre 2013 19:42:25 Mark Gaiser a écrit : On Sun, Nov 24, 2013 at 5:05 PM, Albert Astals Cid aa...@kde.org wrote: In Okular we just got bug https://bugs.kde.org/show_bug.cgi?id=327846 PDF Render time is unreasonably slow over cifs on high latency (WAN) network

Re: KMountPoint::probablySlow and cifs mount points

2013-11-25 Thread Aurélien Gâteau
Le lundi 25 novembre 2013 13:54:38 Mark Gaiser a écrit : On Mon, Nov 25, 2013 at 10:45 AM, Aurélien Gâteau agat...@kde.org wrote: Le dimanche 24 novembre 2013 19:42:25 Mark Gaiser a écrit : On Sun, Nov 24, 2013 at 5:05 PM, Albert Astals Cid aa...@kde.org wrote: In Okular we just got bug

Re: KMountPoint::probablySlow and cifs mount points

2013-11-25 Thread Aurélien Gâteau
Le lundi 25 novembre 2013 18:23:53 Mark Gaiser a écrit : On Mon, Nov 25, 2013 at 5:41 PM, Aurélien Gâteau agat...@kde.org wrote: Le lundi 25 novembre 2013 13:54:38 Mark Gaiser a écrit : On Mon, Nov 25, 2013 at 10:45 AM, Aurélien Gâteau agat...@kde.org wrote: Le dimanche 24 novembre 2013

Re: Review Request 113644: Fix Standalone Build for KWallet

2013-11-05 Thread Aurélien Gâteau
group instead of the kdelibs group for KF5 review requests. - Aurélien Gâteau On Nov. 5, 2013, 2:36 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113644

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-24 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/#review40692 --- On Sept. 24, 2013, 4:19 p.m., Aurélien Gâteau wrote

Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-19 Thread Aurélien Gâteau
/kguiaddons/src/lib/colors/kcolorutils.h c20c6f7 tier1/kguiaddons/src/lib/colors/kcolorutils.cpp 9212bba Diff: http://git.reviewboard.kde.org/r/112816/diff/ Testing --- kcolorutilsdemo still works. Thanks, Aurélien Gâteau

Review Request 112756: KLinkItemSelectionModel: Do not change current index of mapped model if the mapped one is invalid

2013-09-16 Thread Aurélien Gâteau
is not broken anymore. Thanks, Aurélien Gâteau

Review Request 112556: Move itemviews to tier2

2013-09-06 Thread Aurélien Gâteau
-CREATION Diff: http://git.reviewboard.kde.org/r/112556/diff/ Testing --- Builds and passes tests when build from kdelibs and standalone. Thanks, Aurélien Gâteau

Need someone to review a patch for Gwenview

2013-09-06 Thread Aurélien Gâteau
Hi, I have a review request for Gwenview which I would like to get included in 4.11.2, but Gwenview does not have a very big developer community so I am afraid it won't get reviewed in time: it already missed the 4.11.1 deadline and I had to ask for a revert of the kdelibs patch mentioned in

Re: Review Request 112081: Add reviewboard-am, a tool to apply patches from KDE reviewboard

2013-08-16 Thread Aurélien Gâteau
--- On Aug. 14, 2013, 5:26 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112081

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-14 Thread Aurélien Gâteau
On Aug. 9, 2013, 2:59 p.m., Stephen Kelly wrote: Have you tried kdepim applications with this patch too? Many of them use this class. Aurélien Gâteau wrote: I just grepped in kdepim, it seems only kmail-mobile makes use of it. It looks like it's working, but I am not familiar

Re: Review Request 112081: Add reviewboard-am, a tool to apply patches from KDE reviewboard

2013-08-14 Thread Aurélien Gâteau
--- On Aug. 14, 2013, 4:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112081/ --- (Updated Aug. 14

Re: Review Request 112081: Add reviewboard-am, a tool to apply patches from KDE reviewboard

2013-08-14 Thread Aurélien Gâteau
-CREATION Diff: http://git.reviewboard.kde.org/r/112081/diff/ Testing --- I and a few others, most notably David Edmundson, have been using it for quite some time now. Thanks, Aurélien Gâteau

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-13 Thread Aurélien Gâteau
/klinkitemselectionmodeltest.cpp c3f7132 Diff: http://git.reviewboard.kde.org/r/111953/diff/ Testing --- - Extended unit-tests to test the current index is synchronized. - Verified the bug is fixed in Gwenview. Thanks, Aurélien Gâteau

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-13 Thread Aurélien Gâteau
, 5:57 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/ --- (Updated Aug. 13, 2013, 5:57 p.m

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-13 Thread Aurélien Gâteau
/klinkitemselectionmodeltest.h f3e0fd1 kdeui/tests/klinkitemselectionmodeltest.cpp c3f7132 Diff: http://git.reviewboard.kde.org/r/111953/diff/ Testing --- - Extended unit-tests to test the current index is synchronized. - Verified the bug is fixed in Gwenview. Thanks, Aurélien Gâteau

Re: Proposal for branching policy towards KF5

2013-07-29 Thread Aurélien Gâteau
Le mercredi 24 juillet 2013 23:05:55 Michael Pyne a écrit : On Fri, July 19, 2013 00:21:21 you wrote: After more live discussion with Sebas and Marco plus Aaron over a video chat, we came up with the following setup for the workspace repos (*) : - the development branch for their next

Re: Releases in 3 months

2013-07-11 Thread Aurélien Gâteau
Le mercredi 10 juillet 2013 17:55:42 Àlex Fiestas a écrit : On Tuesday 09 July 2013 16:12:35 Andras Mantia wrote: Two point I want to mention: 1) working in a branch for kdepim is quite painful, as you need actually work on branches of 3 (or sometimes 4) modules: kdepimlibs,

Re: All KConfig files inherit kdeglobals keys by default, good or bad?

2013-07-09 Thread Aurélien Gâteau
On Thursday 04 July 2013 01:28:16 Aaron J. Seigo wrote: On Tuesday, June 25, 2013 10:10:03 Aurélien Gâteau wrote: Why would the code be specific to kiosk? - You asked for an example, not justification. I asked for an example, you provided one about kiosk, I answer how your kiosk

Re: Releases in 3 months

2013-07-09 Thread Aurélien Gâteau
On Monday 08 July 2013 23:08:29 Ingo Klöcker wrote: On Monday 08 July 2013 22:14:28 Aurélien Gâteau wrote: On Monday 08 July 2013 16:26:00 laurent Montel wrote: Le lundi 8 juillet 2013 16:11:05 Frank Reininghaus a écrit : Hi, 2013/7/8 Àlex Fiestas: Now that kde-workspace

Re: Releases in 3 months

2013-07-08 Thread Aurélien Gâteau
On Monday 08 July 2013 16:26:00 laurent Montel wrote: Le lundi 8 juillet 2013 16:11:05 Frank Reininghaus a écrit : Hi, 2013/7/8 Àlex Fiestas: Now that kde-workspace and kdelibs are going to be frozen (which in theory means less work for everybody) I'd like to propose a new release

Review Request 111345: KParts::StatusBarExtension: Remember activated state

2013-07-01 Thread Aurélien Gâteau
around with tabs and splitted views, did not notice any behavior change in the statusbar. Thanks, Aurélien Gâteau

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-25 Thread Aurélien Gâteau
moved to be kwin only. It looks like the best way forward. Aurélien Gâteau wrote: I see the point of having cross-app configuration files, I assume classes from kdelibs for example can use it to store settings. What I don't understand is in which situation it is useful to have all

All KConfig files inherit kdeglobals keys by default, good or bad?

2013-06-25 Thread Aurélien Gâteau
[Continuing the discussion started on https://git.reviewboard.kde.org/r/71/ ] Aurélien Gâteau wrote: I see the point of having cross-app configuration files, I assume classes from kdelibs for example can use it to store settings. What I don't understand is in which

Re: All KConfig files inherit kdeglobals keys by default, good or bad?

2013-06-25 Thread Aurélien Gâteau
On Tuesday 25 June 2013 14:17:16 Thomas Lübking wrote: On Dienstag, 25. Juni 2013 10:10:03 CEST, Aurélien Gâteau wrote: [Continuing the discussion started on https://git.reviewboard.kde.org/r/71/ ] - kdeglobals in mind. As such, I think this code should opt-in to inherit

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-24 Thread Aurélien Gâteau
On June 22, 2013, 12:58 p.m., Thomas Lübking wrote: kdeui/util/kglobalsettings.cpp, line 308 http://git.reviewboard.kde.org/r/71/diff/1/?file=165092#file165092line308 These are the colors for the window titlbar (with ambiguous function names, though), the default for

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-24 Thread Aurélien Gâteau
moved to be kwin only. It looks like the best way forward. Aurélien Gâteau wrote: I see the point of having cross-app configuration files, I assume classes from kdelibs for example can use it to store settings. What I don't understand is in which situation it is useful to have all

Review Request 111158: Fix KLinkItemSelectionModel handling of QItemSelectionModel::Toggle flag

2013-06-21 Thread Aurélien Gâteau
/klinkitemselectionmodeltest.h PRE-CREATION kdeui/tests/klinkitemselectionmodeltest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/58/diff/ Testing --- Added a unit-test. Tested in Gwenview. Thanks, Aurélien Gâteau

Re: Review Request 111164: Create FavIconsModule namespace in kdebug

2013-06-21 Thread Aurélien Gâteau
/r/64/#comment25528 Since dfavi() is local to this file, it should be static I think. nitpick: It would be more coding-style compliant to write the function body like a normal function instead of putting everything on the same line. - Aurélien Gâteau On June 21, 2013, 8:55 p.m

Re: Review Request 110951: Save icon size in the same place other settings are saved

2013-06-12 Thread Aurélien Gâteau
/#review34210 --- On June 11, 2013, 3:36 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110951

Review Request 110951: Save icon size in the same place other settings are saved

2013-06-11 Thread Aurélien Gâteau
KWrite 2. Opened file dialog 3. Changed icon size 4. Closed file dialog 5. Started Gwenview 6. Opened file dialog = same icon size as the one set on step 3. Thanks, Aurélien Gâteau

Re: Review Request 106581: Make KFileDialog remember settings

2013-06-10 Thread Aurélien Gâteau
276861dcb2b761b9788506ccd281f22978e26f61 Diff: http://git.reviewboard.kde.org/r/106581/diff/ Testing --- Tested with two different KDE applications. Settings are correctly remembered. Thanks, Aurélien Gâteau

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-14 Thread Aurélien Gâteau
() and setPalette() or similar. Then, the developer would have more control over the colors showing up in the Kate views. A disadvantage of this is, however, that this leads to inconsistent ui's. It this is needed, this patch works against this, though. Aurélien Gâteau wrote: It could

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-14 Thread Aurélien Gâteau
724da0fa60a7b236d61685257e011fc49a30c1ff Diff: http://git.reviewboard.kde.org/r/110327/diff/ Testing --- Tested with kmessagewidgetdemo, Dolphin and Kate. Thanks, Aurélien Gâteau

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-07 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/#review32194 --- On May 6, 2013, 10:59 p.m., Aurélien Gâteau wrote

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/#review32154 --- On May 6, 2013, 5:53 p.m., Aurélien Gâteau wrote

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-06 Thread Aurélien Gâteau
it. - Aurélien --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/#review32149 --- On May 6, 2013, 5:53 p.m., Aurélien Gâteau wrote

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-06 Thread Aurélien Gâteau
, Dolphin and Kate. Thanks, Aurélien Gâteau

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-04-29 Thread Aurélien Gâteau
Le Monday 29 April 2013 15:47:40 Martin Briza a écrit : Hi, On Fri, 26 Apr 2013 23:30:43 +0200, Albert Astals Cid aa...@kde.org wrote: El Dijous, 25 d'abril de 2013, a les 15:11:25, Martin Briza va escriure: after fixing a bit in the $subj Which repo is that? Are we installing that

Re: Review Request 109935: Make KFilePlacesModel treats internal moves by drag'n'drop as moves instead of remove+insert

2013-04-11 Thread Aurélien Gâteau
On April 11, 2013, 2:03 p.m., Commit Hook wrote: This review has been submitted with commit 8f8e3c27005b9d32b31cb6de5fd162a68c2a736b by Aurélien Gâteau to branch master. I decided to push it to master and not to KDE/4.10 as this could be disruptive. - Aurélien

Re: Review Request 106581: Make KFileDialog remember settings

2013-04-11 Thread Aurélien Gâteau
/#review30891 --- On Oct. 2, 2012, 12:55 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106581

Re: Review Request 109934: Add signal KMessageWidget::linkHovered(const QString)

2013-04-10 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109934/#review30841 --- Ship it! Makes sense, please commit. - Aurélien Gâteau

Re: kwalletmanager ui refactor

2013-02-12 Thread Aurélien Gâteau
Le Wednesday 06 February 2013 23:14:59 Valentin Rusu a écrit : Thanks, I understand it better now. Assuming it was also possible to get a list of the authorized applications, I created a new revision of the mockups which show the list of currently connected applications as well as the

Re: kwalletmanager ui refactor

2013-02-06 Thread Aurélien Gâteau
On 05.02.2013 21:34, Valentin Rusu wrote: On Tuesday 05 February 2013 10:49:55 Aurélien Gâteau wrote: 2. The disconnect button should be kept, in my opinnion. Here is a screen capture with the disconnect menu for my main wallet: http://imgur.com/JG6rr8b And here is another one showing

Re: Review Request 108808: Do not reset opacity if call for GetWindowProperty fails

2013-02-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108808/#review26756 --- Works fine here. - Aurélien Gâteau On Feb. 6, 2013, 3:38

Re: Review Request 107678: Keep clickmessage text visible when empty and focused

2013-02-06 Thread Aurélien Gâteau
, and certain do not. It will stay inconsistent with the QLineEdit based applications for instance (I know one could bring different examples, too). I am not envy for the decision maker. :-) Aurélien Gâteau wrote: I see more and more interfaces switching to keeping

Re: kwalletmanager ui refactor

2013-02-05 Thread Aurélien Gâteau
Le Monday 04 February 2013 23:50:49 Valentin Rusu a écrit : On Monday 04 February 2013 19:28:42 Aurélien Gâteau wrote: Le Sunday 03 February 2013 14:50:33 Valentin Rusu a écrit : A screen capture is far better than a hundred words so here it is: http://imgur.com/MD3GDxO Hey

Review Request 108776: apidoc: Make inherited sections collapsable and expandable

2013-02-04 Thread Aurélien Gâteau
to copy the jquery.js file manually in */html folders though. Thanks, Aurélien Gâteau

Re: kwalletmanager ui refactor

2013-02-04 Thread Aurélien Gâteau
Le Sunday 03 February 2013 14:50:33 Valentin Rusu a écrit : Hello, Lots of us are frequently using kwalletmanager to get/store the secrets for the ever extending sensitive information. We click it's icon to pop the main window, then double click the main wallet icon to pop another window,

Re: Review Request: KHTML, imload: Fix wrong version of last line of scaled tile

2013-01-08 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108246/#review24936 --- On Jan. 7, 2013, 6:16 p.m., Aurélien Gâteau wrote

Review Request: KHTML, imload: Fix wrong version of last line of scaled tile

2013-01-07 Thread Aurélien Gâteau
: http://git.reviewboard.kde.org/r/108246/diff/ Testing --- Tested Akregator and Konqueror about pages. Browsed a few websites with Konqueror + KHTML. Screenshots --- Konqueror, before - after http://git.reviewboard.kde.org/r/108246/s/988/ Thanks, Aurélien Gâteau

Re: Kded and DBus

2013-01-04 Thread Aurélien Gâteau
Le Friday 04 January 2013 10:50:02 Cedric Bellegarde a écrit : Le jeudi 3 janvier 2013 23:30:28 Weng Xuetian a écrit : Why appmenu-qt doesn't use static dbus interface (generate from XML)? From Qt code that can avoid synchronous introspection. No idea, Aurélien ? No strong reason. It

Review Request: KMessageWidget: Fix infinite recursion triggered from resizeEvent()

2012-12-21 Thread Aurélien Gâteau
://git.reviewboard.kde.org/r/107835/diff/ Testing --- Tested with `kate +30 foo` which used to trigger the infinite recursion. Tested with kmessagewidgetdemo and kmessagewidgettest, did not spot any regression. Thanks, Aurélien Gâteau

Review Request: Fix mixed sentences in sftp error message

2012-12-13 Thread Aurélien Gâteau
://localhost (now I need to figure out why :) ) Thanks, Aurélien Gâteau

Re: Review Request: Fix mixed sentences in sftp error message

2012-12-13 Thread Aurélien Gâteau
://git.reviewboard.kde.org/r/107700/diff/ Testing --- Tested with Gwenview, which failed to log on sftp://localhost (now I need to figure out why :) ) Thanks, Aurélien Gâteau

Re: Review Request: Keep clickmessage text visible when empty and focused

2012-12-13 Thread Aurélien Gâteau
--- On Dec. 12, 2012, 5:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107678

Re: Review Request: Fix margin on KMessageWidget to match that used by a styled QFrame.

2012-11-15 Thread Aurélien Gâteau
actually wondering whether the setFrameStyle() call is needed at all. Do you get a different result without it? - Aurélien Gâteau On Nov. 15, 2012, 6:40 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply

Review Request: Fix sizing of KMessageWidget when shown at startup

2012-11-15 Thread Aurélien Gâteau
/ Testing --- Have been running with this patch since for almost a week now. No regressions. Thanks, Aurélien Gâteau

Re: What is the git workflow for kdelibs ?

2012-11-07 Thread Aurélien Gâteau
On Thu, 01 Nov 2012 12:05:51 +0100, David Faure wrote: On Wednesday 31 October 2012 10:14:20 Aurélien Gâteau wrote: Le mardi 30 octobre 2012 12:16:40 David Faure a écrit : Ok, thanks. Is this documented somewhere ? No (I described it in an email some time ago, but it's not on any wiki

Re: What is the git workflow for kdelibs ?

2012-10-31 Thread Aurélien Gâteau
Le mardi 30 octobre 2012 12:16:40 David Faure a écrit : Ok, thanks. Is this documented somewhere ? No (I described it in an email some time ago, but it's not on any wiki) If you have an idea for where we could document it, I will then push other module maintainers to also write up the

Re: Comparing KFileItems

2012-10-22 Thread Aurélien Gâteau
Le dimanche 21 octobre 2012 13:49:49 David Faure a écrit : I don't think we want to call a full cmp(). If you have two KFileItems referring to the same file, but one KFileItem has more details than the other (e.g. because it comes from KIO while the other one was created from a URL only),

Re: kde-runtime module master and KDE/4.9 branches

2012-10-12 Thread Aurélien Gâteau
Le vendredi 12 octobre 2012 02:24:21 Laszlo Papp a écrit : Problem with this approach is the code you backport is usually a lot less tested as you made all your developments on master. In the svn days I even remember people telling me they were blind-backporting to stable because it was

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-10-11 Thread Aurélien Gâteau
://codereview.qt-project.org/#change,36859 - Aurélien Gâteau On Sept. 21, 2012, 3:29 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106527

Re: kde-runtime module master and KDE/4.9 branches

2012-10-11 Thread Aurélien Gâteau
Le mercredi 10 octobre 2012 11:13:57 Laszlo Papp a écrit : Hm, as kde-runtime is not frozen in master, whoever does fixes in 4.9 should merge them to master. Unfortunately, there may always be changes missing. Unsure how much it can be automated, but I have the impression we do not exactly

Re: kde-runtime module master and KDE/4.9 branches

2012-10-11 Thread Aurélien Gâteau
Le jeudi 11 octobre 2012 20:02:51 Laszlo Papp a écrit : I think the problem is we don't know the commit policy for kde-runtime. Is it: fix-master-and-backport: fix in master, cherry-pick to KDE/4.x -- or -- fix-stable-and-merge: fix in KDE/4.x, merge KDE/4.x in master I

Re: kde-runtime module master and KDE/4.9 branches

2012-10-11 Thread Aurélien Gâteau
Le jeudi 11 octobre 2012 20:02:51 Laszlo Papp a écrit : I think the problem is we don't know the commit policy for kde-runtime. Is it: fix-master-and-backport: fix in master, cherry-pick to KDE/4.x -- or -- fix-stable-and-merge: fix in KDE/4.x, merge KDE/4.x in master I

Re: Review Request: Make KFileDialog remember settings

2012-10-02 Thread Aurélien Gâteau
/#review19620 --- On Sept. 26, 2012, 4:19 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106581

Re: Review Request: Make KFileDialog remember settings

2012-10-02 Thread Aurélien Gâteau
to switch the view mode of kfiledialog in every single KDE app, right? Tough problem, there's never a perfect solution with these things (making everyone happy leads to too many config options, and alternatives leave some people unhappy). Aurélien Gâteau wrote: I have been using

Re: Review Request: Make KFileDialog remember settings

2012-10-02 Thread Aurélien Gâteau
. Settings are correctly remembered. Thanks, Aurélien Gâteau

Re: Review Request: Make KFileDialog remember settings

2012-10-02 Thread Aurélien Gâteau
: http://git.reviewboard.kde.org/r/106581/#review19741 --- On Oct. 2, 2012, 10:55 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-09-28 Thread Aurélien Gâteau
On Sept. 26, 2012, 9:16 a.m., Aurélien Gâteau wrote: I pushed the plasmoidviewer changed in and filed a Qt review as well: https://codereview.qt-project.org/#change,35683 Aaron J. Seigo wrote: this change was pushed into the KDE/4.9 branch of kdelibs, but not master. not sure

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-09-26 Thread Aurélien Gâteau
as well: https://codereview.qt-project.org/#change,35683 - Aurélien Gâteau On Sept. 21, 2012, 3:29 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106527

Review Request: Make KFileDialog remember settings

2012-09-26 Thread Aurélien Gâteau
. This addresses bug 139475. http://bugs.kde.org/show_bug.cgi?id=139475 Diffs - kfile/kfilewidget.cpp 8e2f967 Diff: http://git.reviewboard.kde.org/r/106581/diff/ Testing --- Tested with two different KDE applications. Settings are correctly remembered. Thanks, Aurélien

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-09-24 Thread Aurélien Gâteau
. - Aurélien --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106527/#review19352 --- On Sept. 21, 2012, 3:29 p.m., Aurélien Gâteau wrote

Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-09-21 Thread Aurélien Gâteau
= application should stop and a file named plasmoidviewer_$date_$time.qtd should be created - Open Qt Creator, click the Analyze sidebar button - Right click in the profiler area (bottom right) and select Load QML Trace - Select the plasmoidviewer_$date_$time.qtd file Thanks, Aurélien Gâteau

Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-24 Thread Aurélien Gâteau
Le vendredi 20 juillet 2012 17:58:04 Martin Gräßlin a écrit : Providing a password safe and asking for the master password is also a system service and should belong into the workspace. So here my idea: let's move the password dialog into the desktop shell. Have it as a so-called persistent

Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-24 Thread Aurélien Gâteau
Le samedi 21 juillet 2012 10:40:17 Volker Krause a écrit : When looking at KWallet security and usability, there's another aspect that came up in discussions during Akademy: The Do you want to allow application foo access your wallet? dialog. It might give the impression that only certain

Re: Using userbase for manuals

2012-07-03 Thread Aurélien Gâteau
Le lundi 2 juillet 2012 07:01:06 Inge Wallin a écrit : Now, the suggestion was to move to a wiki instead Advantages: 1. Easier to find the documentation for potential writers. 2. (Supposedly) easier to edit [Personally I'm not sure that editing advanced wiki markup is easier than docbook]

Re: Review Request: Move KdepimLibs dependency to DrKonqi

2012-07-03 Thread Aurélien Gâteau
dependency on package Foo and B/CMakeLists.txt has a mandatory dependency on Foo (possibly added later). - Aurélien Gâteau On July 1, 2012, 4:23 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request: Move KdepimLibs dependency to DrKonqi

2012-07-03 Thread Aurélien Gâteau
On July 3, 2012, 12:07 p.m., Aurélien Gâteau wrote: Was this actually asked by packagers? I am no expert, but the feedback I had from a Debian packager working on CMake projects was that he preferred to have all dependencies listed in the top-level CMakeLists.txt. The reason he

Re: Using userbase for manuals

2012-07-03 Thread Aurélien Gâteau
Le mardi 3 juillet 2012 15:18:37 Ingo Malchow a écrit : -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 03.07.2012 14:00, schrieb Aurélien Gâteau: Le lundi 2 juillet 2012 07:01:06 Inge Wallin a écrit : Now, the suggestion was to move to a wiki instead Advantages: 1. Easier to find

Re: Using userbase for manuals

2012-07-03 Thread Aurélien Gâteau
Le mardi 3 juillet 2012 18:24:41 Ingo Malchow a écrit : In an ideal world we could really work around such issues with some semi-automated ways. Just an idea: Those who do like the idea of doing a manual in a online wiki could just teach their respective users how to properly format their

Re: Review Request: Plasma::RunnerManager: only dequeue our ThreadWeaver jobs

2012-05-24 Thread Aurélien Gâteau
created by this instance of RunnerManager. Diffs - plasma/runnermanager.cpp 49569a3 Diff: http://git.reviewboard.kde.org/r/104973/diff/ Testing --- I have more than one RunnerManager working at once in a project. Without the patch, only one manager return results. Thanks, Aurélien

Re: Review Request: Plasma::RunnerManager: only dequeue our ThreadWeaver jobs

2012-05-23 Thread Aurélien Gâteau
--- On May 17, 2012, 1:18 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104973

Review Request: Plasma::RunnerManager: only dequeue our ThreadWeaver jobs

2012-05-17 Thread Aurélien Gâteau
/ Testing --- I have more than one RunnerManager working at once in a project. Without the patch, only one manager return results. Thanks, Aurélien Gâteau

Re: Review Request: Define tooltips for kdeui standard actions

2012-05-16 Thread Aurélien Gâteau
to commit this tomorrow evening, unless someone objects. - Aurélien Gâteau On May 14, 2012, 8:36 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104934

Re: Review Request: Define tooltips for kdeui standard actions

2012-05-14 Thread Aurélien Gâteau
--- On May 13, 2012, 10:08 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104934

Re: Review Request: Define tooltips for kdeui standard actions

2012-05-14 Thread Aurélien Gâteau
still falls back to action text if no tooltip is defined. Thanks, Aurélien Gâteau

Review Request: Define tooltips for kdeui standard actions

2012-05-13 Thread Aurélien Gâteau
Diff: http://git.reviewboard.kde.org/r/104934/diff/ Testing --- Tested with a few KDE applications: KWrite, Kate, Dolphin, Gwenview. Checked improved tooltips are shown and code still falls back to action text if no tooltip is defined. Thanks, Aurélien Gâteau

Re: Review Request: KMessageWidget: Adapt height to text changes

2012-05-07 Thread Aurélien Gâteau
On May 2, 2011, 5:49 p.m., Aurélien Gâteau wrote: Thanks for the patch Mattias! This is indeed an annoying bug but your fix does not work when the widget is resized. heightForWidth() needs to be implemented I think. Matthias Fuchs wrote: The problem is that resizing takes

Re: RFC: i18n: drop KUIT tags in KDE Frameworks 5.0?

2012-03-26 Thread Aurélien Gâteau
On Sat, 24 Mar 2012 12:06:25 +0100, Chusslove Illich wrote: [: Oswald Buddenhagen :] i would find this number way more helpful if it gave the percentage of strings with markup only amongst strings which have placeholders, as that is by far the most interesting target group. I recognize that

  1   2   >