for it
File Attachments
screenshot of the new Tools button
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/ac70c386-6665-4898-94e7-b256759f5a5e__screenshot_20160907_140935.png
Thanks,
Gregor Mi
- Gregor Mi
On Aug. 3, 2017, 1:25 nachm., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
menu item for it
File Attachments
screenshot of the new Tools button
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/ac70c386-6665-4898-94e7-b256759f5a5e__screenshot_20160907_140935.png
Thanks,
Gregor Mi
hat there is no menu item for it
File Attachments
screenshot of the new Tools button
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/ac70c386-6665-4898-94e7-b256759f5a5e__screenshot_20160907_140935.png
Thanks,
Gregor Mi
s
(C++14 might solve the issue)
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128854/#review103512
-------
On
it.reviewboard.kde.org/r/128854/#review103512
-----------
On July 28, 2017, 12:20 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail. To re
atically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128854/#review98994
-----------
On July 28, 2017, 12:20 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-
new Tools button
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/07/ac70c386-6665-4898-94e7-b256759f5a5e__screenshot_20160907_140935.png
Thanks,
Gregor Mi
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote:
> > > If someone has changed the shortcut, they should know what shortcut they
> > > set it to, right? So having the tooltip just say "To kill a specific
> > > window, press the "Kill Window" shortcu
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote:
> > > If someone has changed the shortcut, they should know what shortcut they
> > > set it to, right? So having the tooltip just say "To kill a specific
> > > window, press the "Kill Window" shortcu
files/2016/01/24/71ebdcea-a793-460a-adb5-f05a7706f8b0__screenshot_20160124_115024-with-tools.png
Thanks,
Gregor Mi
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote:
> > > If someone has changed the shortcut, they should know what shortcut they
> > > set it to, right? So having the tooltip just say "To kill a specific
> > > window, press the "Kill Window" shortcu
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote:
> > > If someone has changed the shortcut, they should know what shortcut they
> > > set it to, right? So having the tooltip just say "To kill a specific
> > > window, press the "Kill Window" shortcu
that tooltips are to be avoided where possible => this
patch factors some information out of a tooltip which in itself is desirable.
4. For the user, the discoverability of the feature after applying this patch
is better than before (though not perfect, sure).
- Gregor Mi
On April 20
process had been selected when "End Process..."
> > is clicked, a dialog could be opened where the process to kill would be
> > selected. Of course the current flow of ending a process could and should
> > still work.
>
> Gregor Mi wrote:
> Thanks for th
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote:
> > > If someone has changed the shortcut, they should know what shortcut they
> > > set it to, right? So having the tooltip just say "To kill a specific
> > > window, press the "Kill Window" shortcu
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote:
> > > If someone has changed the shortcut, they should know what shortcut they
> > > set it to, right? So having the tooltip just say "To kill a specific
> > > window, press the "Kill Window" shortcu
process had been selected when "End Process..."
> > is clicked, a dialog could be opened where the process to kill would be
> > selected. Of course the current flow of ending a process could and should
> > still work.
>
> Gregor Mi wrote:
> Thanks for th
in the list that you want to
end. Alternatively, if no process had been selected when End Process...
is clicked, a dialog could be opened where the process to kill would be
selected. Of course the current flow of ending a process could and should
still work.
Gregor Mi wrote:
Thanks
in the list that you want to
end. Alternatively, if no process had been selected when End Process...
is clicked, a dialog could be opened where the process to kill would be
selected. Of course the current flow of ending a process could and should
still work.
Gregor Mi wrote:
Thanks
in the list that you want to
end. Alternatively, if no process had been selected when End Process...
is clicked, a dialog could be opened where the process to kill would be
selected. Of course the current flow of ending a process could and should
still work.
Gregor Mi wrote:
Thanks
in the list that you want to
end. Alternatively, if no process had been selected when End Process...
is clicked, a dialog could be opened where the process to kill would be
selected. Of course the current flow of ending a process could and should
still work.
Gregor Mi wrote:
Thanks
in the list that you want to
end. Alternatively, if no process had been selected when End Process...
is clicked, a dialog could be opened where the process to kill would be
selected. Of course the current flow of ending a process could and should
still work.
Gregor Mi wrote:
Thanks
in the list that you want to
end. Alternatively, if no process had been selected when End Process...
is clicked, a dialog could be opened where the process to kill would be
selected. Of course the current flow of ending a process could and should
still work.
Gregor Mi wrote:
Thanks
in the list that you want to
end. Alternatively, if no process had been selected when End Process...
is clicked, a dialog could be opened where the process to kill would be
selected. Of course the current flow of ending a process could and should
still work.
Gregor Mi wrote:
Thanks
-4358-9a63-a85dae5722bd__screenshot_default1.png
new submenu
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/eeaecc88-20bc-46d6-9c65-50ba4a7c182a__submenu.png
Thanks,
Gregor Mi
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/#review79262
---
On April 20, 2015, 10:24 p.m., Gregor Mi wrote
skanlite - all - wants a framework KF5Sane (does this exist?)
Gregor Mi ported both libksane and Skanlite to KF5 last year. They are both
in the
frameworks branch. libksane is not yet a framework, but I think he prepared
libksane for it.
For me Skanlite compiles fine
---
On April 17, 2015, 7:25 a.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/
---
(Updated
://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/5565e806-bf16-4ef2-89f2-ac122bf3421c__messagebox.png
Thanks,
Gregor Mi
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/#review79097
---
On April 17, 2015, 7:25 a.m., Gregor Mi wrote
On April 17, 2015, 7:31 a.m., Martin Gräßlin wrote:
I'm still not sure about the text for the message box: could you please add
Thomas Pfeiffer from Usability team to the review to get him comment on it?
Gregor Mi wrote:
Sure. I'll add him.
I updated the text.
Message box without
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/#review79059
---
On April 17, 2015, 7:32 a.m., Gregor Mi wrote
.
Users might not know what KWin is.
Gregor Mi wrote:
I also would like that better. I tried
- QApplication::desktop()-window()-windowTitle();
- QApplication::desktop()-windowTitle();
Any other hint on how access this information?
Thomas Lübking wrote:
http
://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/5565e806-bf16-4ef2-89f2-ac122bf3421c__messagebox.png
Thanks,
Gregor Mi
a KActionCollection for component kwin
* add a QAction with the shortcut name you want
* ask KGlobalAccel to load the shortcut for it.
Gregor Mi wrote:
Thanks for the hint but I am not sure of how to use the API in such a
way. I tried two things:
1)
org::kde
://git.reviewboard.kde.org/r/122249/#comment53290
requires https://git.reviewboard.kde.org/r/122981/ to be submitted
- Gregor Mi
On March 13, 2015, 10:08 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
-4358-9a63-a85dae5722bd__screenshot_default1.png
Drop down shows Kill Window
https://git.reviewboard.kde.org/media/uploaded/files/2015/01/28/58df12c5-7350-4bb0-b602-c5716caa9836__screenshot_default2.png
Thanks,
Gregor Mi
-a85dae5722bd__screenshot_default1.png
Drop down shows Kill Window
https://git.reviewboard.kde.org/media/uploaded/files/2015/01/28/58df12c5-7350-4bb0-b602-c5716caa9836__screenshot_default2.png
Thanks,
Gregor Mi
a KActionCollection for component kwin
* add a QAction with the shortcut name you want
* ask KGlobalAccel to load the shortcut for it.
Gregor Mi wrote:
Thanks for the hint but I am not sure of how to use the API in such a
way. I tried two things:
1)
org::kde
a KActionCollection for component kwin
* add a QAction with the shortcut name you want
* ask KGlobalAccel to load the shortcut for it.
Gregor Mi wrote:
Thanks for the hint but I am not sure of how to use the API in such a
way. I tried two things:
1)
org::kde
a KActionCollection for component kwin
* add a QAction with the shortcut name you want
* ask KGlobalAccel to load the shortcut for it.
Gregor Mi wrote:
Thanks for the hint but I am not sure of how to use the API in such a
way. I tried two things:
1)
org::kde
a KActionCollection for component kwin
* add a QAction with the shortcut name you want
* ask KGlobalAccel to load the shortcut for it.
Gregor Mi wrote:
Thanks for the hint but I am not sure of how to use the API in such a
way. I tried two things:
1)
org::kde
a KActionCollection for component kwin
* add a QAction with the shortcut name you want
* ask KGlobalAccel to load the shortcut for it.
Gregor Mi wrote:
Thanks for the hint but I am not sure of how to use the API in such a
way. I tried two things:
1)
org::kde
-c5716caa9836__screenshot_default2.png
Thanks,
Gregor Mi
a KActionCollection for component kwin
* add a QAction with the shortcut name you want
* ask KGlobalAccel to load the shortcut for it.
Gregor Mi wrote:
Thanks for the hint but I am not sure of how to use the API in such a
way. I tried two things:
1)
org::kde
a KActionCollection for component kwin
* add a QAction with the shortcut name you want
* ask KGlobalAccel to load the shortcut for it.
Gregor Mi wrote:
Thanks for the hint but I am not sure of how to use the API in such a
way. I tried two things:
1)
org::kde
a KActionCollection for component kwin
* add a QAction with the shortcut name you want
* ask KGlobalAccel to load the shortcut for it.
Gregor Mi wrote:
Thanks for the hint but I am not sure of how to use the API in such a
way. I tried two things:
1)
org::kde
a KActionCollection for component kwin
* add a QAction with the shortcut name you want
* ask KGlobalAccel to load the shortcut for it.
Gregor Mi wrote:
Thanks for the hint but I am not sure of how to use the API in such a
way. I tried two things:
1)
org::kde
a KActionCollection for component kwin
* add a QAction with the shortcut name you want
* ask KGlobalAccel to load the shortcut for it.
Gregor Mi wrote:
Thanks for the hint but I am not sure of how to use the API in such a
way. I tried two things:
1)
org::kde
a KActionCollection for component kwin
* add a QAction with the shortcut name you want
* ask KGlobalAccel to load the shortcut for it.
Gregor Mi wrote:
Thanks for the hint but I am not sure of how to use the API in such a
way. I tried two things:
1)
org::kde
a KActionCollection for component kwin
* add a QAction with the shortcut name you want
* ask KGlobalAccel to load the shortcut for it.
Gregor Mi wrote:
Thanks for the hint but I am not sure of how to use the API in such a
way. I tried two things:
1)
org::kde
a KActionCollection for component kwin
* add a QAction with the shortcut name you want
* ask KGlobalAccel to load the shortcut for it.
Gregor Mi wrote:
Thanks for the hint but I am not sure of how to use the API in such a
way. I tried two things:
1)
org::kde
a KActionCollection for component kwin
* add a QAction with the shortcut name you want
* ask KGlobalAccel to load the shortcut for it.
Gregor Mi wrote:
Thanks for the hint but I am not sure of how to use the API in such a
way. I tried two things:
1)
org::kde
be used?
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/#review76861
---
On Feb. 27, 2015, 1:18 a.m., Gregor Mi wrote
,
Gregor Mi
Thanks,
Gregor Mi
::notify: Calling notify on Sound
Segmentation fault
I also wonder why I don't get a stack trace on console even though I build in
debug configuration. Any hint?
- Gregor Mi
On Feb. 20, 2015, 11:35 p.m., Gregor Mi wrote
-a85dae5722bd__screenshot_default1.png
Drop down shows Kill Window
https://git.reviewboard.kde.org/media/uploaded/files/2015/01/28/58df12c5-7350-4bb0-b602-c5716caa9836__screenshot_default2.png
Thanks,
Gregor Mi
:
https://git.reviewboard.kde.org/r/121831/#review76358
---
On Feb. 20, 2015, 9:46 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
-command has a trailing space???
[ 451s]^
Gregor Mi wrote:
Probably `proc-command` must be replace with `proc-command()`. I'll
check that.
How can I find out if which branch was compiled? I assume it is the master
branch.
- Gregor
functionality into
KWindowSystem (option for portage) - invoking a kwin shortcut through a
kglobalaccel dbus call is a hack. Maybe sufficient for any downstream
solution, but easily broken feature.
Gregor Mi wrote:
First of all, a clarification of this RR's intentions:
1) The original End
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown; no visible error. Unit tests succeed.
Thanks,
Gregor Mi
, visit:
https://git.reviewboard.kde.org/r/121831/#review76201
---
On Feb. 15, 2015, 4:35 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/
---
(Updated Feb. 20, 2015, 11:35 p.m.)
Review
functionality into
KWindowSystem (option for portage) - invoking a kwin shortcut through a
kglobalaccel dbus call is a hack. Maybe sufficient for any downstream
solution, but easily broken feature.
Gregor Mi wrote:
First of all, a clarification of this RR's intentions:
1) The original End
/
Testing
---
Compiles and runs. Data is still shown; no visible error. Unit tests succeed.
Thanks,
Gregor Mi
use the setters, which also sets 'changes |= Process::Gids;'
Is that maybe an issue? I myself don't know the code well enough to see
this here.
Gregor Mi wrote:
True. Thanks for noticing. The changes will be read in
ProcessModelPrivate::processChanged when a change
On 01/31/2015 08:57 PM, Alexander Neundorf wrote:
hmm, looking back at our switch to git, I don't consider our standards for
documentation of the developer workflow as very high unfortunately. :-/
Considering I wrote the majority of
https://community.kde.org/Sysadmin/GitKdeOrgManual I
.
Gregor Mi wrote:
In the current RR state there are some reference-getters left because it
made the porting easier. Should they be converted to non-reference getters,
too?
I drop the issue. The potential removal of remaining reference-getters can be
done in another commit.
- Gregor
use the setters, which also sets 'changes |= Process::Gids;'
Is that maybe an issue? I myself don't know the code well enough to see
this here.
Gregor Mi wrote:
True. Thanks for noticing. The changes will be read in
ProcessModelPrivate::processChanged when a change
functionality into
KWindowSystem (option for portage) - invoking a kwin shortcut through a
kglobalaccel dbus call is a hack. Maybe sufficient for any downstream
solution, but easily broken feature.
Gregor Mi wrote:
First of all, a clarification of this RR's intentions:
1) The original End
functionality into
KWindowSystem (option for portage) - invoking a kwin shortcut through a
kglobalaccel dbus call is a hack. Maybe sufficient for any downstream
solution, but easily broken feature.
Gregor Mi wrote:
First of all, a clarification of this RR's intentions:
1) The original End
-a85dae5722bd__screenshot_default1.png
Drop down shows Kill Window
https://git.reviewboard.kde.org/media/uploaded/files/2015/01/28/58df12c5-7350-4bb0-b602-c5716caa9836__screenshot_default2.png
Thanks,
Gregor Mi
functionality into
KWindowSystem (option for portage) - invoking a kwin shortcut through a
kglobalaccel dbus call is a hack. Maybe sufficient for any downstream
solution, but easily broken feature.
Gregor Mi wrote:
First of all, a clarification of this RR's intentions:
1) The original End
://git.reviewboard.kde.org/r/122249/#review74740
---
On Jan. 25, 2015, 6:21 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://git.reviewboard.kde.org/r/121831/#review74463
---
On Jan. 25, 2015, 12:01 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Jan. 25, 2015, 5:28 p.m., Alex Richardson wrote:
processui/scripting.h, line 74
https://git.reviewboard.kde.org/r/121831/diff/5/?file=344700#file344700line74
Isn't just changing the PROPERTY macro enough?
Or is it used in some other file?
Gregor Mi wrote:
I did
580df8db152040f1ad075430fdce08fe7ad4ae2d
.reviewboardrc PRE-CREATION
CMakeLists.txt cefc86f12be684e195bd148641483e9e1734e636
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown; no visible error. Unit tests succeed.
Thanks,
Gregor Mi
processcore/process.cpp a38b8be71da1a51cb87f636664ebac817b1d20ab
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown; no visible error. Unit tests succeed.
Thanks,
Gregor Mi
processui/scripting.h 2445c0ab0d81af3283c0f6e9c5f349a3d70b0de9
processui/scripting.cpp 76291b0ae0a26e486aa81a4ca3976ff4a47cb3c0
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown; no visible error. Unit tests succeed.
Thanks,
Gregor Mi
a38b8be71da1a51cb87f636664ebac817b1d20ab
processcore/processes.h d09c3265333fe7e2702deaa910c5fbe4bc3ac9e6
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown. No error.
Thanks,
Gregor Mi
967b03fae1e460bfb22e1a07ef05cf7b49412546
tests/keyboardshortcututiltest.h PRE-CREATION
tests/keyboardshortcututiltest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122249/diff/
Testing
---
Thanks,
Gregor Mi
---
On Jan. 25, 2015, 12:01 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121831
in the future
einar77 gregormi: see https://git.reviewboard.kde.org/r/122215/
?
- Gregor Mi
On Jan. 25, 2015, 6:21 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
967b03fae1e460bfb22e1a07ef05cf7b49412546
tests/keyboardshortcututiltest.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122249/diff/
Testing
---
Thanks,
Gregor Mi
tests/keyboardshortcututiltest.h PRE-CREATION
tests/keyboardshortcututiltest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122249/diff/
Testing
---
Thanks,
Gregor Mi
/diff/
Testing
---
Thanks,
Gregor Mi
.
Thanks,
Gregor Mi
---
On Jan. 19, 2015, 6:17 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121831
/ProcessModel.cpp 53bc041110c9cdb686fef783895104969b661889
processui/scripting.h 2445c0ab0d81af3283c0f6e9c5f349a3d70b0de9
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown. No error.
Thanks,
Gregor Mi
4dc142e864d8353ceafc3a6735ffa81e48291420
processui/scripting.h 2445c0ab0d81af3283c0f6e9c5f349a3d70b0de9
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown. No error.
Thanks,
Gregor Mi
4dc142e864d8353ceafc3a6735ffa81e48291420
processui/scripting.h 2445c0ab0d81af3283c0f6e9c5f349a3d70b0de9
Diff: https://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown. No error.
Thanks,
Gregor Mi
://git.reviewboard.kde.org/r/121831/diff/
Testing
---
Compiles and runs. Data is still shown. No error.
Thanks,
Gregor Mi
/121831/#comment51460
Requires SOVERSION bump.
And: wouldn't it be better to move the now private variables behind a d_ptr?
- Gregor Mi
On Jan. 12, 2015, 2:30 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail
/122072/ about
redesigning it with d_ptr to make process.h future-proof
- Gregor Mi
On Jan. 12, 2015, 2:30 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121831
interaction (like mouse
hovering/moving or sorting).
New unit test passes.
Thanks,
Gregor Mi
(like mouse
hovering/moving or sorting).
New unit test passes.
Thanks,
Gregor Mi
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121717/#review73714
---
On Jan. 12, 2015, 2:07 p.m., Gregor Mi wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121717/#review73675
---
On Jan. 12, 2015, 2:07 p.m., Gregor Mi wrote
1 - 100 of 108 matches
Mail list logo
