Re: KDE Builder: request for review

2024-04-09 Thread Kevin Kofler
? Do we not have enough pointless porting busywork for the incompatible Qt major releases yet, so now we need the same for KDE Builder? Kevin Kofler

Re: Kandalf: request for review

2023-12-13 Thread Kevin Kofler
ontain a 'k', so I think those are kooler. ;-) (Yes, the misspellings of "contain" and "cooler" in the previous sentence were intentional. ;-) ) Kevin Kofler

Re: what to do with phonon & why aren't you using it?

2023-03-24 Thread Kevin Kofler
favor of a completely new one). But if you are going to revisit the Phonon API anyway, it may be worth considering to work with QtMultimedia instead. I would rather have one working multimedia framework for Qt than two half-unmaintained ones. Kevin Kofler

Re: Moving FutureSQL to KDE review

2023-03-24 Thread Kevin Kofler
going to depend on a library that requires C++20 to build? Either we can use C++20 or we cannot. Kevin Kofler

Re: what to do with phonon & why aren't you using it?

2023-03-14 Thread Kevin Kofler
east one of the two APIs will go away, maybe even both (in favor of a completely new one). But if you are going to revisit the Phonon API anyway, it may be worth considering to work with QtMultimedia instead. I would rather have one working multimedia framework for Qt than two half-unmaintained ones. Kevin Kofler

Re: Usage of KF5/KF6 in targets and CMake config files outside of Frameworks

2023-03-09 Thread Kevin Kofler
eworks later. Kevin Kofler

Re: KDE Review: Arianna

2023-02-27 Thread Kevin Kofler
r and Okular cannot, so that is why I am asking how they compare. Kevin Kofler

Re: KDE Review: Arianna

2023-02-25 Thread Kevin Kofler
r and Okular cannot, so that is why I am asking how they compare. Kevin Kofler

Re: Email server update - migration from Mailman 2

2023-02-05 Thread Kevin Kofler
static mailing list archives is not. Broken links sound like a showstopper to me. […] openSUSE developed a way to map legacy discussions on mlmmj to HyperKitty, while Fedora just retained the old Pipemail static pages. Either works. So either solution would need to be implemented on KDE mailing lists too. Kevin Kofler

Re: Gitlab update, 2FA now mandatory

2023-02-05 Thread Kevin Kofler
Kevin Kofler wrote: > What am I expected to use with my PinePhone? Does > https://apps.kde.org/keysmith/ work? To answer my own question: Yes, Keysmith works, both on the desktop (and notebook) and on the PinePhone. It is also easily possible to synchronize the keyring between different d

Re: ghostwriter is ready for your review

2023-02-05 Thread Kevin Kofler
like the Font Awesome ones. And other operating systems might not even attempt to fall back to a font that actually provides the icon. Windows at least used to have no such fallback mechanism, though I have not used it for years, so that might have changed since. Kevin Kofler

Re: Email server update - migration from Mailman 2

2023-02-05 Thread Kevin Kofler
m to be currently deployed in Fedora at least, they are using what I assume to be a static copy of the old archives) is IMHO required. Kevin Kofler

Re: Email server update - migration from Mailman 2

2022-11-27 Thread Kevin Kofler
by some project, but it does not seem to be currently deployed in Fedora at least, they are using what I assume to be a static copy of the old archives) is IMHO required. Kevin Kofler

Re: Gitlab update, 2FA now mandatory

2022-11-07 Thread Kevin Kofler
Kevin Kofler wrote: > What am I expected to use with my PinePhone? Does > https://apps.kde.org/keysmith/ work? To answer my own question: Yes, Keysmith works, both on the desktop (and notebook) and on the PinePhone. It is also easily possible to synchronize the keyring between different d

Re: Gitlab update, 2FA now mandatory

2022-10-24 Thread Kevin Kofler
s using state-of-the-art technology to protect > personal information, using 2FA is, in my opinion (but I'm not a lawyer), > a must for any website that stores personal information. See above, almost nobody else does this, so that interpretation of the GDPR is pure nonsense. Kevin Kofler

Re: Gitlab update, 2FA now mandatory

2022-10-23 Thread Kevin Kofler
Ben Cooksley wrote: > On Mon, Oct 24, 2022 at 3:36 AM Kevin Kofler > wrote: >> IMHO, this is both an absolutely unacceptable barrier to entry and a >> constant annoyance each time one has to log in. > > You shouldn't have any issues with remaining logged in as long as you

Re: Gitlab update, 2FA now mandatory

2022-10-23 Thread Kevin Kofler
PS: Kevin Kofler wrote: > Ben Cooksley wrote: >> I have also enabled Mandatory 2FA, which Gitlab will ask you to configure >> next time you access it. > > IMHO, this is both an absolutely unacceptable barrier to entry and a > constant annoyance each time one has to log

Re: Gitlab update, 2FA now mandatory

2022-10-23 Thread Kevin Kofler
P app on the same device as the web browser (both on the smartphone or even both on the desktop/notebook)? You just cannot. (As far as I know, even Yubikeys can be emulated in software.) Two-factor is a farce. Kevin Kofler

Re: Move Licentia to KDEREVIEW

2022-08-08 Thread Kevin Kofler
dependency's copy of the license, the license really has to be included with every tarball.) Kevin Kofler

Re: Is there (going to be) an auto-retracer service for KDE?

2021-05-10 Thread Kevin Kofler
mps can be very huge, which means uploading them can actually take longer than downloading the debugging information on asymmetric consumer broadband, and which also means it can come out expensive on metered or capped Internet connection plans. Kevin Kofler

Re: MauiKit and Index review

2020-09-28 Thread Kevin Kofler
ately, Index is an extremely generic name. Kevin Kofler

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-19 Thread Kevin Kofler
turn new MarkdownPart. > > Similar lines exist in markdownpart.cpp, though there you use auto almost > in all these cases. IMHO, this just makes the code harder to read (as most uses of "auto"). Kevin Kofler

Re: Gitlab Turn-off Issues

2020-06-30 Thread Kevin Kofler
So seeing this stated as the main reason for having switched to GitLab strikes me as very odd. Kevin Kofler

Re: Gitlab Turn-off Issues

2020-06-29 Thread Kevin Kofler
ecause everyone depends on this new monopoly now. (I see more and more big Free Software projects moving to it.) I think we really need either an uncrippled fork of GitLab or the high-profile users switching to really Free, not crippled, forges. (What was wrong with Phabricator?) Kevin Kofler

Re: Move Koko to KDEReview

2020-06-15 Thread Kevin Kofler
ill get away with it depends on what the files do and what license they fall under.) I personally do not think that it is acceptable for an image viewer to require an Internet connection at runtime. Your proposed solution only moves the problem instead of solving it. Kevin Kofler

Re: Move Koko to KDEReview

2020-06-15 Thread Kevin Kofler
ines even *have* an internet connection during configure / > build stages). Yep, this is an absolute no go in Fedora. The build system (Koji) has all Internet connection deliberately blocked. Packages MUST NOT attempt to access the Internet during builds. No exceptions. Kevin Kofler

Re: CI talk (Was: re: Manner in which kde-gtk-config development is conducted)

2020-03-27 Thread Kevin Kofler
ave promised to you without consulting me first) may have caused to you. It will never happen the same way again. Kevin Kofler

Re: Keysmith in kdereview

2019-12-18 Thread Kevin Kofler
ttempts to bring this standardized C99 feature into the C++ standard (and even got C11 to make it optional for C too). Kevin Kofler

Re: Blacklisting of PIM from the CI system

2019-12-04 Thread Kevin Kofler
work for this, because it is not monotonic. What you really want to know is whether you have something >= 5.65.0.abcd123, and having a 5.65.0.commithash version is not going to tell you that. Kevin Kofler

Re: rekonq to unmaintained

2019-09-12 Thread Kevin Kofler
Harald Sitter wrote: > Its master branch is still kdelibs4, the frameworks branch hasn't seen > any progress in 21 months. Hasn't had a release in years. Very > unmaintained all in all. And there is also a working, maintained successor (Falkon). Kevin Kofler

Re: Missing newline check

2018-12-14 Thread Kevin Kofler
eature a preference as in the KatePart. Kevin Kofler

Re: Falkon in kdereview

2018-02-28 Thread Kevin Kofler
in JITted code (e.g., JavaScript compiled by the V8 JIT), in which case you cannot possibly get a useful backtrace at all, no matter how much debugging information you enable. Kevin Kofler

Re: Python bindings using cppyy (was: An update on Python bindings)

2017-11-25 Thread Kevin Kofler
Philipp A. wrote: > No, because you’re missing something here: There’s no KF5 bindings. So > every project that’ll use Shaheed’s new cool KF5 bindings will be a new > project. There is PyKDE4 that people will want to port their legacy programs from. Kevin Kofler

Re: Python bindings using cppyy (was: An update on Python bindings)

2017-10-16 Thread Kevin Kofler
LLVM users such as Mesa/Gallium3D/llvmpipe). ROOT is a huge bloated framework that is not exactly reputed for its simplicitly to package. Kevin Kofler

Re: How to install icons for multiple themes

2017-04-21 Thread Kevin Kofler
eme. Kevin Kofler

Re: How to install icons for multiple themes

2017-04-21 Thread Kevin Kofler
Matthias Klumpp wrote: > And since the spec allows themes to define arbitrary layouts, there is > technically nothing wrong with the Breeze theme. IMHO, doing things differently just because you can, even if it breaks KDE's own ECM macros, is not helpful. Kevin Kofler

Re: How to install icons for multiple themes

2017-04-21 Thread Kevin Kofler
ths to match the other themes? The Fedora package actually creates a whole hierarchy of empty directories such as 16x16/apps under Breeze: http://pkgs.fedoraproject.org/cgit/rpms/breeze-icon-theme.git/tree/breeze-icon-theme.spec#n82 I think it would really be helpful to make Breeze match the de-facto standard directory hierarchy. Kevin Kofler

Re: CI Requirements - Lessons Not Learnt?

2017-01-21 Thread Kevin Kofler
Kevin Kofler wrote: > The new xkbcommon requirement is also an issue for us in Fedora. The new > xkbcommon 0.7.0 is only available in Rawhide and it is doubtful that it > will ever be backported to Fedora 25 or 24. So, if we cannot get > libxkbcommon updated, we will either be unabl

Re: CI Requirements - Lessons Not Learnt?

2017-01-15 Thread Kevin Kofler
absolutely necessary to make your software work on some distributions. (Sure, in this particular case, xkbcommon can be updated, if distribution policies allow it. But you are talking about dependency changes in general, which can have bumped sonames or other incompatibilities.) Kevin Kofler

Re: CI Requirements - Lessons Not Learnt?

2017-01-15 Thread Kevin Kofler
sysadmins for an exception, and if the process (of course you have to wait for their answer, and ideally for them to update the CI) makes you miss the feature freeze, ask the release team for an exception to the freeze. Kevin Kofler

Re: CI Requirements - Lessons Not Learnt?

2017-01-13 Thread Kevin Kofler
quot;supported releases", I meant supported by the distribution. E.g., for RHEL/CentOS, that is currently RHEL/CentOS 5, 6 and 7. For Fedora, that is currently Fedora 24 and 25. Kevin Kofler

Re: CI Requirements - Lessons Not Learnt?

2017-01-13 Thread Kevin Kofler
, but only ones which were already in the previous release.) As I understand it, this is exactly the situation we are in with KWin and xkbcommon now. Kevin Kofler

Re: CI Requirements - Lessons Not Learnt?

2017-01-12 Thread Kevin Kofler
rk". It is that or not have the code at all. And the existing old version was already "broken" in the same way. Kevin Kofler

Re: CI Requirements - Lessons Not Learnt?

2017-01-12 Thread Kevin Kofler
is the biggest pain point when it comes to the quality of the software itself, and that is unrelated to the dependency issues you mention. Kevin Kofler

Re: CI Requirements - Lessons Not Learnt?

2017-01-12 Thread Kevin Kofler
Martin Gräßlin wrote: > Everybody except I. I would have to maintain that mess. And I don't have > time to maintain multiple compile time paths. I don't see how it would be any more work to maintain #if FEATURE as compared to #if 0. Kevin Kofler

Re: CI Requirements - Lessons Not Learnt?

2017-01-11 Thread Kevin Kofler
everybody will be happy. Kevin Kofler

Re: CI Requirements - Lessons Not Learnt?

2017-01-11 Thread Kevin Kofler
, currently RHEL 7 from 2014. Or you could ignore RHEL entirely and only consider fast-moving distros such as Fedora.) Kevin Kofler

Re: CI Requirements - Lessons Not Learnt?

2017-01-11 Thread Kevin Kofler
it as a last resort only.) Kevin Kofler

Re: CI Requirements - Lessons Not Learnt?

2017-01-06 Thread Kevin Kofler
se lately, with dependencies on bleeding-edge versions of: xkbcommon, Wayland libraries, etc. (And KWin is one of the worst offenders there, though definitely not the only one.) Kevin Kofler

Re: CI Requirements - Lessons Not Learnt?

2017-01-06 Thread Kevin Kofler
d in stable releases (or in the worst case, even in Rawhide). Kevin Kofler

Re: CI Requirements - Lessons Not Learnt?

2017-01-05 Thread Kevin Kofler
rg to >> fetch it. > > Mesa 13 is news to me. This is also an issue for us: Mesa 13 is only available in Fedora 25 (updates) and Rawhide, not in Fedora 24. Kevin Kofler

Re: Dropping kdelibs4-based applications in KDE Applications 17.12

2016-11-12 Thread Kevin Kofler
t; surrect it from there. Even if you stop releasing the kdelibs, distros will keep releasing them for much longer, some for a lot longer. (E.g., we still also ship kdelibs3 in Fedora and I have no plans to let it go.) Kevin Kofler

Re: Review Request 129233: [kdelibs] Make Qt4 WebKit optional (default on)

2016-10-24 Thread Kevin Kofler
.x86_64 tomahawk-0:0.8.4-12.fc26.x86_64 tomahawk-libs-0:0.8.4-12.fc26.i686 tomahawk-libs-0:0.8.4-12.fc26.x86_64 vtk-qt-0:6.3.0-11.fc26.i686 vtk-qt-0:6.3.0-11.fc26.x86_64 Kevin Kofler

QtWebEngine on Wayland (was: Re: Test your applications on Wayland)

2016-10-12 Thread Kevin Kofler
infrastructure (QupZilla, the Calamares webview module, etc.). Kevin Kofler

Re: KRandom regression + fix

2016-05-05 Thread Kevin Kofler
Albert Astals Cid wrote: > From my "i know nothing about random numbers", i guess it's hard to write > a unit test for a sequente of random numbers, you can get ten "3" in a row > and it's still a valid random sequence. https://xkcd.com/221/ ;-) Kevin Kofler

Re: [Kde-pim] Qt 4 Builds

2016-03-27 Thread Kevin Kofler
you by KNode (through Gmane). Kevin Kofler

Re: [Kde-pim] Qt 4 Builds

2016-03-27 Thread Kevin Kofler
laurent Montel wrote: > We will not create more release from kdepim4, no distro uses it even > debian :) Fedora will ship (it's currently under review) a kdepim4 package containing KNode and KTimeTracker, which are not included in the new KF5 kdepim. Kevin Kofler

Re: KDE file dialog

2016-03-05 Thread Kevin Kofler
on a variety of criteria, including glyph coverage (OK, Noto is great there; your previous default Oxygen was not, though!), quality, looks, etc. And most importantly, the distro-wide aliases ensure consistency across applications using different toolkits. Desktops deciding they know better break this. Kevin Kofler

Re: Policy regarding QtWebKit and QtScript

2016-01-06 Thread Kevin Kofler
That said, your example is actually a bad example because Chromium/QtWebEngine does not actually bundle giflib. (It uses its own GIF decoder, which is forked from WebKit's, which is forked from Mozilla's.) Kevin Kofler

Re: Policy regarding QtWebKit and QtScript

2016-01-06 Thread Kevin Kofler
lugins=0 \ make_clang_dir=/usr flags that desktop-linux.pri sets when building for a linux-clang target? > - Example from qt3d (so external to this discussion), using a broken > OffsetOf in a bundled third party library. Yes, bundled libraries suck and this kind of issues is another reason why. Kevin Kofler

Re: Policy regarding QtWebKit and QtScript

2016-01-06 Thread Kevin Kofler
u guys have the even harder task porting to *BSD. Don't give up, it can be done. Kevin Kofler

Re: Why is C90 enforced in KDE?

2015-12-19 Thread Kevin Kofler
be an older or patched one. This is entirely a compatibility issue between 2 build tools (Flex and the compiler), I don't see how this should be our (KDE's) problem. Kevin Kofler

Re: Why is C90 enforced in KDE?

2015-12-06 Thread Kevin Kofler
d not. Generated files have no business being in a source control or in source tarballs. "BuildRequires: flex" is one line in a distro specfile. Kevin Kofler

Re: Why is C90 enforced in KDE?

2015-12-06 Thread Kevin Kofler
(I think it was about using stdint.h or something like that.) So I am not surprised that they are now using C99 comments (which ARE compliant to the current C standard, and have been for 16 years (!)). Kevin Kofler

Re: Naming scheme for Qt5/KF5-based libraries outside of KF5

2015-09-27 Thread Kevin Kofler
e name would prevent that (for the usual problems with > ABI changes). Not if you ship your not-yet-in-KF5 library with a soversion (soname major version) < 5. (I'd just pick 0.) Kevin Kofler

Re: Naming scheme for Qt5/KF5-based libraries outside of KF5

2015-09-27 Thread Kevin Kofler
s a Framework. > 3) Moving something from "not a KDE Framework" to "KDE Framework" gives > a last chance for fixing up abi/api. If you need to fix the ABI, you should just bump the soname major version. I'd just use libKF5*.so.0 (instead of the normal .5) for libraries that are not yet Frameworks. Kevin Kofler

Re: RFC: KDE Bugzilla Bugs Expiration

2015-07-31 Thread Kevin Kofler
-application scripts. I would also strongly argue for keeping this manual for all applications whose maintainer(s) didn't explicitly opt in to such an autoclosing policy. Kevin Kofler

Re: Notes from the Phabricator BoF

2015-07-30 Thread Kevin Kofler
Luigi Toscano wrote: Feedback on Phabricator gathered outside the BoF from people who could not attend: Were there no complaints about the fact that you can still not view anything at all without logging in? Kevin Kofler

Re: Review Request 124163: Use KIO::Overwrite when saving a changed file otherwise it always fails.

2015-07-09 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124163/#review82295 --- Ship it! Ship It! - Kevin Kofler On Juni 24, 2015, 12:33

Re: Alternative to QDateTime::isDateOnly ?

2015-05-10 Thread Kevin Kofler
Christian Mollekopf wrote: 4. Would be pretty good IMO, but unfortunately leads to an unexpressive interface (because QVariant can't be parametrized with valid values). You would just document in the API documentation what types the returned QVariant can take. Kevin Kofler

Re: Distros and QtWebEngine

2015-04-21 Thread Kevin Kofler
have the reputation of hiding spyware (mis)features in their code. Kevin Kofler

Re: Distros and QtWebEngine

2015-04-21 Thread Kevin Kofler
bug reports regarding this situation and they were never resolved. And this is exactly why we urge KDE to not require QtWebEngine for anything. Kevin Kofler

Re: Distros and QtWebEngine

2015-04-21 Thread Kevin Kofler
or ExclusiveArch lists all over the place.) Kevin Kofler

Re: Distros and QtWebEngine

2015-04-21 Thread Kevin Kofler
into March.) Kevin Kofler

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

2015-02-11 Thread Kevin Kofler
On Feb. 9, 2015, 10:01 nachm., Kevin Kofler wrote: IMHO, QUrl::fromUserInput(str, QString() QUrl::AssumeLocalFile) would be safer. Or do you really think dolphin nonexistentfile should look up nonexistentfile over DNS? Thomas Lübking wrote: +1, notably since http

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

2015-02-09 Thread Kevin Kofler
::AssumeLocalFile) would be safer. Or do you really think dolphin nonexistentfile should look up nonexistentfile over DNS? - Kevin Kofler On Feb. 9, 2015, 12:48 nachm., Arjun AK wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Another proposal for modernization of our infrastructure

2015-01-29 Thread Kevin Kofler
, this contradicts the web maxim of graceful degradation. Why can the work not be done on the server side? Especially for the integration between services, I would expect a simple API call for data lookup to be doable on the server side at least as easily as from client- side JavaScript. Kevin Kofler

Re: libkgeomap

2015-01-29 Thread Kevin Kofler
now bundled in Digikam should be a dependency of Digikam as it used to be in the past. Kevin Kofler

Re: Feature matrix for future infrastructure

2015-01-26 Thread Kevin Kofler
upload feature should be a requirement. (I also agree with other posters that it would be more friendly to newcomers, too.) Kevin Kofler

Re: State of kdesvn?

2015-01-21 Thread Kevin Kofler
say just commit/push the patches. If there's no maintainer, there's also nobody to complain. :-) (Wo kein Kläger, da auch kein Richter.) Kevin Kofler

Re: Adding experimental parts to a KF5 library

2015-01-15 Thread Kevin Kofler
give it a 0.x soversion and remember to increment x on each BIC change, we will know to rebuild affected packages. The only thing worse than ABI changes is SILENT ABI changes. Kevin Kofler

Re: Adding experimental parts to a KF5 library

2015-01-12 Thread Kevin Kofler
is also very commonly used for the first stable-ABI version of a library) and tracking binary incompatible changes in a sane way (without losing the zero major version). Kevin Kofler

Re: [Kde-pim] Problems with infrastructure

2014-12-15 Thread Kevin Kofler
uniformity or we don't and then we end up with reviewborad+gerrit (Albert Astals Cid), which to me sounds a lot like blackmail (of course not by Albert, he's just the messenger). Kevin Kofler

Re: [Kde-pim] Problems with infrastructure

2014-12-14 Thread Kevin Kofler
(it was always made clear that it is only an experiment and can be ended at any moment), and kick out Trojitá from KDE if Jan absolutely wants to use Gerrit. (It's not even a KF5 or kdelibs application, but a Qt-only one.) Then he can use whatever tools he wants. Problem solved. Kevin Kofler

Re: API Breakage?: Re: [kcmutils] src: Fix typo in headers generation

2014-12-10 Thread Kevin Kofler
-sensitive to begin with, and only install the compatibility headers on case-sensitive file systems. Kevin Kofler

Re: New framework to review: KPackage

2014-12-10 Thread Kevin Kofler
Marco Martin wrote: In the past weeks I have been working on a new framework, called KPackage. You ARE aware that KPackage was the name of an old frontend for RPM and other package managers that used to be part of the KDE Software Compilation 4? Kevin Kofler

Re: KFind

2014-12-05 Thread Kevin Kofler
laurent Montel wrote: Indeed it's not finish to port (I worked on it too). Still depend against kdelibs4support . So what? That will only become a problem when Qt 6 gets released years from now. Kevin Kofler

Re: Review Request 120627: Remove kdelibs4support.

2014-10-21 Thread Kevin Kofler
/include/kde4. :-) Kevin Kofler

Re: Review Request 120676: Remove other kdelibs4support headers

2014-10-21 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120676/#review68809 --- Ship it! Ship It! - Kevin Kofler On Okt. 21, 2014, 2:53

Re: Review Request 120697: Remove one last klocale.h include.

2014-10-21 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120697/#review68836 --- Ship it! Ship It! - Kevin Kofler On Okt. 21, 2014, 7:15

Re: Review Request 120627: Remove kdelibs4support.

2014-10-18 Thread Kevin Kofler
On Okt. 18, 2014, 4:40 vorm., Kevin Kofler wrote: komparepart/kompare_part.cpp, line 303 https://git.reviewboard.kde.org/r/120627/diff/3/?file=320382#file320382line303 So where does this temporary file get deleted? Apparently nowhere. You have to handle this the same

Re: Review Request 120627: Remove kdelibs4support.

2014-10-18 Thread Kevin Kofler
, inside which you can safely use even predictable file names, and you can also reuse the existing cleanup code. - Kevin Kofler On Okt. 18, 2014, 5:01 vorm., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply

Re: QUrl from a string (porting KUrl constructor or KCmdLineArgs::url)

2014-10-18 Thread Kevin Kofler
Alex Merry wrote: Could you add this to the porting guide, please? Done, also added KUrl::prettyUrl → QUrl::toDisplayString as per the other thread. Kevin Kofler

Re: Review Request 120627: Remove kdelibs4support.

2014-10-18 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627/#review68677 --- Ship it! Looks good now. - Kevin Kofler On Okt. 18, 2014

Re: Review Request 120627: Remove kdelibs4support.

2014-10-17 Thread Kevin Kofler
years after KDE 4.0.0.) There is really no need to commit a half-broken port just to eliminate kdelibs4support now. - Kevin Kofler On Okt. 17, 2014, 4:17 nachm., Jeremy Whiting wrote: --- This is an automatically generated e-mail

Re: Review Request 120627: Remove kdelibs4support.

2014-10-17 Thread Kevin Kofler
On Okt. 17, 2014, 6:03 nachm., Kevin Kofler wrote: Use QLayout/QFrame instead of KVBox (seems broken though somehow) Then I suggest you either fix it, or submit only the parts of the port that work. We have time until KF6 to port away from kdelibs4support, that's years ahead

Re: Review Request 120630: Port from KTempDir to QTemporaryDir. Port from KUrl to QUrl.

2014-10-17 Thread Kevin Kofler
together with a matching Kompare change, doesn't it? (One more reason to do the Kompare parts in smaller chunks.) - Kevin Kofler On Okt. 17, 2014, 4:21 nachm., Jeremy Whiting wrote: --- This is an automatically generated e-mail

Re: Review Request 120627: Remove kdelibs4support.

2014-10-17 Thread Kevin Kofler
::fromLocalFile(args.at(1)) : QUrl(args.at(1)) - Kevin Kofler On Okt. 17, 2014, 9:38 nachm., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120627

Re: Porting KUrl::prettyUrl: please do not reintroduce CVE-2013-2074!

2014-10-17 Thread Kevin Kofler
moderation.) Kevin Kofler

QUrl from a string (porting KUrl constructor or KCmdLineArgs::url)

2014-10-17 Thread Kevin Kofler
path that I'm missing?) Kevin Kofler

  1   2   >