Re: Review Request 110271: libusb-1 support in kcmusb (kinfocenter)

2013-05-12 Thread Max Brazhnikov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110271/#review32376 --- On May 11, 2013, 9:14 p.m., Max Brazhnikov wrote

Re: Review Request 110271: libusb-1 support in kcmusb (kinfocenter)

2013-05-11 Thread Max Brazhnikov
. Thanks, Max Brazhnikov

Re: Review Request 110271: libusb-1 support in kcmusb (kinfocenter)

2013-05-05 Thread Max Brazhnikov
Am 02.05.2013 15:49, schrieb Max Brazhnikov: Use libusb-1 to query info about usb devices in kinfocenter. Remove *BSD specific code: it doesn't work on all supported FreeBSD versions. In principle it can be saved for NetBSD, but NetBSD could use libusb-1, thus drop it for simplification

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

2013-05-05 Thread Max Brazhnikov
Ok, here's a patch for GetInfo_ReadfromPipe only: http://people.freebsd.org/~makc/patches/read_from_pipe.diff Looks good to me (although I have not tested it). Small note: there is a contructor of QStringList taking a QString so if you have a list with only one item you don't need to

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

2013-05-02 Thread Max Brazhnikov
On Wed, 01 May 2013 14:44:39 +0200 Rolf Eike Beer wrote: On April 20, 2013, 2:11 p.m., Rolf Eike Beer wrote: kinfocenter/Modules/base/info_fbsd.cpp, line 136 http://git.reviewboard.kde.org/r/110091/diff/1/?file=139992#file139992l ine136 Why not just use QProcess here to

Review Request 110271: libusb-1 support in kcmusb (kinfocenter)

2013-05-02 Thread Max Brazhnikov
/Modules/usbview/usbdevices.cpp 9bd7033 Diff: http://git.reviewboard.kde.org/r/110271/diff/ Testing --- I've tested it only on FreeBSD. It would nice to test at least FindLibUSB-1.cmake on other OSes. Thanks, Max Brazhnikov

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

2013-04-30 Thread Max Brazhnikov
/CMakeLists.txt dba6bc7 Diff: http://git.reviewboard.kde.org/r/110091/diff/ Testing --- Thanks, Max Brazhnikov

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

2013-04-30 Thread Max Brazhnikov
. To reply, visit: http://git.reviewboard.kde.org/r/110091/#review31332 --- On April 30, 2013, 11:50 a.m., Max Brazhnikov wrote: --- This is an automatically generated e-mail. To reply

Review Request 110090: Clean up kickoff from stale bits

2013-04-19 Thread Max Brazhnikov
to strigiqtdbusclient, but Strigi is not used since svn r1018482. Diffs - plasma/desktop/applets/kickoff/CMakeLists.txt e9e2888 plasma/desktop/applets/kickoff/core/config-kickoff-applets.h.cmake cecf380 Diff: http://git.reviewboard.kde.org/r/110090/diff/ Testing --- Thanks, Max

Review Request 110091: clean up and update FreeBSD support for kinfocenter

2013-04-19 Thread Max Brazhnikov
://git.reviewboard.kde.org/r/110091/diff/ Testing --- Thanks, Max Brazhnikov